diff mbox series

[13/13] configure: reenable plugins by default for 32-bit hosts

Message ID 20241217010707.2557258-14-pierrick.bouvier@linaro.org
State Superseded
Headers show
Series Fix 32-bit build for plugins | expand

Commit Message

Pierrick Bouvier Dec. 17, 2024, 1:07 a.m. UTC
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 configure | 21 +--------------------
 1 file changed, 1 insertion(+), 20 deletions(-)

Comments

Richard Henderson Dec. 17, 2024, 3:38 p.m. UTC | #1
On 12/16/24 19:07, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   configure | 21 +--------------------
>   1 file changed, 1 insertion(+), 20 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

> 
> diff --git a/configure b/configure
> index 18336376bff..02f1dd2311f 100755
> --- a/configure
> +++ b/configure
> @@ -528,25 +528,6 @@ case "$cpu" in
>       ;;
>   esac
>   
> -# Now we have our CPU_CFLAGS we can check if we are targeting a 32 or
> -# 64 bit host.
> -
> -check_64bit_host() {
> -cat > $TMPC <<EOF
> -#if __SIZEOF_POINTER__ != 8
> -#error not 64 bit system
> -#endif
> -int main(void) { return 0; }
> -EOF
> -  compile_object "$1"
> -}
> -
> -if check_64bit_host "$CPU_CFLAGS"; then
> -    host_bits=64
> -else
> -    host_bits=32
> -fi
> -
>   if test -n "$host_arch" && {
>       ! test -d "$source_path/linux-user/include/host/$host_arch" ||
>       ! test -d "$source_path/common-user/host/$host_arch"; }; then
> @@ -1072,7 +1053,7 @@ if test "$static" = "yes" ; then
>     fi
>     plugins="no"
>   fi
> -if test "$plugins" != "no" && test $host_bits -eq 64; then
> +if test "$plugins" != "no"; then
>       if has_meson_option "-Dtcg_interpreter=true"; then
>           plugins="no"
>       else
diff mbox series

Patch

diff --git a/configure b/configure
index 18336376bff..02f1dd2311f 100755
--- a/configure
+++ b/configure
@@ -528,25 +528,6 @@  case "$cpu" in
     ;;
 esac
 
-# Now we have our CPU_CFLAGS we can check if we are targeting a 32 or
-# 64 bit host.
-
-check_64bit_host() {
-cat > $TMPC <<EOF
-#if __SIZEOF_POINTER__ != 8
-#error not 64 bit system
-#endif
-int main(void) { return 0; }
-EOF
-  compile_object "$1"
-}
-
-if check_64bit_host "$CPU_CFLAGS"; then
-    host_bits=64
-else
-    host_bits=32
-fi
-
 if test -n "$host_arch" && {
     ! test -d "$source_path/linux-user/include/host/$host_arch" ||
     ! test -d "$source_path/common-user/host/$host_arch"; }; then
@@ -1072,7 +1053,7 @@  if test "$static" = "yes" ; then
   fi
   plugins="no"
 fi
-if test "$plugins" != "no" && test $host_bits -eq 64; then
+if test "$plugins" != "no"; then
     if has_meson_option "-Dtcg_interpreter=true"; then
         plugins="no"
     else