From patchwork Tue Dec 17 17:19:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 851438 Delivered-To: patch@linaro.org Received: by 2002:a5d:4888:0:b0:385:e875:8a9e with SMTP id g8csp481684wrq; Tue, 17 Dec 2024 09:23:16 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCX+4KXXLbJpqo3V1LXEGKKCCfzhlBnhhq7NOunero6SnvHzMwXOQMdulHE6xebNJDt/0YdThA==@linaro.org X-Google-Smtp-Source: AGHT+IHG2IcFNP4iaqc+2NxWRs1XRcbxDqOkSXBqGwnv3iundx0weE1dYF5gbvB88TI4oTUFVthU X-Received: by 2002:ad4:5d4b:0:b0:6d3:fa03:23f1 with SMTP id 6a1803df08f44-6dcf42518b7mr76631716d6.13.1734456196096; Tue, 17 Dec 2024 09:23:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1734456196; cv=none; d=google.com; s=arc-20240605; b=aRJ/DA7em3NdE1M36N4tDvoZH7cD/G/NcmLtb1C+rnH4sbIqb2S6iZiKDnOX95qpp4 lwlXYFlShAt0dmw2Pt5r9799dEVZ5f0MlqHJtz4Q+HGI4wA8zyMh3TukotQeYsF7FC4J rbQ/7eorDxh9Cjspm7eUzyIQJezhP49ZlQSfBZVnUnPfYe7KK7BgPGx3ytoJPa52UyEt jTX9B6SZ1XJD6T2gPTEauNdRmFML4S8LlaYAaynVHEytnoxLVVNXfZGBgDS84opDnPU5 /XfUA36pbo5t/o1JwcEt/9/mhMS9VN+XFma8ge+tHBKD+OUqZMlxvi4oOzUFy5MP5mKo h1yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=WJ/CPb13gYil8uu9o2JlnbILGe0I31RG8COUNiZ0+GI=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=A23vphA1Dd8OyWFXNRfqIQ6TdGXUvgpjxNhXhwLi5hsUIpwUyWDe7rL/hiO4Plk10R lO+Vj6scCBylu0HMhuEpDyXJfyLYyocyifRUNn20pLOjFGsrGqpW1phVZwuKcACu6+2R P4NoAA5G970OsQ4sQJjkeuPjHZAZZhD+JdYZyE1hIwib24lE1VnCDK8GYimcaXvEGG1/ O+KnMgrhCMbe4UQxIWuZDbiR4YXOtM+M9PNztLoJadBvFEnM0zddmW3j4H7XP62hrGOH 4TcMKuCxE6SekdZlTpWaZFgEpV7pJxSUw5EDOgHb0Cd9S4el+6sQyHQgYCZWkXn6vdz8 E3KA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=POvBDQ4W; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6dccd39afccsi112635796d6.483.2024.12.17.09.23.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Dec 2024 09:23:16 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=POvBDQ4W; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNbEm-0007uU-1T; Tue, 17 Dec 2024 12:20:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNbEj-0007tK-9m for qemu-devel@nongnu.org; Tue, 17 Dec 2024 12:19:57 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNbEa-0006AB-8a for qemu-devel@nongnu.org; Tue, 17 Dec 2024 12:19:55 -0500 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-385f06d0c8eso2787551f8f.0 for ; Tue, 17 Dec 2024 09:19:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734455985; x=1735060785; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=WJ/CPb13gYil8uu9o2JlnbILGe0I31RG8COUNiZ0+GI=; b=POvBDQ4W2SGg8QaD70O4oNJSj3LCkK0cn8FL2m4g59YDM3Ig1Hq6Nuqcx1YCPdfUK9 IxEPIT1Cxc2rRo6HTVS0KNOejO5OL7/TPWI7DyEfyKbaoIkARW43aXxKmZ1/RIBJyd1A JvJPRt/VXcn3i3p46bY6qSkmPShDAky2xnLukST8q5N+oBaadbItxIDA8IC4bL0xAPWp xMu5qmSiY1ZxWkXb/Ej0nAA5w4bu2mjZkggkS9u4EtMHN9BhiX7FbhOXgTuJ4UeKcZ+s XQF+dd9Msxfo/CxFOmENDL5C2fNjEg4homPjo2jXhdXXmABFYToC7s/rWwMz8hVpQ1oS VJCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734455985; x=1735060785; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WJ/CPb13gYil8uu9o2JlnbILGe0I31RG8COUNiZ0+GI=; b=JU9ygzQ8A4exXaVKWALzmGbWMBlOnXJtOHtdlHVVAQFgfOFZl0+lT+Iz/tmcMdI6qw S/pwXKe/GLFsZ11k5s5gcY/SB9uMpwGuTqsbQdyFzDSmxQqRcuAx26u+S3etEVyMVEs8 u2a1wLElS02GnYw59ZX2Ix+vltu/0UQcdS9zP+kzK2mKJQzTcrE+XttBD9X469Wvd5dp SSinGFZvFLcWFsx06myDvShwDb1ebNKz2zq4zYiBpafitM1aQcqM18B7z61qaujb34lC vTS4U1U/hDaXE7kyww8zIvXj72ShmCRrBlmvm1NyWlpSCtf4MsPRIGjh2t+xZjV9W/eh fANw== X-Gm-Message-State: AOJu0Ywx7G4ZyONHEXeCXEZG/i0z+CNqlzvJDzQeXOBLVXXe9f1P0YgP 6mr5Uv5c4y9XQQ25PkohfFt4kLbEI8S6Q7pRHBRM53appkA81EeNyvgZV/aDe/2zd2m0PcJKlFW B X-Gm-Gg: ASbGncvFPWaNusWauGlMpCrqF0YSmNHgU9XDOx5ye3iPxoRKw4mzltZmutPmYKaw23J CnVSbvrwfKmOMZBmwrVsNF+9d5wJWQTPcFcZ/+Ge2nFWgLRtLBMQduMTKA9qfTjiG9MDDNJVMOJ /RckHl6ZDDSMF00ZQbt+1+rknTxqYr3bbAuConO2LAbOHYvbaSd4XWv+p17vluqe9xnmvrGw5Gi HmrYDPQdA5y57da2r4SxjC9uIhqf8peAaXZfROou0RyJo8f40BwH4K2AHqlAKA= X-Received: by 2002:a5d:6da2:0:b0:386:2ebe:7aeb with SMTP id ffacd0b85a97d-3888e0b887dmr15058607f8f.44.1734455985323; Tue, 17 Dec 2024 09:19:45 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c8016389sm11569728f8f.32.2024.12.17.09.19.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 09:19:44 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 05/19] target/arm: Convert neon_helper.c to fpst alias Date: Tue, 17 Dec 2024 17:19:23 +0000 Message-Id: <20241217171937.3899947-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241217171937.3899947-1-peter.maydell@linaro.org> References: <20241217171937.3899947-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20241206031224.78525-6-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h | 14 +++++++------- target/arm/tcg/neon_helper.c | 21 +++++++-------------- 2 files changed, 14 insertions(+), 21 deletions(-) diff --git a/target/arm/helper.h b/target/arm/helper.h index 8ba9e1ce6f0..9a1b6d1b6d7 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -424,13 +424,13 @@ DEF_HELPER_FLAGS_2(neon_qneg_s16, TCG_CALL_NO_RWG, i32, env, i32) DEF_HELPER_FLAGS_2(neon_qneg_s32, TCG_CALL_NO_RWG, i32, env, i32) DEF_HELPER_FLAGS_2(neon_qneg_s64, TCG_CALL_NO_RWG, i64, env, i64) -DEF_HELPER_3(neon_ceq_f32, i32, i32, i32, ptr) -DEF_HELPER_3(neon_cge_f32, i32, i32, i32, ptr) -DEF_HELPER_3(neon_cgt_f32, i32, i32, i32, ptr) -DEF_HELPER_3(neon_acge_f32, i32, i32, i32, ptr) -DEF_HELPER_3(neon_acgt_f32, i32, i32, i32, ptr) -DEF_HELPER_3(neon_acge_f64, i64, i64, i64, ptr) -DEF_HELPER_3(neon_acgt_f64, i64, i64, i64, ptr) +DEF_HELPER_3(neon_ceq_f32, i32, i32, i32, fpst) +DEF_HELPER_3(neon_cge_f32, i32, i32, i32, fpst) +DEF_HELPER_3(neon_cgt_f32, i32, i32, i32, fpst) +DEF_HELPER_3(neon_acge_f32, i32, i32, i32, fpst) +DEF_HELPER_3(neon_acgt_f32, i32, i32, i32, fpst) +DEF_HELPER_3(neon_acge_f64, i64, i64, i64, fpst) +DEF_HELPER_3(neon_acgt_f64, i64, i64, i64, fpst) /* iwmmxt_helper.c */ DEF_HELPER_2(iwmmxt_maddsq, i64, i64, i64) diff --git a/target/arm/tcg/neon_helper.c b/target/arm/tcg/neon_helper.c index c687e882ad9..99fbebbe14a 100644 --- a/target/arm/tcg/neon_helper.c +++ b/target/arm/tcg/neon_helper.c @@ -1180,51 +1180,44 @@ uint64_t HELPER(neon_qneg_s64)(CPUARMState *env, uint64_t x) * Note that EQ doesn't signal InvalidOp for QNaNs but GE and GT do. * Softfloat routines return 0/1, which we convert to the 0/-1 Neon requires. */ -uint32_t HELPER(neon_ceq_f32)(uint32_t a, uint32_t b, void *fpstp) +uint32_t HELPER(neon_ceq_f32)(uint32_t a, uint32_t b, float_status *fpst) { - float_status *fpst = fpstp; return -float32_eq_quiet(make_float32(a), make_float32(b), fpst); } -uint32_t HELPER(neon_cge_f32)(uint32_t a, uint32_t b, void *fpstp) +uint32_t HELPER(neon_cge_f32)(uint32_t a, uint32_t b, float_status *fpst) { - float_status *fpst = fpstp; return -float32_le(make_float32(b), make_float32(a), fpst); } -uint32_t HELPER(neon_cgt_f32)(uint32_t a, uint32_t b, void *fpstp) +uint32_t HELPER(neon_cgt_f32)(uint32_t a, uint32_t b, float_status *fpst) { - float_status *fpst = fpstp; return -float32_lt(make_float32(b), make_float32(a), fpst); } -uint32_t HELPER(neon_acge_f32)(uint32_t a, uint32_t b, void *fpstp) +uint32_t HELPER(neon_acge_f32)(uint32_t a, uint32_t b, float_status *fpst) { - float_status *fpst = fpstp; float32 f0 = float32_abs(make_float32(a)); float32 f1 = float32_abs(make_float32(b)); return -float32_le(f1, f0, fpst); } -uint32_t HELPER(neon_acgt_f32)(uint32_t a, uint32_t b, void *fpstp) +uint32_t HELPER(neon_acgt_f32)(uint32_t a, uint32_t b, float_status *fpst) { - float_status *fpst = fpstp; float32 f0 = float32_abs(make_float32(a)); float32 f1 = float32_abs(make_float32(b)); return -float32_lt(f1, f0, fpst); } -uint64_t HELPER(neon_acge_f64)(uint64_t a, uint64_t b, void *fpstp) +uint64_t HELPER(neon_acge_f64)(uint64_t a, uint64_t b, float_status *fpst) { - float_status *fpst = fpstp; float64 f0 = float64_abs(make_float64(a)); float64 f1 = float64_abs(make_float64(b)); return -float64_le(f1, f0, fpst); } -uint64_t HELPER(neon_acgt_f64)(uint64_t a, uint64_t b, void *fpstp) +uint64_t HELPER(neon_acgt_f64)(uint64_t a, uint64_t b, float_status *fpst) { - float_status *fpst = fpstp; float64 f0 = float64_abs(make_float64(a)); float64 f1 = float64_abs(make_float64(b)); return -float64_lt(f1, f0, fpst);