From patchwork Mon Jan 27 23:26:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 860286 Delivered-To: patch@linaro.org Received: by 2002:a5d:6b8c:0:b0:385:e875:8a9e with SMTP id n12csp107118wrx; Mon, 27 Jan 2025 15:30:01 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUO1i670cOoZFlmHwibesXUeOyt7cKRJTC8f0kqSxNVeNBqxv8+hrLIihoE70HC8kNJ+pblrg==@linaro.org X-Google-Smtp-Source: AGHT+IEN8UTMZm8OqA103czukoyAsUb/QjU3/atPOESopSayoqr4A3GYnzVcVpRRU4wyCIr/tm/f X-Received: by 2002:ac8:5907:0:b0:467:5e4f:3d1 with SMTP id d75a77b69052e-46e12b90bc8mr650485531cf.33.1738020601094; Mon, 27 Jan 2025 15:30:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738020601; cv=none; d=google.com; s=arc-20240605; b=ZgJHqAnPUhFZ7ROw9C52MCzw/AE300mxbqpM/zbDNPZsxir/8vfecIYNMoo3eTKVn8 V8QOiifUuowRay2y5YvXj6czr8NxyPRktNoHaBBuNEoSoDTJ0LupAB1a4Eanluwc40ss TZamGH2UQMPzlS+qTbZoZCsrOxOThxw5GoesDNSLyAaq/P8USX0UYm22pDrYWmIViegx /6ZNl+bDU8UPl0drRLS7EJXAe9IUwR9l54H548fqZrjMDHlKAE7TRiQJ0ppRbPxrdZn6 rf6R+3HPVkthvKGlORawZ9SK4VN+Q0ek4IVU78Ffd791lOq4hbaPDzn098GydY+NhMQS A9XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rk7p3KoLMaA8jIVTStdirSWe3SnWd0+FSfM/mtBWd+A=; fh=igfKki9zV5i/IfmDn/Sk23mhfaq7a0iqiBvPmqdBsis=; b=YdCqIpf+fbZQPGT1IBo+XKSav62fqMQvld+WFJ53axVEAx68Ct4SE6pHkUZ2CJxkq4 u+RnSR9cLQDS6+udCXg1TXi1ozI1wex+kFdhXqWh4+aViyQqo2GL8BrxSIVJTjKcGFTc 7grjDyBk2Usb7UXvkTL8R+WkL91ZHuQWXYhe+aAVlW1HmYV97we4YHddPIEDPabI67Zi ANAZy3toWw5OtUTicLJhECy1qwn3+y3w0aUAMmY2iIToBIKg63ZFBUzvM4G3S1Efgdt9 eIgm7nQs0VrXw5MtAiBMhjgWTmShKksZSYDXEXjTOsBth57AckH189gDGXQhiYQJxtkb egVA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nwKEgd41; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-46e66b67bd9si118249751cf.226.2025.01.27.15.30.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2025 15:30:01 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nwKEgd41; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tcYV6-0006eI-Gm; Mon, 27 Jan 2025 18:26:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcYUq-0006RS-O9 for qemu-devel@nongnu.org; Mon, 27 Jan 2025 18:26:24 -0500 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tcYUo-0005eE-NZ for qemu-devel@nongnu.org; Mon, 27 Jan 2025 18:26:24 -0500 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-2f441904a42so8838740a91.1 for ; Mon, 27 Jan 2025 15:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738020381; x=1738625181; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rk7p3KoLMaA8jIVTStdirSWe3SnWd0+FSfM/mtBWd+A=; b=nwKEgd41n42P9Z/QJibebnIX2HxAlpXQcQNxebz2zAwvvlLywnEg2utCEBJRP/UDCI WhEqfabPHoeYFdQntw5G4hPCv5jn7ifvO+0Ykr5m6J/64FeM7udrs3MmICSW10MYvGT7 JIXOzkwu9Cicn+Zd1h8t1DXSlekQTEVV9G0pA7WMBoJf3LiK4zOwR7Ji3YVdlBD4ZgMs vhei0TbL0iWm+YfZQzy3NWFlibEdDWcIDpHYuKzhoc3B9OZRWEbd8GuzVjE6Oho7PouJ bPd0445KQuORt1hnruJaor04aP+r2DUFK/jy6kZ2Hg9e587kleEmdWTJfP+fhgd2ThBy 8QTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738020381; x=1738625181; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rk7p3KoLMaA8jIVTStdirSWe3SnWd0+FSfM/mtBWd+A=; b=lpGL3uKiDmpAqFzrDuIawZoyUq3UvIoe0r6/XvM4QjKJ7NfZTpZHETe6uFsZzYMHMS EP5B0ivWh6q3sFR3euCTiplXw0NcZZtMo92KUhNOpKsgi21SLJAtW145tySZNPDEkRXe R4ThtxvO/R3L0mvzCV+RK9sHdIfVUy6Bjgh7HKBoqXdU3JhZ/Q5YmP55NGibLZfy5+VG q3vRj3NXqxfx0dsOzK0YVhfz6+A0vZ//SyDu6nu7K1//enQJexYI0NXzmfk+fyi9n1HL MHFYXKBhswUU/dqH6x5NHcPIsMs7OzixCqogM89PYytS2piT5swKURdYR3kgCxZDbjzQ 7nxg== X-Gm-Message-State: AOJu0YzdX85i2ad2RivVf3ZLs9klHbcCYY495GS26J58t7gFxUi1ltVc iKm607UROap2r3KQWj+oABDWuBH9k5DQvpTjy8S4/K2fAIh4oWMUJbjEBl/Yv7V/A8vrE5qTlgr x X-Gm-Gg: ASbGncu/29vVoxr1YP7kXPREvqEUEupPhe9of9d66oCSWZutVJcZEwiSCHV0FlvN1sW +9qClrHqBfgBY4edEGK9Jkx7Pl76Wog+hnXMD1IUfIz9koNEBLLsXzMO0kG2F+hQP2HjzKIrWqs gRs0Q5+Ah4H+BPaGBe89p3vF511/QnHw5bRO7GXO/sq26GedPo6tHHbT+HV3SvH2dVUcmzDtjF7 f7YTy10NnvNl9yWBOTLARMpYAQfSyE3zp6qB5kUIRwLrtzzEZLxq9LkopzEfTWFXCU4Y3JSkiSW bEfVuAHsaHKQ8Ps1kQ7jcApe2ylnFQ0ifjef7yM= X-Received: by 2002:a17:90b:2dcd:b0:2ee:df70:1ff3 with SMTP id 98e67ed59e1d1-2f782b17a01mr74838549a91.0.1738020381450; Mon, 27 Jan 2025 15:26:21 -0800 (PST) Received: from stoup.. (174-21-71-127.tukw.qwest.net. [174.21.71.127]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7ffb1b31esm7833000a91.47.2025.01.27.15.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2025 15:26:21 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Subject: [PATCH 20/22] target/arm: Use float*_maybe_ah_chs in sve_ftmad_* Date: Mon, 27 Jan 2025 15:26:02 -0800 Message-ID: <20250127232604.20386-21-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250127232604.20386-1-richard.henderson@linaro.org> References: <20250127232604.20386-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since we know the operand is negative, absolute value can be had by negating rather than abs per se. Signed-off-by: Richard Henderson --- target/arm/tcg/sve_helper.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/target/arm/tcg/sve_helper.c b/target/arm/tcg/sve_helper.c index a2ff3b7f11..970947e1ca 100644 --- a/target/arm/tcg/sve_helper.c +++ b/target/arm/tcg/sve_helper.c @@ -5150,9 +5150,7 @@ void HELPER(sve_ftmad_h)(void *vd, void *vn, void *vm, float16 mm = m[i]; intptr_t xx = x; if (float16_is_neg(mm)) { - if (!(fpcr_ah && float16_is_any_nan(mm))) { - mm = float16_abs(mm); - } + mm = float16_maybe_ah_chs(mm, fpcr_ah); xx += 8; } d[i] = float16_muladd(n[i], mm, coeff[xx], 0, s); @@ -5176,9 +5174,7 @@ void HELPER(sve_ftmad_s)(void *vd, void *vn, void *vm, float32 mm = m[i]; intptr_t xx = x; if (float32_is_neg(mm)) { - if (!(fpcr_ah && float32_is_any_nan(mm))) { - mm = float32_abs(mm); - } + mm = float32_maybe_ah_chs(mm, fpcr_ah); xx += 8; } d[i] = float32_muladd(n[i], mm, coeff[xx], 0, s); @@ -5206,9 +5202,7 @@ void HELPER(sve_ftmad_d)(void *vd, void *vn, void *vm, float64 mm = m[i]; intptr_t xx = x; if (float64_is_neg(mm)) { - if (!(fpcr_ah && float64_is_any_nan(mm))) { - mm = float64_abs(mm); - } + mm = float64_maybe_ah_chs(mm, fpcr_ah); xx += 8; } d[i] = float64_muladd(n[i], mm, coeff[xx], 0, s);