From patchwork Fri Feb 7 16:20:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Igor Mammedov X-Patchwork-Id: 862997 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e42:0:b0:385:e875:8a9e with SMTP id r2csp410613wrt; Fri, 7 Feb 2025 08:21:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUugoP8kEQJQCOCxqwPzBUHCevncRiT2CpOXWZgBsgZ3RZBL7S1qMO74pi/CjbMaBYTKFUxVw==@linaro.org X-Google-Smtp-Source: AGHT+IHNO3KB+Hw237eErF3hLc0mMsNJC0b95HUd8NIolr4MwApumIw39uLQqFPW7ga0jBEbwlG0 X-Received: by 2002:a05:620a:bd5:b0:7b1:4f5c:a3a3 with SMTP id af79cd13be357-7c047c49ea9mr604003285a.56.1738945314177; Fri, 07 Feb 2025 08:21:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738945314; cv=none; d=google.com; s=arc-20240605; b=NAejk1e9BHJm3zeClYomhzP/+e4ixgeVrbBLJy/W+w8D5WiLAGqyR9cAW7UsSjCT2D gM7L1cOb51XFw3KEPowZpk2Iq8q8xTIwlXuph/xH4979KDRKVxpyDiBIrKEyRB6Tk2/i JnIu+5+DayqQ+w6IvBs3WOYN85qKCS4BeCgpdwTKEd/l0VHKqwxwQbH5IWR+jDrafvOl cXl3iQ40bDLlGN9zpkLPBC9QwPSaiimiNVPJqp2H0JDu+0E9uQUUhEIQdi5YX1MZPApR KCPlCiTQRoeFg5xI3+yciE5WxwfwI2y1VzfmTk3+WSDCATLLe/upAavinn7OewxEksZg iknA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3WVrexRlab32QyhpO6UTZhs06SRUtIvJ5qxTfzSBSSg=; fh=PgKpMPhWDepZ3bXqZokANgkoavwJ2TlblR8cMi91wfY=; b=iOpLiNUxqoleI7XDeK3zGBTsPJoyl4OcpGuDHghnczmVkUwrStK9EtTMgByaPv3gzL qOsAtSpU1IdNcUybiB4UfCOUs67wr78GthWI09vpu13GJ03Xlztr49Cm2HzqtznaVADK ikgeodbSsUMUJ7ClGDk/ezcARVI/wi0CLygNOs1IEOfUo8hhyKA58CFETO4yBX/wTpXs CTC56dcxjS65l7REETQmGoLDlteNZWu6fe+SjH5Ks4UsdV9Cgn+ppOFWsbFOfBKiklKi qB680nlXktXNf/slVWzzgmwyImJ1Bnz2bQ3JkynMJo0F08klxhF+xO4hKkG8wyx1WzXt B1WA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DWVulNy8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c041ee72e9si349872785a.634.2025.02.07.08.21.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Feb 2025 08:21:54 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DWVulNy8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tgR6p-0000y2-Rq; Fri, 07 Feb 2025 11:21:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgR6d-0000uo-98 for qemu-devel@nongnu.org; Fri, 07 Feb 2025 11:21:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgR6b-0007k6-Ps for qemu-devel@nongnu.org; Fri, 07 Feb 2025 11:21:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738945285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WVrexRlab32QyhpO6UTZhs06SRUtIvJ5qxTfzSBSSg=; b=DWVulNy8o6pjNdhFMmNcUontmIS8VGSfaPJF/UFpPCLqDxQlQedlTh+vHQ9iPiungbqK9S uUqaXMOKNrzXc8+lcKKY8hH+JZMTId04LzefugOtRhRXFULENnu+KqCXJNoe+S76YYbgOu QqDLjhsai7HjfgYAeNY5UtrK1c7Npw0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-326--t9MizpNPHC3KSb7onlIuw-1; Fri, 07 Feb 2025 11:21:21 -0500 X-MC-Unique: -t9MizpNPHC3KSb7onlIuw-1 X-Mimecast-MFC-AGG-ID: -t9MizpNPHC3KSb7onlIuw Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6DC0219560AD; Fri, 7 Feb 2025 16:21:19 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq2.redhat.com (dell-r430-03.lab.eng.brq2.redhat.com [10.37.153.18]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9C870180087A; Fri, 7 Feb 2025 16:21:17 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , =?utf-8?q?Alex_Benn=C3=A9e?= , kvm@vger.kernel.org Subject: [PATCH v2 10/10] accel/kvm: Remove unreachable assertion in kvm_dirty_ring_reap*() Date: Fri, 7 Feb 2025 17:20:48 +0100 Message-ID: <20250207162048.1890669-11-imammedo@redhat.com> In-Reply-To: <20250207162048.1890669-1-imammedo@redhat.com> References: <20250207162048.1890669-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Previous commit passed all our CI tests, this assertion being never triggered. Remove it as dead code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Igor Mammedov --- CC: kvm@vger.kernel.org --- accel/kvm/kvm-all.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index cb56d120a9..814b1a53eb 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -830,13 +830,6 @@ static uint32_t kvm_dirty_ring_reap_one(KVMState *s, CPUState *cpu) uint32_t ring_size = s->kvm_dirty_ring_size; uint32_t count = 0, fetch = cpu->kvm_fetch_index; - /* - * It's not possible that we race with vcpu creation code where the vcpu is - * put onto the vcpus list but not yet initialized the dirty ring - * structures. - */ - assert(cpu->created); - assert(dirty_gfns && ring_size); trace_kvm_dirty_ring_reap_vcpu(cpu->cpu_index);