diff mbox series

[v4,4/9] meson: Disallow 64-bit on 32-bit HVF/NVMM/WHPX emulation

Message ID 20250207210655.16717-5-richard.henderson@linaro.org
State Superseded
Headers show
Series meson: Deprecate 32-bit host support | expand

Commit Message

Richard Henderson Feb. 7, 2025, 9:06 p.m. UTC
Require a 64-bit host binary to spawn a 64-bit guest.

For HVF this is trivially true because macOS 11 dropped
support for 32-bit applications entirely.

For NVMM, NetBSD only enables nvmm on x86_64:
  http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/nvmm/Makefile?rev=1.1.6.2;content-type=text%2Fplain

For WHPX, we have already dropped support for 32-bit Windows.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 meson.build | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Philippe Mathieu-Daudé Feb. 8, 2025, 4:43 p.m. UTC | #1
On 7/2/25 22:06, Richard Henderson wrote:
> Require a 64-bit host binary to spawn a 64-bit guest.
> 
> For HVF this is trivially true because macOS 11 dropped
> support for 32-bit applications entirely.
> 
> For NVMM, NetBSD only enables nvmm on x86_64:
>    http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/nvmm/Makefile?rev=1.1.6.2;content-type=text%2Fplain
> 
> For WHPX, we have already dropped support for 32-bit Windows.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   meson.build | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Phil Dennis-Jordan Feb. 9, 2025, 6:39 p.m. UTC | #2
On Fri, 7 Feb 2025 at 22:07, Richard Henderson <richard.henderson@linaro.org>
wrote:

> Require a 64-bit host binary to spawn a 64-bit guest.
>
> For HVF this is trivially true because macOS 11 dropped
> support for 32-bit applications entirely.


Nit: it was 10.15.


> For NVMM, NetBSD only enables nvmm on x86_64:
>
> http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/nvmm/Makefile?rev=1.1.6.2;content-type=text%2Fplain
>
> For WHPX, we have already dropped support for 32-bit Windows.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>

Reviewed-by: Phil Dennis-Jordan <phil@philjordan.eu>


> ---
>  meson.build | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 911955cfa8..85317cd63f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -319,13 +319,11 @@ else
>  endif
>  accelerator_targets += { 'CONFIG_XEN': xen_targets }
>
> -if cpu in ['aarch64']
> +if cpu == 'aarch64'
>    accelerator_targets += {
>      'CONFIG_HVF': ['aarch64-softmmu']
>    }
> -endif
> -
> -if cpu in ['x86', 'x86_64']
> +elif cpu == 'x86_64'
>    accelerator_targets += {
>      'CONFIG_HVF': ['x86_64-softmmu'],
>      'CONFIG_NVMM': ['i386-softmmu', 'x86_64-softmmu'],
> --
> 2.43.0
>
>
>
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index 911955cfa8..85317cd63f 100644
--- a/meson.build
+++ b/meson.build
@@ -319,13 +319,11 @@  else
 endif
 accelerator_targets += { 'CONFIG_XEN': xen_targets }
 
-if cpu in ['aarch64']
+if cpu == 'aarch64'
   accelerator_targets += {
     'CONFIG_HVF': ['aarch64-softmmu']
   }
-endif
-
-if cpu in ['x86', 'x86_64']
+elif cpu == 'x86_64'
   accelerator_targets += {
     'CONFIG_HVF': ['x86_64-softmmu'],
     'CONFIG_NVMM': ['i386-softmmu', 'x86_64-softmmu'],