From patchwork Mon Mar 10 01:28:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 872171 Delivered-To: patch@linaro.org Received: by 2002:a5d:64ce:0:b0:38f:210b:807b with SMTP id f14csp764567wri; Sun, 9 Mar 2025 18:30:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUyZyhTXbnizXp7hD37TNwkZUXvQOi/MwK/w6h3jkLGq2yF7v9FtrmN7GBUlx9iUIJD2PvnHQ==@linaro.org X-Google-Smtp-Source: AGHT+IENdpOW/o6WXn3oZUoMmJKOnGa+l4iOQfC64hnREijZKTt1+yRTpJONZdwLkrBBl4Ht5p1g X-Received: by 2002:a05:620a:6089:b0:7c5:49b7:237c with SMTP id af79cd13be357-7c549b723f2mr664960985a.27.1741570223684; Sun, 09 Mar 2025 18:30:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1741570223; cv=none; d=google.com; s=arc-20240605; b=O/5f34/K+b2aJlumy+m8gbA59HnDSM9UOUviCqHKKHtzr0eLC65J+wS0NEhi7xe56i uvM5dH5qGX3gdmWWs/AJ5ZOwdeQ02sdKV2/FKF6M4rKsbG7Et4kcXFE4n/wAtJLvCcar W0zBYQLEtnM0cH3Z0BN/Swhs3dehDFSRQmsSjQ++Y3Q3M/O6+Ax11xWstCv1J6Asdm+z xiomwlEpmXAN9TrbcUa8uOtdjwDXdlyabq55eTOQ2CZU+osOxMgqklzsL6XmEDs46gIR 3Atn4BUTBj7g819dG8gff+tc3P83aGfVbhCW9gUEJ8+EQ7jzbyewYOiJEH6YNKd7PaNv y+OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wS79SS1CQxxkd3qnon8nNpovVlwqoGNVt9KU+09W3OY=; fh=EPO+XMDoylG26O8AfLK4l02IrH8PqYL7jb8PVK09dDA=; b=gW8y55c0c8N9AwpAH5PWBPlrBCjedidI7SS+PLB52L+o4ko2Y+d/dhUKHENKpbNNTc 21OKO+JpzpjatcgF7gbhJzjFsTDPBAQczKYWs+MnebOh0jp6YOC9fI+pWQ+JfdNC7rIy 0CRL+BrJJ7+sOe1gyBylYHgy3kIDADjLGhyfFpy5KvcijW9zxsMvpfLZ2nGz7zVrspMO 6wJaWupbN1HadsbAQsZdEOVWrzVQKLCJXom+r1ISouYNaNFrVzxOrrgPshrAQHp9xBK4 7/vwIO3xQrXpt7m6jL3Y1ZFh4eNQu74A2hdGliOv3DEbz28mLPFUVjV5uSJO/Ylka9pL YTLg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Sh9rTsV9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c543493093si350373885a.364.2025.03.09.18.30.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 09 Mar 2025 18:30:23 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Sh9rTsV9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trRwx-00045E-Gh; Sun, 09 Mar 2025 21:28:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trRws-00043d-Mu for qemu-devel@nongnu.org; Sun, 09 Mar 2025 21:28:54 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1trRwr-0006T0-0K for qemu-devel@nongnu.org; Sun, 09 Mar 2025 21:28:54 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-43690d4605dso21509495e9.0 for ; Sun, 09 Mar 2025 18:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741570130; x=1742174930; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wS79SS1CQxxkd3qnon8nNpovVlwqoGNVt9KU+09W3OY=; b=Sh9rTsV9fmGjKOKmxQtfUekDlfPLJKDn8zH6SXpz4XysntLgSvDG8u4ErurzWw3V0u BIirtzv3a4rwaHB7LCQcwnFC2Yh9lWSUs0Phn4UrsBRKHQL8uE5DlHTrsOlDmhhxSpyT TQxg134EJaIeoSRMnLfXmKEQPa3p0z0MyLUhUqogk79TicqGPhaA5R4g836urN8Q/8iD yVL8FBWBaGlqxasb69YuwuBNCVLABgBbcLTzXGooqHMh3gFIRKOfpJloyACTl34MYj3F UBa6Tc27gy7yLme8TitRSApCWM+vSVJtSqSJwOJGKZFgwO7RF6hwlkLDeqlOS8Q18kQg v3DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741570130; x=1742174930; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wS79SS1CQxxkd3qnon8nNpovVlwqoGNVt9KU+09W3OY=; b=p/1gAnt2f5rjsa6kZEuhOj4z28HEqmseDsKTM++qSCwnbAgicvvJhzYxt721I3z607 eFyw7Bt8W9Qi5NWwGyzD+Y2OQafLjNIKCiwUES5AHK0fosASmJnfcZeymUaEMYrJaBxm JRNrlOwRHKMA6KlhlsCNjDYbRnorn6t/8rhABwglx1xOtZNlLflU9E331BPbqw/AA3YJ UfZl9dalDlx6G1w/uUodoRIAIrTih/mjIsBK9K0KJl42uTk2a+YxDywW4drhMySLGTXR 5WXEp6eusS89lhwNgQX67vvJ/E3DZPsoS/va8ulrVIuiQBG6AdltvyoMMDOSxTKoKeeM JbQg== X-Gm-Message-State: AOJu0YxVQT5g0pF4QNt01CIMo5Vo5ekR9a4nzOSOxk4R1NQalVeLImTB gAAeQldd1Y26NlfdBluDE9yHXTZM4/1fyJgWaPazJ3bX3JPfugtBcJyzz+TkbZS6+l3vWtPGm3I P2KA= X-Gm-Gg: ASbGnctKnRkdZIAbC9N9CUKHhYJCheJhV745DfVz2SrAOmZu0YIhgce0Aton0qqF7Eo 2PD/HZvX4N86HcgYG9M94AjV4uKurejD4Nxi1piAWD6Vn9SbggLUFxmJHHy8NvswY2NHL38ZMUi paKZyF39efJZpOyZrEBxPEDLXTCsIDwpUQLKiZWKCBGLGwWVniryVStc2sw6QVjom23LRYQioZB VmeFoBThxB+JuD31gURLUAT9CWHOC1OiJhgspcCRIvnw8pMg6JqXD21rK/Y3e1gWUSZZCVfoI+q JddF9sB1scSM+N5VFpN0WX8RWI5tqz4yfFeQpU2MVvg8KHklmASx6H11zN3fLxhjRPEbsnmfMCt YPgPlj3soZYJpem9kAFs= X-Received: by 2002:a05:6000:18ae:b0:390:f394:6271 with SMTP id ffacd0b85a97d-39132da96b3mr8000092f8f.43.1741570130520; Sun, 09 Mar 2025 18:28:50 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfb79fbsm13570645f8f.13.2025.03.09.18.28.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 09 Mar 2025 18:28:49 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , =?utf-8?q?Marc-Andr=C3=A9_Lure?= =?utf-8?q?au?= , =?utf-8?q?Alex_Benn=C3=A9e?= , Mark Cave-Ayland , qemu-arm@nongnu.org, Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH v7 4/7] hw/char/pl011: Trace FIFO enablement Date: Mon, 10 Mar 2025 02:28:22 +0100 Message-ID: <20250310012825.79614-5-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250310012825.79614-1-philmd@linaro.org> References: <20250310012825.79614-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/char/pl011.c | 3 ++- hw/char/trace-events | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index 18ea03a52f4..34a5cb3af5d 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -480,8 +480,9 @@ static void pl011_write(void *opaque, hwaddr offset, pl011_trace_baudrate_change(s); break; case 11: /* UARTLCR_H */ - /* Reset the FIFO state on FIFO enable or disable */ if ((s->lcr ^ value) & LCR_FEN) { + /* Reset the FIFO state on FIFO enable or disable */ + trace_pl011_fifo_enable(value & LCR_FEN); pl011_reset_rx_fifo(s); pl011_reset_tx_fifo(s); } diff --git a/hw/char/trace-events b/hw/char/trace-events index 1bab98fb5f3..c857f4c4b38 100644 --- a/hw/char/trace-events +++ b/hw/char/trace-events @@ -63,6 +63,7 @@ pl011_read(uint32_t addr, uint32_t value, const char *regname) "addr 0x%03x valu pl011_read_fifo(unsigned rx_fifo_used, size_t rx_fifo_depth) "RX FIFO read, used %u/%zu" pl011_write(uint32_t addr, uint32_t value, const char *regname) "addr 0x%03x value 0x%08x reg %s" pl011_can_receive(uint32_t lcr, unsigned rx_fifo_used, size_t rx_fifo_depth, unsigned rx_fifo_available) "LCR 0x%02x, RX FIFO used %u/%zu, can_receive %u chars" +pl011_fifo_enable(bool enable) "enable:%u" pl011_fifo_rx_put(uint32_t c, unsigned read_count, size_t rx_fifo_depth) "RX FIFO push char [0x%02x] %d/%zu depth used" pl011_fifo_rx_full(void) "RX FIFO now full, RXFF set" pl011_fifo_tx_put(uint8_t byte) "TX FIFO push char [0x%02x]"