From patchwork Mon Mar 31 22:12:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 877332 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp1972824wrs; Mon, 31 Mar 2025 15:14:41 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWcRs0Vw2IKycYIq05BJM0GkmMj7vDJjXlbtIy+KHubVzgdYSXD5fO4luTC7njLPMsSNSrSjQ==@linaro.org X-Google-Smtp-Source: AGHT+IFzID2Oi7UxgrvrBwFdJDkUiXPOMZzz0ScAUU77D+F5uok08JU8HY5IEpCSQ5v2MXcCcO0S X-Received: by 2002:ac8:5a49:0:b0:476:671e:deac with SMTP id d75a77b69052e-477e4ae3fd5mr118662121cf.9.1743459281287; Mon, 31 Mar 2025 15:14:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743459281; cv=none; d=google.com; s=arc-20240605; b=F/VqG7cYnVmW1sZ/kKmRHXx4ky45CatCTOf5skZJVVUtGHnw5opuBSQH/PN7OTAWMY U0J/1lzK7YnDgPwEWA+3CcfPbKtGkMOPSQ+t0R7Vup51m2etDJ7tbX9k9BOnmxSuANdf 5M5r6GKBDyP/HQoYipU30w1ojqOE/5Smw5a4kLVYO23StAEQNQewd/jI0Hgjii58Fakc s2ntZ/9fu64PO1oTv/1Fl44CLeEw74cga72ePQ2IWJ83h+CB27JavbmpdjhRd5/E9EO5 4L3kMfxJG6QCswEXyXxfKffJk60lPy0noteVSZTiKLBICaV8/759+ccqwkKIbuyhpTrO YbPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=esZKfQmSZ/gsBmw6ndgWUyspYCTEzTvWG+1YHzWaO8Y=; fh=knHaNtCiWBKRvwFWsaOcTt4xVsHZ3wC27Cl3q2wDLF8=; b=Pt7mFE0EweFJ2JO6w9s4PpCqAbPuDntES6BwIS4WY+WK/DIdkifubym9Qu3MSxd9kM bDf7W8oIfoEkxDfvfbPfNPKR+tMQmPigTlbvOuh5b9LZBD5nk6eCkJtA22tDd40S+zA6 lFW+InbANJurOlRKxFjWDM3PWSv4mPbw80UTgCCZI1Yf9tbFh7YwI6ZoelzKR83UzdmY W1kJpZUo/0v3TASPsMULQy5TPShkjWnXQJaqhdY+WCqgvYmAINY6lW9rn0GqWsOCNwhc qlM0CXPRVPUTIk+683jj+h1NMPZu+oFkJhLG5GN/EIcgOed4CtLOzqoGNj4cM+IOSYO7 rtKA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EVoCxzsK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-477831883d0si71933811cf.507.2025.03.31.15.14.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 31 Mar 2025 15:14:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EVoCxzsK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tzNNV-0000eQ-BV; Mon, 31 Mar 2025 18:13:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tzNNT-0000dI-Hs for qemu-devel@nongnu.org; Mon, 31 Mar 2025 18:13:07 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tzNNR-00077b-TQ for qemu-devel@nongnu.org; Mon, 31 Mar 2025 18:13:07 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-43d0359b1fcso31880845e9.0 for ; Mon, 31 Mar 2025 15:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743459184; x=1744063984; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=esZKfQmSZ/gsBmw6ndgWUyspYCTEzTvWG+1YHzWaO8Y=; b=EVoCxzsK3NiAhYBDTsf4sRxx5mqWAoYgXIaLFCkq5/o5AXMCFBQAhCLcyKN5ayLqEj 33V/Xdta48kkYAdNVBMaWpcyCqZC3H9gYQIP4ZhzwEdfhYR/t/kcWfqtF2kWVlmjguYE wkxw0/hZcbdzCeK4C419hnvkO9kqTYoWOgVTwwfqw6OrqNN6CH9nylINX1h/rqbYpDxK oK4kyMB6DN9RN4FU/dXI9yp7KJrOGRpIy3vH6YZGFPRLtxEJH5oicjmOH9hvftVO+JAc b8GszzqbYWNHCDL2tL9TksfTG4kgGXSCX4OcClQMR/7+0ftUeuuiH+bFfmFbUod46bns M4lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743459184; x=1744063984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=esZKfQmSZ/gsBmw6ndgWUyspYCTEzTvWG+1YHzWaO8Y=; b=sjPR0zSIovoHlqib+BV5l248r6QvdzQr1sGrmbHeVxmg+Nxpf+mrnw6OkB+53pn2W9 iEicmhMB+7yfuqZreXSv2nPU7Q8kMKNLZgNx/Q86RvQ7WFl8YwMBd8Ds+EalbctOo2D7 vHVCmcRkowi/fdX0cWxs2bIg9mPLglWKl4uWrzTB3KXHT6jMFqZzVMb6IKzbDGamR5zd 6UXJvLFJI2Enx0utwAPDqOHrwy+Krm/8H/YYxm+w7S7TfF+LoXaitK1TjtkCcnzEGQBI AfPbjHzpBjiBGGUhHBj1hbPOMFol3mPEXhE9CR8gkXpjWqvpwGpWyC98pqpVnR/10L+N D4nQ== X-Gm-Message-State: AOJu0YyZF6NH32RO6TjxkOz7A0iAHvl+x0egZDj+ysAiHyOTmlstLoQ8 1Te6D3BlF2+m8S3FAFtzaLiFuGXTQI3Nk8M2iKaYwaftpx9qXl7qatWi4rE1aGIj057bRuSexOQ b X-Gm-Gg: ASbGncsGuxpvTuzVj//wtXd7N/3UBlBBNH4vQXXruwkBnam/QUfMiG4gDnIC8rLFZUX VcS79veggZzEiX6mRWpmm3UQBIFitgye0A8DuZFNCEELeicsynmKwdOFaV1ryhOxKFUv8jckw9h 8lOBS0ciEMayPXyUuXL60QJexejrK8XjNUA1kgMleotrQhCtcj5vMXXaBHcb7E//hPnl7b/GSpF AazW0A04hK7PqAzBxWxvJwntjSHW22Lm4LT1V3Kg4Ap4oSTsTJRUHPInn3KTq/n/8cy5pi6kjZn xXiUY3gMn1DZcwyCbzEMzF0AhXPw6e8DObjCqoz5SW36eWwvijMRoh1GcFOMR6p7Na/ZDeQLeJN vx+DslQuFBlunx05JtdI= X-Received: by 2002:a05:600c:1d9d:b0:43d:1bf6:15e1 with SMTP id 5b1f17b1804b1-43db61d894amr103198525e9.1.1743459183777; Mon, 31 Mar 2025 15:13:03 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d82e834a5sm181906515e9.13.2025.03.31.15.13.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 31 Mar 2025 15:13:03 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Udo Steinberg , qemu-arm@nongnu.org, "Michael S. Tsirkin" , Igor Mammedov , Shannon Zhao , Gustavo Romero , Ani Sinha , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PATCH-for-10.0 4/5] hw/arm/virt-acpi: Do not advertise disabled GIC ITS Date: Tue, 1 Apr 2025 00:12:38 +0200 Message-ID: <20250331221239.87150-5-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250331221239.87150-1-philmd@linaro.org> References: <20250331221239.87150-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org GIC ITS can be disabled at runtime using '-M its=off', which sets VirtMachineState::its = false. Check this field to avoid advertising the ITS in the MADT table. Reported-by: Udo Steinberg Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2886 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Gustavo Romero --- hw/arm/virt-acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index fdc08b40883..b26f0ac8585 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -212,7 +212,7 @@ static bool its_enabled(VirtMachineState *vms) { VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms); - return its_class_name() && !vmc->no_its; + return its_class_name() && !vmc->no_its && vms->its; } /*