From patchwork Thu Apr 24 00:49:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 883841 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp3202732wrs; Wed, 23 Apr 2025 18:06:37 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWjK79maYwraulUOQONMWgWAtp3uRPmgjWm6cShS3Aduf75t8FgutV9KI5FnmSbbHbO7QxdTg==@linaro.org X-Google-Smtp-Source: AGHT+IEXP9Z8Dpwks/vf/79b6ls+BHiL6C6gQEAAPw/w9KxIW5gSOglHELjtM+Q1IGjiMMQ/mH6z X-Received: by 2002:a05:6214:c48:b0:6ed:1da2:afac with SMTP id 6a1803df08f44-6f4bfc6daf1mr17605356d6.32.1745456797504; Wed, 23 Apr 2025 18:06:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745456797; cv=none; d=google.com; s=arc-20240605; b=UcZ+mPWnkBfo+WaM5jH9W9iMiMmKmmxbx7IkIr6L2ocQRInRrtiRB/9G527LHRLW6S tS0qfVqjt9kYjYUCVHdVM1ocfd54X8yfobssJ8X2HtzDqd91xyuZIltv0WgkyHCrSpyV hEi3MPcYmZOvpoV3JNdBP/AEvkmQrQAeT6cw/5h0NOdk0nV3N4C0MH59jmioLJogW/mA MjwlTq9JH0DGtFUFXw2MOeW26PbEYGuz+JGvA/9mXLsT3AvLl/ZtJPoSVYbKWfobYGZU tQ93bOPSX1Ja6meulF2vsjU0wF6VW+nGJ4q5zjtgww5X47ZGIZi/EDxds90kAhQ+R6SO HH+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tGFd37j+l93zOqMm5a5N6sYRNEZpuNLxVMZbuAwdikI=; fh=vm85eyWrvOAHduw3sqEA+cYBqvHB7M0MHFcRJg7VWOo=; b=EYsWCfgOoevC+s+AEoVM2VUNmfW+aA1QaT8JNZPdCAop7O02dS2bx/Pp0wp5OzUTIu sYkOA8Ty8EEAQ0gZ1OWMdeHZawR7T2+QC9rlp79/bvTh9e5GlJMnl8mauz7iYqJN9QeW esPeWWL/7z+gJzFYP1otUJUBAj61CBD74VfQmSvLKr/X1z/qKDpqLv3zVnjt7O2cKZ6P 5MrXuyVkP/0e6O0+7/xnqyBh06hf0FWwP0kwCDu2UbcV5pISKANPHPwuxdSeBNOnGi2i jdcO88GPjN9ppvgNabUmcMXl2WCLRNnE6DiM7PkM/LDSf3RmVs1q0ORySt36SUIlMEvf u61w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PcKtJh0v; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6f4c0acc9f2si3619596d6.185.2025.04.23.18.06.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Apr 2025 18:06:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PcKtJh0v; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u7l0R-00030Q-NM; Wed, 23 Apr 2025 21:03:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7kwy-0005TU-Kv for qemu-devel@nongnu.org; Wed, 23 Apr 2025 21:00:25 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u7kww-0005Xp-0v for qemu-devel@nongnu.org; Wed, 23 Apr 2025 21:00:24 -0400 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-b074d908e56so263356a12.2 for ; Wed, 23 Apr 2025 18:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745456420; x=1746061220; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tGFd37j+l93zOqMm5a5N6sYRNEZpuNLxVMZbuAwdikI=; b=PcKtJh0v6w2/7s1PehhXD46HTHmxjVXUuevsQqjrGZlAZIY6IF0ZT/SCsv48kNFd/k socX4MyM2xQuuTTQHyeZZzsGtnAnjLZ8GJNCysOrTV1IQ6Sk05NhRqjmh3ArbzI04CIQ jVeQ+G7dxsyJH/vyi/vprVSHZT1E7BuBIMz9btlGUXGDU4S3MAumpFpsCynK4L/nGM5Y Cd5ZycJ+3oDIYSVf6KpoRiEsG5iAuGAV6E18apFEVU04aPCtNE8znQUcpQQpyk+nGjL+ eiWooGpp7MfMJcR6xqvvRwwuRhv5eaSs9N9aSsqhVbLEUUGHWYQDvhZ3TaFii2KnHFR5 vVNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745456420; x=1746061220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tGFd37j+l93zOqMm5a5N6sYRNEZpuNLxVMZbuAwdikI=; b=Pc8dI1wPn86SILYFGZ2zvucytTKGyUQPOH4jTnVWFC+L90fe5uBk1buHi9guArMTSe ObJRqMydoTGrStluA6f6IkvoR9OWgigMI6H729kzxiLJh9ttjvLV6+1+uCgO7r2/LFeA zjTm6N2NRlEDT4TouxhSIAOjRmQj5ambyTxwJxblrVNtEy3/YEOz81D7NhFEEDWa0amD H1uF7i9o+FxdKSiJGdm1JwcQBnFkMxOSc+kbnjjHSMwW9uqkrfVQS+HlWnO+W7u68tGM 51zDhHCVwdW36ChWoruRLdZsp2fQ6nqkKQ7h1iIAcDiWA60GcFvgje4mjgYUVbgllitb xQzg== X-Gm-Message-State: AOJu0Yy1r4U0afM2/zswNCXclXUzuzCClREDIS0h6EsmSX+9cjKn+vvy K2UUPzlyrcJfk74V39EWsCMhoO1RTbNU8aKr4u1C64TlhCHC1exrwzx9ipTlWL/LFJjcGedBMpf h X-Gm-Gg: ASbGnctUvaWYo+hKXdEuyQpHiNAO+B3ahAui+NdCDWIsHJYkIenoycZ6hMOtW7sjkOA 3Av1eizxt6c847FYocySdMWOdwJyhpT/Xy/+Gw/iL8o8MInVf2QdrotSQIFJDH0e6BSx+2IahKC O/hMZmfC0mIipVMRZ1rDiyNDloAEFonLVyhD7fm3XWP14SHPzKbym6LpDSktU4f9tcstHPnd5El a+Mw6vaIwfp3NQAHx2fdhRucixfysHWTWJl7vs974m8qVzjhumI5sT07E0kRGyazrU/vC9BXMc6 1D3bFXbl60NWKFx6waUXlxZzPz6h/JYUW18iq1fL7TWGmJugW6BukzCjuphcO7Temk3PeuVliN8 = X-Received: by 2002:a05:6a21:3386:b0:1f5:92ac:d6a1 with SMTP id adf61e73a8af0-20444e81bf1mr805281637.4.1745456420448; Wed, 23 Apr 2025 18:00:20 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b15f76f45c7sm129259a12.16.2025.04.23.18.00.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 18:00:20 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 143/148] accel/tcg: Remove mttcg_enabled Date: Wed, 23 Apr 2025 17:49:28 -0700 Message-ID: <20250424004934.598783-144-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250424004934.598783-1-richard.henderson@linaro.org> References: <20250424004934.598783-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org In qemu_tcg_mttcg_enabled, read the value from TCGState and eliminate the separate global variable. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- accel/tcg/tcg-all.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index bb759cec07..b754f92905 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -60,14 +60,11 @@ DECLARE_INSTANCE_CHECKER(TCGState, TCG_STATE, TYPE_TCG_ACCEL) #ifndef CONFIG_USER_ONLY - -static bool mttcg_enabled; - bool qemu_tcg_mttcg_enabled(void) { - return mttcg_enabled; + TCGState *s = TCG_STATE(current_accel()); + return s->mttcg_enabled; } - #endif /* !CONFIG_USER_ONLY */ /* @@ -124,7 +121,6 @@ static int tcg_init_machine(MachineState *ms) #ifndef CONFIG_USER_ONLY if (s->mttcg_enabled) { max_threads = ms->smp.max_cpus; - mttcg_enabled = true; } #endif tcg_init(s->tb_size * MiB, s->splitwx_enabled, max_threads);