From patchwork Thu Apr 24 00:47:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 883779 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp3198759wrs; Wed, 23 Apr 2025 17:54:33 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVbQWxW9S1QRA3jxjJVMVzpMrIl3X0Qesnu3deok9HAypW55I2q7k7WeiWpkmNwlxfzbdpEDA==@linaro.org X-Google-Smtp-Source: AGHT+IHLkRF/lgmHMN8+ia0pIe+Mlb66uKdFw5vZj3V2oUQ6Jo6yYwW4hZgplAgSVJyofpneIgWT X-Received: by 2002:ac8:7f13:0:b0:476:9e28:ce47 with SMTP id d75a77b69052e-47eb4ba2e4cmr8646551cf.45.1745456072926; Wed, 23 Apr 2025 17:54:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745456072; cv=none; d=google.com; s=arc-20240605; b=ecoFqmodmQ6+8NwUKy6DXmGwjhGMbtz9GCuurhMQTwvkHgZmo32iThPx6xaZRz/kOF Dx9IBBTIiLX/2enme2hRIc1tldhEHrez4HEZfscmrOTqAGnyJ62CQFR3fyVgR/Obn+7Q oN6iZT3tnc+7aimquCHD1g3ZbPl5WYD17wQyiwKoH/WKbFQ0tqPy/OQLWzZSEU7onGVh ODLS3KFhnfWknx8QFPARBtZ2B5p3vZ7SP+p1Fz/olmjS45uy8sZ5HUA5+WLSh1CBro9h TRq/62lf2GCgQ44G9uwwFDFtFnZzq8nD+8nrjQHPWmRyXdh4mKPzPBOEKpiK09v8b/4D Xdbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=I6MDZmD8wHi337leE/VPRqxkP9hRcv8+ycuZ+hH6Uq0=; fh=6Iy23zC9AdgEjl8BT287tms7OsCTNhvcMTX6iUEgWw0=; b=U/PFmG2T2y/IU5Vob72V155h/qYRuHe7+PshrrRoaKUD06ByuQcsFNOBqOrLtnxmOP U0aUMKvFwPT+8MxgRATXtQKDd/0AHYJszdtnhZf/IhFvO8F4oOanXDm/C1a1KN/z9BWN HNm7NAyX4d5f8n6jGyKX6EeVvtE4tu4LiiB+mDuy6Hi3c5fxwqedHMKnntuJDP3zhB4K LZyU3deNEP+4o5g3V8blQpjX9ZtHzf8Rg6mvqoblZKKyX6oivbfVs8aBXsLkhdypGRgl hkfqmN2SHG2UWh4N1oI515SNWyM36PaSbtC1yIaJ+GYKx3NtGR8hCgPShj0oLdSHRpXo 2gDQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xe6AiNwi; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-47ea1f96d34si4975991cf.417.2025.04.23.17.54.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Apr 2025 17:54:32 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xe6AiNwi; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u7kmn-0005Ew-Gh; Wed, 23 Apr 2025 20:49:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7kml-0005DE-53 for qemu-devel@nongnu.org; Wed, 23 Apr 2025 20:49:51 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u7kmj-0004Kt-Bq for qemu-devel@nongnu.org; Wed, 23 Apr 2025 20:49:50 -0400 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-7376dd56eccso400051b3a.0 for ; Wed, 23 Apr 2025 17:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745455788; x=1746060588; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I6MDZmD8wHi337leE/VPRqxkP9hRcv8+ycuZ+hH6Uq0=; b=Xe6AiNwiVFEa0lISPAkk3kgYY8Rngyg112PD+5CIbPgDoz2LrlF8wiR7C04t5jQP7I 7Uv4dmZYmKDaGXJPdWwkVXbv/OJ4ba5LHarrj1BYbBbwIn7KqBn5XoVf45jommmi94tl GE9d9oVxVSdHMc2zj1SE+fjGAdTnmmytlHCGP4mLL0lHJHuOPTY23CZH7tb2zMQRd6rq 9T+KB/d2lk5ZPIymRSJV9RucUUwygiuZSWXQL4+t4I3n+o1JfLaAWFYViOGQpCvi4H6/ /bN3N1f1QyNBkCZrozXag3Y+6fG1xcp+CvLlLpQoHm9kiUSIChPnC4bcqTVRdEyE6Ner fcIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745455788; x=1746060588; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I6MDZmD8wHi337leE/VPRqxkP9hRcv8+ycuZ+hH6Uq0=; b=mPGxrV1Y/FgECP5S/4Xi5AxLu4SPDdrx72n0sOKxfufuSqpf824Ntj9g+8fvjVm1p9 9t0AMvQtxYAdEqzD36c2ltE8GY+ijJOcTt6lfvuIdhFUhBbQkV00MCw+gcmEjwkqWAHN 5UKIjK1w13vJUZK+2OmyyWDq3+tPr9EKuQX6y+PI7iUMblhcWtGrtC/tNJX9x9rxKnP8 jJ0LZ0kwbUCypYC/676VBc30YZXC7QbXvqkpvVqIwQcQ/0rG0k3lw8+B7H+l5jlXVB7O muqAkHTvtcilBPjQvW7UbwlUJfbiV11tpQaB1VS67gR1ZlfVy1S5ccsQXwAidD29VhuR 8JDA== X-Gm-Message-State: AOJu0YyY24+ef5dEptzNrqbOZrekcOYZ22X+CAbaULxgPwuJue9tRWlz RvFwUssC8yIjBkXBLLRNenrcKa4r1mv+U5yg/lAaFILhyz/qDwGIAi+5Jo9I6Xb+zcCAflWiPUc R X-Gm-Gg: ASbGncuoj9tlY4kQyck08aK3CH4UU+xMYEzaWaHvstc7NT+hBDseCfC60pmZCmk6T5y lDDFRAZsH6QwaY+zeHWv+eiGK3bJb0DgLjIkAJUJfETySEo4i4GuavETysIdh0fn0Qru70mjyti yjo5gg0y+bjTBkg5zya9yoiCxna08sUN78spFRji1Wg0ifebEedKoJsFY83bOwQKIl7qMTypq08 mRj0dTLeMDGF6IYjtOiCSte6Mad2SkemMFY1krhISn/RkqNZ8SAO6xmjNvuEEy211Ms2/f/sEdr 0forO/dJDIdhQ8BeetGP12R9PkuAW/Ad3FQZZk3MzGTaaOIHxkRlj1L9FX2Kv/CnvA8JoDuPmVk = X-Received: by 2002:a05:6a00:1383:b0:730:95a6:3761 with SMTP id d2e1a72fcca58-73e245db378mr1160762b3a.3.1745455787971; Wed, 23 Apr 2025 17:49:47 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a9a0f1sm207344b3a.137.2025.04.23.17.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 17:49:47 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , =?utf-8?q?Philippe_Mathi?= =?utf-8?q?eu-Daud=C3=A9?= Subject: [PULL 016/148] include/exec/memory: move devend functions to memory-internal.h Date: Wed, 23 Apr 2025 17:47:21 -0700 Message-ID: <20250424004934.598783-17-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250424004934.598783-1-richard.henderson@linaro.org> References: <20250424004934.598783-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier Only system/physmem.c and system/memory.c use those functions, so we can move then to internal header. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-ID: <20250317183417.285700-17-pierrick.bouvier@linaro.org> --- include/exec/memory-internal.h | 19 +++++++++++++++++++ include/exec/memory.h | 18 ------------------ 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index b729f3b25a..c75178a3d6 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -43,5 +43,24 @@ void address_space_dispatch_free(AddressSpaceDispatch *d); void mtree_print_dispatch(struct AddressSpaceDispatch *d, MemoryRegion *root); + +/* returns true if end is big endian. */ +static inline bool devend_big_endian(enum device_endian end) +{ + QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && + DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); + + if (end == DEVICE_NATIVE_ENDIAN) { + return target_words_bigendian(); + } + return end == DEVICE_BIG_ENDIAN; +} + +/* enum device_endian to MemOp. */ +static inline MemOp devend_memop(enum device_endian end) +{ + return devend_big_endian(end) ? MO_BE : MO_LE; +} + #endif #endif diff --git a/include/exec/memory.h b/include/exec/memory.h index fc07f69916..2f84a7cfed 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -3138,24 +3138,6 @@ address_space_write_cached(MemoryRegionCache *cache, hwaddr addr, MemTxResult address_space_set(AddressSpace *as, hwaddr addr, uint8_t c, hwaddr len, MemTxAttrs attrs); -/* returns true if end is big endian. */ -static inline bool devend_big_endian(enum device_endian end) -{ - QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && - DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); - - if (end == DEVICE_NATIVE_ENDIAN) { - return target_words_bigendian(); - } - return end == DEVICE_BIG_ENDIAN; -} - -/* enum device_endian to MemOp. */ -static inline MemOp devend_memop(enum device_endian end) -{ - return devend_big_endian(end) ? MO_BE : MO_LE; -} - /* * Inhibit technologies that require discarding of pages in RAM blocks, e.g., * to manage the actual amount of memory consumed by the VM (then, the memory