From patchwork Fri Apr 25 21:54:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 884520 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp4183896wrs; Fri, 25 Apr 2025 15:15:43 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUrSqwAb8m8PZwVd8eJhVxhsNGRI34Z026KpFtVE16yNggR/jNB07nTTUbWyEScPSGWj5PcOg==@linaro.org X-Google-Smtp-Source: AGHT+IHOMpnpoRsh1f74u6Qj5DVsy85aWpvgtRW7viu1/uejNqNYdSkzJYYjvaMtqnSgkwf8tmbJ X-Received: by 2002:a05:622a:1aa6:b0:476:639e:ede0 with SMTP id d75a77b69052e-4801ce5411cmr52536801cf.26.1745619343423; Fri, 25 Apr 2025 15:15:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745619343; cv=none; d=google.com; s=arc-20240605; b=alok6nHe/WNcawhv4i7FWtESa6LYRDFwVBh2v32PGW9+gUjvOZ7O+3U4uhtttuGpWV 2BYSSekarmJvQ52MhjkQyZhS0uaEYufb+01enCIChW3rsSUoJFd/O2ndCl2KfIVtW0nD 7rnR4aLhaBU25r2eEZrDvYagxU4SY2ML52J+BCO+mMnBlFob0pmKy3YtfF68/or6gc6S cPF8G4ppMsI3PdnvQiLUY1SS4ixpYSTgx3jqWvZmwz2YTW0goojMcn72yLaIpFJOy79r gIOS7Wt012ady/AkfKs9alQXyfgJ1kzBTD3SzUxkdT+9pK6NVmDYvoD+OlhMelNuEtNb VEGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=X4qDfrPFg1A+HsqWBVQovPa9Xet+i9wtHFpQlqn9CU8=; fh=vm85eyWrvOAHduw3sqEA+cYBqvHB7M0MHFcRJg7VWOo=; b=PTyOxfD1E1QIHwWeqR2dTHjX3+vXx9FaRYZ2leWwUadgqvOhF3GZhD9S1HUgd2C8SE 16/43lyWCzJFrKzvSAXmAhS2C/dbaFNk8CHrZLYVE3jtJm37e4xqhk8nsT6Iip++j2nU tyh+pfwQLnr/d9Uk7Rj7KZ1RX3SNK8LzXRYZ6FPsRC5ZewHJSGh4HVHEfK2/a8hzEOF1 SbYaeHnqOrWb6j6+F3cMrBO1e84kpY5q2dm+Rxl7Q0KbgrGMj5EwcfnOGKe5P6RPplyr Son30UHNIdVhkOLUBOr12Wi83R/B3ZkJlVjdSCyiVl1ZUw8TcxVL1n0UcYlRgwFD4kfB /Fbg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=djdHXjSy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-47e9f8ac791si49019131cf.136.2025.04.25.15.15.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Apr 2025 15:15:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=djdHXjSy; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8RBg-0006JI-LR; Fri, 25 Apr 2025 18:06:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8R7o-0005ek-9x for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:02:24 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u8R7k-0001OK-N4 for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:02:23 -0400 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-22409077c06so44325505ad.1 for ; Fri, 25 Apr 2025 15:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745618539; x=1746223339; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X4qDfrPFg1A+HsqWBVQovPa9Xet+i9wtHFpQlqn9CU8=; b=djdHXjSyg4M4RRbSjeUUKAT56XaGNa+pBMsisweOKOlJoEO88ocVTjfmh9mpCh4nt5 gmwjWBbLK1y6Br2943wf0mw6UxahA3sIjNFlViKapiKC7OdNaH/3FIDXmtc0jdjhpky3 3d7bjjDb3O4Abzypp2HnJMQJ9lItRrfq+xgREwJ58w+rLPhTA3CwHKpG8xERUugnbfJA ensnhGkQviHaYNkhKNN1IyN+zLoWgAoz54VD27EAyvh2JQun8vEjsFoeDtyT3pXOjtDB rG8c3IZL4x6PCL3NRVvVtHhvL7cwq902SyGYGyrKHouGNb3P6YCod3B0AMF5EC/jZBPC ICvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745618539; x=1746223339; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X4qDfrPFg1A+HsqWBVQovPa9Xet+i9wtHFpQlqn9CU8=; b=oMj4UWy6LyY82uR45HmryLLzxOmpxxuMXsrizggk4/0Kut4HuJJwX8ZzQ7IskBCN5p kvt5uM1QtnIQfqa1C2kr5A9VKxavx+NV9yoTjDh8MVUXJcFf+xD4KIh1VVA8ZYZAXnoX 1ErlAbxKh061B++Z4FrJr+REReNzlekhE0FhgzsAwZyggYd90GiQZ/DSCqpOf6ttSFBo CN6lrFajB/zifyNgCpW81L/TZGb3zJKOYRKTzKifrIyaTn56qnQBH0Q6dMD8KTngUjYW /FV+fRPoWtWn+RDb6O46PtuCY8OEAAZ0GbhsXSBM3ePp6Xekrww9zt9OsVowZQj4RrsM v/Wg== X-Gm-Message-State: AOJu0YxrDtYvkySFzDoyxHN4XPTojsoNGZKKF3MA8ACziQaJo4HD272M etlqs/po4RGx0WLEGEZbRKha2uUFm5X+IfPdPiOjPGTqggPF7aecB6WxAUo2O+lXxw6W8Qbv7PV A X-Gm-Gg: ASbGncshEJ4XtZqsLhHfKdq9xFiIjx7mxAk31W80k1MwU2PUydJ/UOsmqFZmLeJ5x04 ilx60rPO/jmvACCDfIJGbeoJZDZwN1wmDR2YmlFWluKr/VkeZoVySu5wM07aAFuEMXdi/QgT+g4 bpzbDri3hamHcWCBM84M8uPusN1i1RA6AqaUKacRs+y0P0Za2QKjUPMiXzI/LMj+XTrE93s3AeL NSWzZ1etwAUVzPI06bKUXWsVNsEOzzkhkIRfwwOLzggj+86qVqpQ/ilprNVtBkPXliaBwPQda+f PQtFA3g6QnnjkihYH4BddeImpLZ0PiWmulYDKQ5w7z/72V9A3VS+NNXbg82W054SKmzzEo7r2hr HuyipWsmF4A== X-Received: by 2002:a17:902:d4ca:b0:220:f87d:9d5b with SMTP id d9443c01a7336-22dbf5faf1emr65418675ad.24.1745618538912; Fri, 25 Apr 2025 15:02:18 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309f7765c88sm2212961a91.28.2025.04.25.15.02.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 15:02:18 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 111/159] tcg: Expand fallback sub2 with 32-bit operations Date: Fri, 25 Apr 2025 14:54:05 -0700 Message-ID: <20250425215454.886111-112-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250425215454.886111-1-richard.henderson@linaro.org> References: <20250425215454.886111-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org No need to expand to i64 to perform the subtract. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 8b1356c526..127338b994 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -1123,14 +1123,15 @@ void tcg_gen_sub2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 al, if (TCG_TARGET_HAS_sub2_i32) { tcg_gen_op6_i32(INDEX_op_sub2_i32, rl, rh, al, ah, bl, bh); } else { - TCGv_i64 t0 = tcg_temp_ebb_new_i64(); - TCGv_i64 t1 = tcg_temp_ebb_new_i64(); - tcg_gen_concat_i32_i64(t0, al, ah); - tcg_gen_concat_i32_i64(t1, bl, bh); - tcg_gen_sub_i64(t0, t0, t1); - tcg_gen_extr_i64_i32(rl, rh, t0); - tcg_temp_free_i64(t0); - tcg_temp_free_i64(t1); + TCGv_i32 t0 = tcg_temp_ebb_new_i32(); + TCGv_i32 t1 = tcg_temp_ebb_new_i32(); + tcg_gen_sub_i32(t0, al, bl); + tcg_gen_setcond_i32(TCG_COND_LTU, t1, al, bl); + tcg_gen_sub_i32(rh, ah, bh); + tcg_gen_sub_i32(rh, rh, t1); + tcg_gen_mov_i32(rl, t0); + tcg_temp_free_i32(t0); + tcg_temp_free_i32(t1); } }