From patchwork Fri Apr 25 21:54:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 884524 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp4184231wrs; Fri, 25 Apr 2025 15:16:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXffmrzAc2caW+jwOtvFAlC0EBxk9Hko7S2a7sKX9x7wXM5+3DHbyxo3O74+E6K1fdf1lKScA==@linaro.org X-Google-Smtp-Source: AGHT+IFBD26BBrxFaTdgHSrsah9sTfzdiZCZVkSFZjCPajCCxJSllBROQ+Cptxz2K8JSXJc4/V3z X-Received: by 2002:a05:6214:768:b0:6e5:bc9:95f8 with SMTP id 6a1803df08f44-6f4d1eff3b7mr18562716d6.17.1745619397982; Fri, 25 Apr 2025 15:16:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745619397; cv=none; d=google.com; s=arc-20240605; b=HLRj5gYHH73+2DaPaXpf4mDAdO28WrqO4vHIJWnOXHqDmTlE3nyThqVpoJYCPJvFmw K0yAEvNHTaX7K6PhUNepEdj8/PzsWVH3f0Pc2a6Khx43J61P8PL3gaebh7XtYOuxC8Gp 9IVkJ/e/UPe/ZmWUmOkECJdueiKPTqhK3CoKM8jFegxbPrqIVzOX2ppVoEss0C+OrsI8 dPWnBs7m9+3hmp6RpJT6glt3YcA70W+3IucSCzMV127x4y/iG5pYPnUEq76998RPZgnA lCPFDoKiIC6fr2xAzVOdyZ+QbGhIr/IrsgF4dX+882XmqZmnAhlkAPGjsgJi4Zc4W2Ez hJow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wEXtO5aiOt/moVB28wigZg1GFsfWpZnoi3y9eQr8QbI=; fh=vm85eyWrvOAHduw3sqEA+cYBqvHB7M0MHFcRJg7VWOo=; b=hZUSJIHjINvU/f8iAdNDFirWuES6FNAP4djUGUZs/3Gu56Z+hizWmUPKw7EGgZrYo1 6A5RraAUJPE/9HvJVF/Ik+2edvJFFImQZM4kC3RCcT0ZMwkYo9b2yAfFl1nA98PWoT/a 1LSEoXxXQrR1AezRjWpArV3IVlDLrLu+kSJBoTnEXSrDI6PnhVkqDCfFFCUHTNSxGu9Y 5hioXCVMkmALR7BgjJQtyIBkJNbbzZi8hz+HrOh4nV967jLwgh45jR3EMcsxklsZ1DEE pk9gPec0hoX3DE0t0gPRe62bLWid8Jy43I69ACpfMCTHeud6gieyUKDANfNvnB5kj17V bqZg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mholbeyr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6f4c092b006si50367466d6.150.2025.04.25.15.16.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Apr 2025 15:16:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Mholbeyr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8RAS-0002sp-Tg; Fri, 25 Apr 2025 18:05:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8R7o-0005eo-9T for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:02:24 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u8R7l-0001Oc-L7 for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:02:23 -0400 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-301c4850194so2291790a91.2 for ; Fri, 25 Apr 2025 15:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745618539; x=1746223339; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wEXtO5aiOt/moVB28wigZg1GFsfWpZnoi3y9eQr8QbI=; b=MholbeyrjBbIFqD/gLXSZ/By+N+wkuhTeazuMn5H9bGAEh7gGYkzOhVS8uyyDv6SYI xFT5C7EA/NBVcPfRiUaHQWS/T80VT33sn3p3C/kPITQM63Tv6kUxrBsB8BZInf3UYCQR WJQZ+SA1lr444C9W7UQa2YLwNw7j3j+YlKKcz4FpNOwKR2mQplzuIBKOXZGCLMxG2X/m i1SYQGE0bTDFLz1KE7EmLsIDIU3ifXQkJ8Jd7YapWX8BLQg7TkDhaDoRLAaIqGwS/uVl F6g//rCM2PB4T1HTTDoWTuAFsxyc6OD9AWHnBax4bUEKxcvt3+OKHbfIM0ebiOLXjLEf LzzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745618539; x=1746223339; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wEXtO5aiOt/moVB28wigZg1GFsfWpZnoi3y9eQr8QbI=; b=l45ZyHGQf2c5wgQK7jFOz2HIfhCEgV3sEOQ3GTuZCE3CKNIaF5fc/yIuvIcHGJHwZO ypVPK7cK7weCsiACYo/HlPh6JhYDMtAsmQlCeF/PGZKrXSNlSSVIfV4ggayM7P8pbMV6 6+DutNmLpOGuZG4dAxAesqzVqYHBwjPKQWdXlAdfogaNrdB7ippVc4UClR2HCAuhS7uh fySNAvd22nVjzHVfxoX4RJM+d9R1eoh05wyMVZDTtSNATAb16JcgEAzyIKZSnQH13K29 kOx6hE7PY0nvm6kQfwMiUhVzbSD7VOJLf1rwOJ1tyB70VTgse1IfGOFUTqoWbRJCxJkE OMjw== X-Gm-Message-State: AOJu0YynXMKCi/WKEkIgkJAtvKOBPOTP96o0iIBglEPOMfLHC+pzKsTu yD3jZL+HRJwESjSnFZKkawHu57EGEbtPmiGQ8rgSPOqOi1qoQXD1ChGWIcDsoCOSS45SGXe7vy5 z X-Gm-Gg: ASbGncu8KA2SlTDtokdIgRylL0Q5WagQDLJRvNR5EJZfhTWbIftOgrGVbieVhSKyfk6 LlEbQIZNbQTcdUA+mlGC6LWXHMglJX2S42Q+mesBjrZxehnFL1jZahDv7Gnot71T2gjv3xgIIj2 C2OrZKNlnEtNsO/8W27iHfXj6oqSi3XmHZ5nec66NyMEtdME0pa4cCA2SUcbwK4ZdU03skC/Pyx W+gO8nG/tTkP8aHk7iL9JnAoblf5F1FlEFXLOljGbkGo3oAB9fXvAf/ORjroZkuY0tjSUsUTYUg lEHtZIdXM6CJNTy8fv0xGZLjpn/tuEnBEJWxIXSxoTAJ6H+L75Uppzeti8tAHh8lInN4poY9Klo = X-Received: by 2002:a17:90b:586e:b0:2ee:e518:c1cb with SMTP id 98e67ed59e1d1-30a012ecbd8mr1693925a91.7.1745618539576; Fri, 25 Apr 2025 15:02:19 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309f7765c88sm2212961a91.28.2025.04.25.15.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 15:02:19 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 112/159] tcg: Do not default add2/sub2_i32 for 32-bit hosts Date: Fri, 25 Apr 2025 14:54:06 -0700 Message-ID: <20250425215454.886111-113-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250425215454.886111-1-richard.henderson@linaro.org> References: <20250425215454.886111-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Require TCG_TARGET_HAS_{add2,sub2}_i32 be defined, one way or another. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- tcg/arm/tcg-target-has.h | 2 ++ tcg/mips/tcg-target-has.h | 3 +++ tcg/ppc/tcg-target-has.h | 3 +++ tcg/tcg-has.h | 3 --- tcg/tci/tcg-target-has.h | 4 ++-- 5 files changed, 10 insertions(+), 5 deletions(-) diff --git a/tcg/arm/tcg-target-has.h b/tcg/arm/tcg-target-has.h index 0d6a785542..3973df1f12 100644 --- a/tcg/arm/tcg-target-has.h +++ b/tcg/arm/tcg-target-has.h @@ -24,6 +24,8 @@ extern bool use_neon_instructions; #endif /* optional instructions */ +#define TCG_TARGET_HAS_add2_i32 1 +#define TCG_TARGET_HAS_sub2_i32 1 #define TCG_TARGET_HAS_qemu_st8_i32 0 #define TCG_TARGET_HAS_qemu_ldst_i128 0 diff --git a/tcg/mips/tcg-target-has.h b/tcg/mips/tcg-target-has.h index 48a1e68fbe..9f6fa194b9 100644 --- a/tcg/mips/tcg-target-has.h +++ b/tcg/mips/tcg-target-has.h @@ -48,6 +48,9 @@ extern bool use_mips32r2_instructions; #define TCG_TARGET_HAS_sub2_i64 0 #define TCG_TARGET_HAS_ext32s_i64 1 #define TCG_TARGET_HAS_ext32u_i64 1 +#else +#define TCG_TARGET_HAS_add2_i32 1 +#define TCG_TARGET_HAS_sub2_i32 1 #endif /* optional instructions detected at runtime */ diff --git a/tcg/ppc/tcg-target-has.h b/tcg/ppc/tcg-target-has.h index 033d58e095..8d832ce99c 100644 --- a/tcg/ppc/tcg-target-has.h +++ b/tcg/ppc/tcg-target-has.h @@ -25,6 +25,9 @@ #define TCG_TARGET_HAS_extr_i64_i32 0 #define TCG_TARGET_HAS_add2_i64 1 #define TCG_TARGET_HAS_sub2_i64 1 +#else +#define TCG_TARGET_HAS_add2_i32 1 +#define TCG_TARGET_HAS_sub2_i32 1 #endif #define TCG_TARGET_HAS_qemu_ldst_i128 \ diff --git a/tcg/tcg-has.h b/tcg/tcg-has.h index 6125ac677c..50e8d0cda4 100644 --- a/tcg/tcg-has.h +++ b/tcg/tcg-has.h @@ -14,9 +14,6 @@ #define TCG_TARGET_HAS_extr_i64_i32 0 #define TCG_TARGET_HAS_add2_i64 0 #define TCG_TARGET_HAS_sub2_i64 0 -/* Turn some undef macros into true macros. */ -#define TCG_TARGET_HAS_add2_i32 1 -#define TCG_TARGET_HAS_sub2_i32 1 #endif #if !defined(TCG_TARGET_HAS_v64) \ diff --git a/tcg/tci/tcg-target-has.h b/tcg/tci/tcg-target-has.h index 4cb2b529ae..6063f32f7b 100644 --- a/tcg/tci/tcg-target-has.h +++ b/tcg/tci/tcg-target-has.h @@ -8,11 +8,11 @@ #define TCG_TARGET_HAS_H #define TCG_TARGET_HAS_qemu_st8_i32 0 +#define TCG_TARGET_HAS_add2_i32 1 +#define TCG_TARGET_HAS_sub2_i32 1 #if TCG_TARGET_REG_BITS == 64 #define TCG_TARGET_HAS_extr_i64_i32 0 -#define TCG_TARGET_HAS_add2_i32 1 -#define TCG_TARGET_HAS_sub2_i32 1 #define TCG_TARGET_HAS_add2_i64 1 #define TCG_TARGET_HAS_sub2_i64 1 #endif /* TCG_TARGET_REG_BITS == 64 */