From patchwork Fri Apr 25 21:54:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 884642 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp4186959wrs; Fri, 25 Apr 2025 15:26:14 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXFbK+dcMUF4YFiixa0auyftAmqVz9z4uvV6vmZlc/ibXuUzyLKvNbOoALEFpfKDzhbdIq3HQ==@linaro.org X-Google-Smtp-Source: AGHT+IFLZNGQ67kwJbzJHXGCK2m2PxN4QCoCBRElXcRNSm8RoOv2cPFpCE6fkSyQI2qw10fuSCcK X-Received: by 2002:a05:622a:c8:b0:471:b8dd:6411 with SMTP id d75a77b69052e-4801ebd265fmr66289151cf.47.1745619974359; Fri, 25 Apr 2025 15:26:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745619974; cv=none; d=google.com; s=arc-20240605; b=lZORWWvq1s1wyYlgNZyUTOW7VCDKz/DUMgKg+HOifIcnVUwGx6sV5LusO9co7scbTq LHiLUN+ji8DpH7qLqIT36ypGwFu9AxIYEIFwMsMQmYuMLI+nLSnljgaNC26rxG/W+JyP ZjdeJXz3iKh1ITXsaqIbzf5S+dNlmsDE1yXGb+1c/CTvg0asMVRYlkr8fWEzBFBkmi1C N4lFsy1JyNyhbPGBExuQOynjNS63jxjruHVP/tfFwQMM3KlbrZbK4WduYIAMfZ/1PT64 COexzUiGXomnlwNCPtTJq0xrpvP6DYrU1QY86w8xwAhfXpO8KjLEom682cDmS+0lkevp 6ydg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bOWCeKNlLhAgVYEVI4tqJhLjqQCbsv0AzZbbO08r8rw=; fh=vm85eyWrvOAHduw3sqEA+cYBqvHB7M0MHFcRJg7VWOo=; b=ij6IxPpizzIO3Z6UHiX7ONd7B5a7LvFEkQhMKpcmbMLsu1Rjf2umsriIiykCIXn/kR Fvzs5OHJw4OfP26H/3dg8/PPHe+na+zz1jhSGExuuavRJ5dB1tzO0wBlkO9JMV80+SSR J2b0QkAGsdgqj/CuvrnReGEXPanC0GPm1znWj78q7Yiur7Qy8WPT2GaJlAakTiOQ3IjV FY9MSDHwEB93zD+vmqebXEVcWI366UHyhhHRp4ue7R3KD7PGXWg3tyrxySfG2g33j8y9 a2tVZA/oy4eZ9ER3IjBm0vaVe7ZpxIWwE5uU2mAzoubpez9otVwHI1Le8BVxubDSSd7u rDbA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ARFYhvdg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-47ea1f96d34si49567911cf.417.2025.04.25.15.26.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Apr 2025 15:26:14 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ARFYhvdg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8RCD-0008BI-2V; Fri, 25 Apr 2025 18:07:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8RAo-0003bI-9U for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:05:32 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u8RAl-0001pk-LN for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:05:29 -0400 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-7376dd56f60so2134657b3a.3 for ; Fri, 25 Apr 2025 15:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745618726; x=1746223526; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bOWCeKNlLhAgVYEVI4tqJhLjqQCbsv0AzZbbO08r8rw=; b=ARFYhvdgs1x68REt1B+n9Zs5ZYalXDGmfXFEvAAcwNYSIHXv5x5Kip9LpQuROrgAua kztA0V3f2Q+ytuM35UxEN8LkN0ITdrHbXFKMlHeI9FaunUyN1g9ReUfUnkn3MT7tisPr OFDFMdU2JPaLPCkDOkykdMmTrKw8NT08r7lG/rbi5/GBemmNiR5gDZ2J93i5JyjBnVvP DiJDJp99SytlGAvd8cPg7nqVMqx4iSXJwhfhljxYMe3vt9YrJxlvN9N2sg9ZmciVQaWj /A2T5NVz9h9pt95hyjQE5vf4JZVBIe6ACD88pqCVhC2wtWLnJ0w4EB+zt5svgvGux1Es Q6PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745618726; x=1746223526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bOWCeKNlLhAgVYEVI4tqJhLjqQCbsv0AzZbbO08r8rw=; b=k0TfDjiMIOnA5l7gcLP78vpjN84JlfA1yIt3WfCsszlPLQt3v45wyOYpcnjGUgDWrV OKeMOF0U8GvFzgfbLu+Jk2DbaouFkzDbdrf1XLs9H2q3HUEXVSJ6bKQ+xNgRFcSjLLSW va0IqQ13U/4VEV47gfls1YumzbS7axMgLJnrJypUIqc3s29ujcj7Lo0C8KW2QzzJwNxA QBD9XDDWu/Id29lZQgrH3vj0BDvvD2MPHQEaU6tuBg4/tHCleQo2zGQt8sDYg4wRunQO Wn/c91UGkr2hba1BQATHn1cBLsP4I5temGswuthVmWAZQoH/chlWZFVpiBYbsqIc27g0 3GJQ== X-Gm-Message-State: AOJu0Yzt0k9c11dsaYwqjG0wW5W/5JCjpO/+FwGe/J50R4+m3sGDwXUE vQG10dkh4Lj7rsskkaLVexStES/R/I+AX0UynTWgIVsarEGX+ofOvQ9qgLbQxlf/NtKfJZLYjJZ O X-Gm-Gg: ASbGncsUQ+VgJyMbpclVCRpUqW0aZSfZYlzTMjUOYQs0+/pnhgdDEUjEPLCdiOfu8Bm yvK3V8jWv9y6ng14o4EIPGmpOeu0ZaWN1/djftRouzCSCnyvgAw/2lav3NYhlPe2PEaNvAZcO8A sglKT2If+JDnKibgFL21oDIJa80ckpECAnN7YsJlvPK15oMt45cg6m/rLFE4bVnJM1fvsbPkq+k Ve5MJVHlSU4DUUJHpJKXCyHsi4S+kXbGmCuACBptBAR4rUhz669TZg5dPHqISdw2Qky0WRq6vJI 1q89miljpDj/DRfkPL3TME7RyKlSBoimV2mkkyIEX/ljDPBYx3WPQ5XcKCfvezOR4JmrhDA8kcc = X-Received: by 2002:a05:6a00:1817:b0:73f:1c49:90f3 with SMTP id d2e1a72fcca58-73fd73c806emr4393370b3a.11.1745618726103; Fri, 25 Apr 2025 15:05:26 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a49esm3796573b3a.106.2025.04.25.15.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 15:05:25 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 122/159] tcg: Use sub carry opcodes to expand sub2 Date: Fri, 25 Apr 2025 14:54:16 -0700 Message-ID: <20250425215454.886111-123-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250425215454.886111-1-richard.henderson@linaro.org> References: <20250425215454.886111-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index f17ec658fb..447b0ebacd 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -1126,7 +1126,13 @@ void tcg_gen_add2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 al, void tcg_gen_sub2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 al, TCGv_i32 ah, TCGv_i32 bl, TCGv_i32 bh) { - if (TCG_TARGET_HAS_sub2_i32) { + if (tcg_op_supported(INDEX_op_subbi, TCG_TYPE_I32, 0)) { + TCGv_i32 t0 = tcg_temp_ebb_new_i32(); + tcg_gen_op3_i32(INDEX_op_subbo, t0, al, bl); + tcg_gen_op3_i32(INDEX_op_subbi, rh, ah, bh); + tcg_gen_mov_i32(rl, t0); + tcg_temp_free_i32(t0); + } else if (TCG_TARGET_HAS_sub2_i32) { tcg_gen_op6_i32(INDEX_op_sub2_i32, rl, rh, al, ah, bl, bh); } else { TCGv_i32 t0 = tcg_temp_ebb_new_i32(); @@ -2865,7 +2871,26 @@ void tcg_gen_add2_i64(TCGv_i64 rl, TCGv_i64 rh, TCGv_i64 al, void tcg_gen_sub2_i64(TCGv_i64 rl, TCGv_i64 rh, TCGv_i64 al, TCGv_i64 ah, TCGv_i64 bl, TCGv_i64 bh) { - if (TCG_TARGET_HAS_sub2_i64) { + if (tcg_op_supported(INDEX_op_subbi, TCG_TYPE_REG, 0)) { + TCGv_i64 t0 = tcg_temp_ebb_new_i64(); + + if (TCG_TARGET_REG_BITS == 32) { + tcg_gen_op3_i32(INDEX_op_subbo, TCGV_LOW(t0), + TCGV_LOW(al), TCGV_LOW(bl)); + tcg_gen_op3_i32(INDEX_op_subbio, TCGV_HIGH(t0), + TCGV_HIGH(al), TCGV_HIGH(bl)); + tcg_gen_op3_i32(INDEX_op_subbio, TCGV_LOW(rh), + TCGV_LOW(ah), TCGV_LOW(bh)); + tcg_gen_op3_i32(INDEX_op_subbi, TCGV_HIGH(rh), + TCGV_HIGH(ah), TCGV_HIGH(bh)); + } else { + tcg_gen_op3_i64(INDEX_op_subbo, t0, al, bl); + tcg_gen_op3_i64(INDEX_op_subbi, rh, ah, bh); + } + + tcg_gen_mov_i64(rl, t0); + tcg_temp_free_i64(t0); + } else if (TCG_TARGET_HAS_sub2_i64) { tcg_gen_op6_i64(INDEX_op_sub2_i64, rl, rh, al, ah, bl, bh); } else { TCGv_i64 t0 = tcg_temp_ebb_new_i64();