From patchwork Fri Apr 25 21:54:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 884519 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp4183605wrs; Fri, 25 Apr 2025 15:14:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXj/iHNVEB+A6FiM1b06fcodZrn3gIvizmGhwxGqD49g1sbPRN7EJbN5e0nNBtCCtvbgIWt9w==@linaro.org X-Google-Smtp-Source: AGHT+IFM0NTQhqn3AqHdJBw7IbDqFOANURqUO0RekZQPS1EYWPwgqdOhiJQeo5RifAkOV/19hoCQ X-Received: by 2002:ac8:7f52:0:b0:47a:e81b:ccb9 with SMTP id d75a77b69052e-48131227abdmr18652011cf.2.1745619288073; Fri, 25 Apr 2025 15:14:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745619288; cv=none; d=google.com; s=arc-20240605; b=Q479trGo6F3oeRPq2f5RubvWiwTC8c78fjWPAFJC1MZ8AKuLf6bmmMvINBCXH6BrYv E4OwbrHe3scfnzMdOnt6+ujWN4G0DOjrDxvsBgM2i4Yaf6KlNSzqXVRRqemT3J9DV7Mx E9sOZKkqMsa+FLK1eSlsviwchGairzCuhob6ZxNKKfSaSGF6bHlDhSMH+xMdt7U+UeIO oHScm3VvMTuJwmMYUKpnslMY1SWc1kGADMUZNoXkvWL8o5ZfQQJdIg5KCP82WDAxhUYw 1v500UphMv+yHixnzoJZG3IbChBHkJLxUxoYM6tjzj4gqTCKURBqarWEUbvEzGCPKV7H Hxlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PbSVy3Es7yY894Px54QTOXJuGag8hqcwPgRRTGQnAbA=; fh=i/pWNGcx7KiR3ewgypxpPkuORYlkCnVXLqKVm9/UgNc=; b=ixSQI5xMmHg1nf9FihxXuxZ3xynswkFM3Z6AS6tj31GSUiYVnKzYTIPvcZfgfR8nTH DQkCbFW4dsMxKH7mnBH5GbL6IOeeZ7HsztKA9OB2s4W7F9ulVIFoteU3yGpD6uoBNUaZ b/Ib+j+cCgYREul5R2GtYQCZNEaeUPsrRmxPsbod4+FiSUtbCArQjkcSwaH/9E/5HFF3 WfAReU77iLpdW1mJzlbNJEf4IPpo53DHRyXCx5Q0UdrOHcvKLOOxgLauKKJ+5iUGofcx owjFALgjJpv9QyhyyMY52F1gH+5Olj3cuUYIX/BRGECgC9leIZNwXfeHrxaApnx95SEi MH8A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="goRO7ge/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-47ea1f995ccsi49157301cf.444.2025.04.25.15.14.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Apr 2025 15:14:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="goRO7ge/"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8RBC-0004N3-UB; Fri, 25 Apr 2025 18:05:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8RAt-0003gP-1k for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:05:40 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u8RAp-0001qW-Rd for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:05:33 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-7370a2d1981so2355432b3a.2 for ; Fri, 25 Apr 2025 15:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745618730; x=1746223530; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PbSVy3Es7yY894Px54QTOXJuGag8hqcwPgRRTGQnAbA=; b=goRO7ge/NQeGqwMxBA+e5hr8HLOrZN04Ino9OOA8HUTI/EG1E6gvieVJ5OOSreQdMW zScCPKf1lsZvPM+QnlleJv3OD7u0J6LD6mi0myTBw4alc/GLSSulwIvGpXTNfoU+w7Z7 YvZV7OXIjanhr3tX43isbtYLPJ/7UCaydd6LnXCcmqSLOZaCz1NOWLyMsUZByagt7g4f 4yZ/pOoDjQUfBn2OT8487/DP/v/UMr23Icnv+KnrqCCRL3mvjrTk0Y0Y9OrG/BlhSXpT Mk2HG71cusbT4LwnxhqoREvGwJ/arDRGPntWg/iXH8hWsPAq+czFaxaugd7+4TDcu+Tl XBpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745618730; x=1746223530; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PbSVy3Es7yY894Px54QTOXJuGag8hqcwPgRRTGQnAbA=; b=I/Kqqv+VjzPAFO0oYNqxjVv9zmzaBioVtevkunaZbcIsbRNqhnf9TfXdF68lYNC6Fc d43VxpbZUDo/2IXf3ng3XQKqnV2qCIZAaL1znRsa2sSE5GNBMvtkSA8ymCExGWoa5qeb J+3ELaEtkIL7Bea6RKJQVwZ+Ou8mEnibEEemlnZ5K0PPL3RdY52jOL2EBtEJsPegeNub HZsKIsB/lgaWpW0lg2tivQ6ZiHVklpuN33TNljzOxUVGi8CVQwYaR2TTDhHxmBRqavF2 9WR46brIFm7L6BZQyzhm3uUYDkulMwixz7hHRdy3cGHMrROnRj/SFvXcfhX+KXmS/N5W NhHQ== X-Gm-Message-State: AOJu0YzsnIaRDQjIuM2/KEtpl9HY2G++8vNWoAb8wjOmt2anQsw+o89w pflKbjDd1rGNy1V6YJ2g//mOPEc+TXHkPYY8ycFqfj9TlyvQIQyw6ZKzH2sTKjBb85O7hMzhKk4 6 X-Gm-Gg: ASbGncsRnA19iXvoB+cNDRhw4N8oiT1WOl8cCZdjpIKS4O0J3iKEFc8fVdgEAo3kWlT f3qCCT91YfU4tbgQxY6/DvWQhftE6dRGgpMucsCVl/S0yP6rTXtW6lSXGUKWTYvEanEy2W965PW ABoFUZRm1q4QoGvqoeuLdjCptLRDfjc9d3HSXkJODH9YVdG9FZIWtnnjVI8/dN4wPbpxUAIaDTu a3GPS3bYmWFvHfMshepQRzet5uQRG0yaRMXR1MwQDP155k1QMH295HHdmC7vCTYnDhKnMxY4AsN RxdCLcznPLVGbSunnJoYWJ/LOzNQxrk+ZfYXFIJYlDc7i3ROrXsxWOTR9MpaEHaiPAguq9tzPHE = X-Received: by 2002:a05:6a00:3a12:b0:73e:2dc8:94f3 with SMTP id d2e1a72fcca58-73ff725247amr1320768b3a.1.1745618730072; Fri, 25 Apr 2025 15:05:30 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a49esm3796573b3a.106.2025.04.25.15.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 15:05:29 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier Subject: [PULL 128/159] target/hppa: Use tcg_gen_addcio_i64 Date: Fri, 25 Apr 2025 14:54:22 -0700 Message-ID: <20250425215454.886111-129-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250425215454.886111-1-richard.henderson@linaro.org> References: <20250425215454.886111-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Use this in do_add, do_sub, and do_ds, all of which need add with carry-in and carry-out. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/hppa/translate.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 14f3833322..88a7d339eb 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -1209,10 +1209,10 @@ static void do_add(DisasContext *ctx, unsigned rt, TCGv_i64 orig_in1, cb_msb = tcg_temp_new_i64(); cb = tcg_temp_new_i64(); - tcg_gen_add2_i64(dest, cb_msb, in1, ctx->zero, in2, ctx->zero); if (is_c) { - tcg_gen_add2_i64(dest, cb_msb, dest, cb_msb, - get_psw_carry(ctx, d), ctx->zero); + tcg_gen_addcio_i64(dest, cb_msb, in1, in2, get_psw_carry(ctx, d)); + } else { + tcg_gen_add2_i64(dest, cb_msb, in1, ctx->zero, in2, ctx->zero); } tcg_gen_xor_i64(cb, in1, in2); tcg_gen_xor_i64(cb, cb, dest); @@ -1308,9 +1308,7 @@ static void do_sub(DisasContext *ctx, unsigned rt, TCGv_i64 in1, if (is_b) { /* DEST,C = IN1 + ~IN2 + C. */ tcg_gen_not_i64(cb, in2); - tcg_gen_add2_i64(dest, cb_msb, in1, ctx->zero, - get_psw_carry(ctx, d), ctx->zero); - tcg_gen_add2_i64(dest, cb_msb, dest, cb_msb, cb, ctx->zero); + tcg_gen_addcio_i64(dest, cb_msb, in1, cb, get_psw_carry(ctx, d)); tcg_gen_xor_i64(cb, cb, in1); tcg_gen_xor_i64(cb, cb, dest); } else { @@ -3008,9 +3006,7 @@ static bool trans_ds(DisasContext *ctx, arg_rrr_cf *a) tcg_gen_xor_i64(add2, in2, addc); tcg_gen_andi_i64(addc, addc, 1); - tcg_gen_add2_i64(dest, cpu_psw_cb_msb, add1, ctx->zero, add2, ctx->zero); - tcg_gen_add2_i64(dest, cpu_psw_cb_msb, dest, cpu_psw_cb_msb, - addc, ctx->zero); + tcg_gen_addcio_i64(dest, cpu_psw_cb_msb, add1, add2, addc); /* Write back the result register. */ save_gpr(ctx, a->t, dest); @@ -3553,8 +3549,7 @@ static bool do_addb(DisasContext *ctx, unsigned r, TCGv_i64 in1, TCGv_i64 cb = tcg_temp_new_i64(); TCGv_i64 cb_msb = tcg_temp_new_i64(); - tcg_gen_movi_i64(cb_msb, 0); - tcg_gen_add2_i64(dest, cb_msb, in1, cb_msb, in2, cb_msb); + tcg_gen_add2_i64(dest, cb_msb, in1, ctx->zero, in2, ctx->zero); tcg_gen_xor_i64(cb, in1, in2); tcg_gen_xor_i64(cb, cb, dest); cb_cond = get_carry(ctx, d, cb, cb_msb);