From patchwork Fri Apr 25 21:54:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 884811 Delivered-To: patch@linaro.org Received: by 2002:a5d:474d:0:b0:38f:210b:807b with SMTP id o13csp4191883wrs; Fri, 25 Apr 2025 15:44:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXvb0ZydDi326xq14pQsdYkSGfSTEd5401gwE2da0n2Dp/Oz/S+rAk4My5Jt7OdBSUAAWEe0A==@linaro.org X-Google-Smtp-Source: AGHT+IFRRWya5pYU9Kg2rzvQiI+Z2XrMnsJZ1TIxjOjhiTJ5qMvox1S0ILoV6aTjmR4VFup1KxzK X-Received: by 2002:ad4:5c4c:0:b0:6f4:c84d:d1bd with SMTP id 6a1803df08f44-6f4cb9ae439mr73130196d6.6.1745621046902; Fri, 25 Apr 2025 15:44:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1745621046; cv=none; d=google.com; s=arc-20240605; b=Zg42uGhJNAHlrBEsoVzOrq7i6R4HCV60JXpvpJtz18mQyLrX/cCG4g8WD9G5vwpJij xiROsC2mToQODnOzNfPgETYqtpEfGXCT3DIL+EU5p980GbJwtMTSB4hgx5JgnxBstL6i 54bVrxdRmSTjglHniK1cTbChrCnfs9p+02nMjtD7HcRCZAFA+zXJ6xQRuEEiOT0ViygV NN+Dju96IH1ZZfmnfRyBK0eLTev2SOCEW0alQPPoGxKGCtOpHxpend5HZ4jGj9BWbGtj 7qDlVpgmInxex5gSbcWWDKHr0KncS96GMnwjF2UehrIQKs1x7hFEAfO7QDJswXcVe8Sj hS/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9kr5nd/ZituzS7N6ANSAziki2MVGNQqIZBqxjrspSXs=; fh=iupG3lj8MVHgzlcNu/fwzq1hB2dnmnR3XAmVir9drB4=; b=RRd5TAPibXTz/gwlhL9fBL72Vl4a1iCXvGDRnj1EbeRK8RVWkKM//Mtqc5hneuVo6a yrl5k7BSnvPTF46QWRn5qyjwgeqPmdKN+63kYQ2rcFgwsOqmOmIqHeKdPreSmdpH5AND Jw6GUGqKtAhNA+J6v/Cj5IIKa4UD8UXMa/9uJVS3okL3QLNq0DzYFOGF3fvbU7/J64se zzVzsETni0ML+/Uq8jBBNcJbQRtrqF+nLAHYhUoQW92zHSXb0MkK19ZhdZaQko0ekjYa +kX+UIUrYCYZ4QmUjEm/JXtTBhLjzAXio8BOiDlFeBI67D/AvrrxR2o2VZRYdoUcTOyo vJpA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=u+R5yzK1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6f4c0ae9efbsi48597666d6.306.2025.04.25.15.44.06 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Apr 2025 15:44:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=u+R5yzK1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u8RBO-00053v-8D; Fri, 25 Apr 2025 18:06:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8RAv-0003ha-Su for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:05:43 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u8RAs-0001rG-QH for qemu-devel@nongnu.org; Fri, 25 Apr 2025 18:05:37 -0400 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-7369ce5d323so2262772b3a.1 for ; Fri, 25 Apr 2025 15:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745618732; x=1746223532; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9kr5nd/ZituzS7N6ANSAziki2MVGNQqIZBqxjrspSXs=; b=u+R5yzK12kYWjdTK6pBKcmNXA94m06aFnJs+WCbPYrucdzgTjsOsawMX9qVlsQlpCw lTLWsbQ5M70TOCkN4Mi90gRPh0VBVQg1vwooyd7whW2HawcF6MW68rKYfuZEAgjVaATB HqA8n5MXd9rQ7rS/cwL3UTgTOr18k40SU05FRi9/7sSfa85/FGUUTDkjth4u9D7+RPVf MBnncS1HdYIvYwDdLqSZ1eyn6g78ePMw8IyVI4+4agTk5cBYva5Z3MTbkakpYtGIPMqe 6Xb/qFvdhL/G0gL/ixs86rhJetbNHI9wZzIDHGmg66PrkWJnNsBYDDYz2aaL2UVyrhRe fIng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745618732; x=1746223532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9kr5nd/ZituzS7N6ANSAziki2MVGNQqIZBqxjrspSXs=; b=qIXcI0dQZb/Mcu+Gk0uPLXILgtgtDwkOiEpSSnFefQ8DuelSHRLseWbeYtqtBU34ZZ EQOFMkQ+4Eqp0cHF2i8Ysf5Ap/paKvu8RoG8LJ46XP86MMbEcQlH/WiWSKVIOxT0+8ud wRN66oifEdlJK5HdqQnu0HwghYiMFFkoo9L2IJGhBVNleV1OG5hvU4jB99h+vk5cyNUF k9JhRGUkHinY+/AW77ux9xtx8e1Csm8YoH/0h1zug+K0M9YVGIujfKPdsH8gSR1FlUKD HLy5AGG8GRB6xIEqGocNL10v/5QFbt19Aw+b/5rSMoQZyugichhZy1qxI8R6525xNNjw 8sVA== X-Gm-Message-State: AOJu0YxmeX40Eo2B6CTmIAZdtbC8iB/n91+3RvnMkMbArjswinXXeEAu U1Iym3MjgNmZIJeBanawqga9r+y8iyUhnB+HbqrryXREmJYLuIqhiPaal+q05kQIk6XUwcMiZ74 t X-Gm-Gg: ASbGncuzvsfSzggV3aCGRtoubjxJdG9bnKv0CPpjbCKIaqFAZzv6w8qlzwYvUmMrNso zdocWTAx1UOJpV3jOpeOosn42RSPY+lvFjGgH5qHH2nj0LhuvaHivMZ2hDHEAI8ESXifoW/2mjj hixz1FUPRfvhAtYGkjJRb41BlMHCzn6jcbjmN5oyGt2ymUkfO1MXCQVi0WsTYGfZHZ4VOVM3J8A YPKQzcdSFJxKYPI3G1Id84r5wTpa1Ie8NqmnA4P3KGx5CJbTuc5t1Qf47FK+R6dHG9+uDapMes9 b4/tVuGGm9oj7zJ65Y0VFW8yalZZQMVRmSWp145Iv7tgnigh7BshhO4UKiLfQltB2ZMsEpALmu8 = X-Received: by 2002:a05:6a00:130a:b0:736:32d2:aa93 with SMTP id d2e1a72fcca58-73fd8f4d3famr5257356b3a.20.1745618732309; Fri, 25 Apr 2025 15:05:32 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a49esm3796573b3a.106.2025.04.25.15.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Apr 2025 15:05:32 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Nicholas Piggin , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Pierrick Bouvier Subject: [PULL 131/159] target/ppc: Use tcg_gen_addcio_tl for ADD and SUBF Date: Fri, 25 Apr 2025 14:54:25 -0700 Message-ID: <20250425215454.886111-132-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250425215454.886111-1-richard.henderson@linaro.org> References: <20250425215454.886111-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Tested-by: Nicholas Piggin Reviewed-by: Nicholas Piggin Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/ppc/translate.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index fea2f2ce23..62dd008e36 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -1746,11 +1746,10 @@ static inline void gen_op_arith_add(DisasContext *ctx, TCGv ret, TCGv arg1, tcg_gen_mov_tl(ca32, ca); } } else { - TCGv zero = tcg_constant_tl(0); if (add_ca) { - tcg_gen_add2_tl(t0, ca, arg1, zero, ca, zero); - tcg_gen_add2_tl(t0, ca, t0, ca, arg2, zero); + tcg_gen_addcio_tl(t0, ca, arg1, arg2, ca); } else { + TCGv zero = tcg_constant_tl(0); tcg_gen_add2_tl(t0, ca, arg1, zero, arg2, zero); } gen_op_arith_compute_ca32(ctx, t0, arg1, arg2, ca32, 0); @@ -1949,11 +1948,9 @@ static inline void gen_op_arith_subf(DisasContext *ctx, TCGv ret, TCGv arg1, tcg_gen_mov_tl(cpu_ca32, cpu_ca); } } else if (add_ca) { - TCGv zero, inv1 = tcg_temp_new(); + TCGv inv1 = tcg_temp_new(); tcg_gen_not_tl(inv1, arg1); - zero = tcg_constant_tl(0); - tcg_gen_add2_tl(t0, cpu_ca, arg2, zero, cpu_ca, zero); - tcg_gen_add2_tl(t0, cpu_ca, t0, cpu_ca, inv1, zero); + tcg_gen_addcio_tl(t0, cpu_ca, arg2, inv1, cpu_ca); gen_op_arith_compute_ca32(ctx, t0, inv1, arg2, cpu_ca32, 0); } else { tcg_gen_setcond_tl(TCG_COND_GEU, cpu_ca, arg2, arg1);