| Message ID | 20250521164250.135776-17-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Maintainer updates for May (testing, plugins, virtio-gpu) - pre-PR | expand |
On 2025/05/22 1:42, Alex Bennée wrote: > We can handle larger sized memops now, expand the range of the assert. > > Fixes: 4b473e0c60 (tcg: Expand MO_SIZE to 3 bits) > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > > --- > v2 > - instead of 128 use 1 << MO_SIZE for future proofing > v3 > - fix comment, 1 << MO_SIZE goes to 1024 > --- > include/exec/memop.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/exec/memop.h b/include/exec/memop.h > index 407a47d82c..e934bde809 100644 > --- a/include/exec/memop.h > +++ b/include/exec/memop.h > @@ -162,8 +162,8 @@ static inline unsigned memop_size(MemOp op) > static inline MemOp size_memop(unsigned size) > { > #ifdef CONFIG_DEBUG_TCG > - /* Power of 2 up to 8. */ > - assert((size & (size - 1)) == 0 && size >= 1 && size <= 8); > + /* Power of 2 up to 1024 */ > + assert((size & (size - 1)) == 0 && size >= 1 && size <= (1 << MO_SIZE)); You missed the following thread: https://lore.kernel.org/qemu-devel/eec76ce0-c3ca-48ed-befe-e0930d4a39d9@linaro.org/ I think you need to check the replies to the previous versions of this series. There are several comments not addressed. > #endif > return (MemOp)ctz32(size); > }
diff --git a/include/exec/memop.h b/include/exec/memop.h index 407a47d82c..e934bde809 100644 --- a/include/exec/memop.h +++ b/include/exec/memop.h @@ -162,8 +162,8 @@ static inline unsigned memop_size(MemOp op) static inline MemOp size_memop(unsigned size) { #ifdef CONFIG_DEBUG_TCG - /* Power of 2 up to 8. */ - assert((size & (size - 1)) == 0 && size >= 1 && size <= 8); + /* Power of 2 up to 1024 */ + assert((size & (size - 1)) == 0 && size >= 1 && size <= (1 << MO_SIZE)); #endif return (MemOp)ctz32(size); }