From patchwork Mon May 26 11:23:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 892617 Delivered-To: patch@linaro.org Received: by 2002:a5d:6e53:0:b0:3a3:61c9:c5d4 with SMTP id j19csp1148612wrz; Mon, 26 May 2025 04:24:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUbrx1aYh0VZeiagDgLKs/Ae3l6n53yWD7aYzfrCRf3k92L5kE6A7laWXEds0QA3DTMFZZlxw==@linaro.org X-Google-Smtp-Source: AGHT+IEzvU5k80AkhuN9pHvwKyVkC8B800Jngh6qctUnLZJ2tDte2JMPFaKVf+F3Gn+eCXnUldkk X-Received: by 2002:a05:620a:4246:b0:7c9:38ce:becd with SMTP id af79cd13be357-7ceec49d71bmr1205654885a.22.1748258678437; Mon, 26 May 2025 04:24:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1748258678; cv=none; d=google.com; s=arc-20240605; b=FxNXsSxeWTRrYDMu8ijmFzqFM582rtHZn6kHAjFRoQGusKjD6Ltro4/TdtBdvWX13w W3yHpfhk3Gv07x3x3M/bKQ/rUg1Ev+wmbb4h8nH905JaQUNAE4y0hrkVlhUmJCCvMyYd uIV9xwc64nFxlhoYjhAnILIDVJaOG5KWJg6xd5dT6FdiAPN2cpCePz60NzQ0YSvCyx0Z cMorHVPKQANbsOR+zhff5XX26dyEj6dS3e8bSXzxgRXbvizeJG1V10gJ93xP58J/aX5i MYNrd5WCh5tpqmGBHUrhiVoQCOuFmoBEk5vgc0EiKeou9Z+sUP8pie4duCaqsBNMKA+A eZRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ELCLDmiYgPuDHAGlIm5WFjN8VBeP03kfHU9C8of95Hc=; fh=yJ49eLpBqpqVFnZJRRPZLNEMbih6QDbHwTTBb20HANU=; b=SJKU5rWnXDmjBpAyiERxU5oET6gNl3ArN6CpK7Q0Y1v0U3HYd7zKDMuoY9vE9zN+vi ANRfje3aPiLUO0JfTpbeP6ZjIa0b9msZjODTIvOHrbqc6MXFdRy6OzePHR3l+tQKLaa/ JfMaD2C/2NakaRXqwnYQy+W/1iMKBVG1e4WMbZ42sduGl5g6+DcNSUL/a0ssZAGiPSzI +bxlm/SL5JzT/dvxruiLaL5FewoUlszXMxxH6mJ6I004pYl+xF0UIt0gfSiaxoaTKPdU uWz3wsCak8Aoqxn7o6EykoBefxICVhKiSZTyJVSyaQsv155MUpLUxqAVfgB9UHXbs6Si ULNA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nfsl29ia; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7cd468adc53si2375072385a.333.2025.05.26.04.24.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 May 2025 04:24:38 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nfsl29ia; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uJVw9-0006Nt-CG; Mon, 26 May 2025 07:24:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJVw6-0006HN-Ay for qemu-devel@nongnu.org; Mon, 26 May 2025 07:24:06 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uJVw4-0001qZ-JI for qemu-devel@nongnu.org; Mon, 26 May 2025 07:24:06 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3a4d877dfb3so1008403f8f.1 for ; Mon, 26 May 2025 04:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748258642; x=1748863442; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ELCLDmiYgPuDHAGlIm5WFjN8VBeP03kfHU9C8of95Hc=; b=Nfsl29ia8jPOzsHMHnTwNY2JbyR0wHDCdPoW0MpXUhu1oPCffLBdh8A6MjfxGuk/db ja062goDkLmUjiO82hMB84nhfGaAevnQ15+DjeA3GoualCvZ8MKlXCakEd03RIImLkmB ehaR9DDRvV4D+DiHpx4CohbQ80tIckE0mh0z3Wr9+oO+EQg8jr51ZzmyYPt2UNXnHvv0 +FS1Veux8MqOBAikV+xWx28q90Bj6JmuuaTV5pCwkHcXdNB06kT7wCfJ5VX/IjWTDGBN Fql8oPlYPFyYuhwVfFmHPkU6UqLA0L011Z9GmcL4N4rbj+NPpB/jN8ccpVzCeHKco16b MYHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748258642; x=1748863442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ELCLDmiYgPuDHAGlIm5WFjN8VBeP03kfHU9C8of95Hc=; b=r3aHBZYrDf36uPg+tzvzeQyZZxY91sST+cymSuCsEpRJenKF51Dsp7nzevF8Klf/5M 9QwVey3HSZ0HymXO3FmzxMgi1TQqkBhPbn3YePLiQtqoXKNx1qeJOIgWEYuFWyo50Wgo fe7zMgWxLeG7iEWweEhMLd/lmlxUuu/ZdDOC8EQ3WXtOXS+/hTiNg6GCmouJ+NY5eWoZ xmiO3EnNBNVzDr1k99X+tyV58FB4F9UPN0+w6KFLXkHbgNLvfpskakwpsbO8oGb3smxF RWZyoLm09LJIybvKPMFjYMfS/sfZIbnTGYkX5T91QDATfsdoePzq8qVsuA5fng6omxEt uJuQ== X-Gm-Message-State: AOJu0YznkqYfL3BpYJ3urYuvkY0Mt9an2qER0gDjqn8FP7WChfW2MgS3 Vs7hHGT5wXpqVs+1BgtUjajKxvnXN9Qe/OTp/Tq+lylXyBSIqeataq2EAwIV1AjCC9yYDhyzrMm spvZTEr8fhQ== X-Gm-Gg: ASbGncv51IVU8vF7wzQ5EEw3jzDAZrnG9QHWKh0v9kf/0OqjqRUf438NNd+sT7lQbJw XbnI8kGzsduxf/y3fL7pdsTQ4FG7xLMxGn59aDrIoJskMvoz/o6xg7aSaO73S8gGsiyKSOkvMOf iegPJ4DkdaDsD/fy+UcsvHBZ4TSrcUtOb8J3cLMvCOvLEFQDC5nxaevT8RT8Wbi88qhsXkAd9aU DlzOQRE7P7tljDGlIGSpVw4k0bUl7P3I+r+oa1YM94cL31KcZQpp2qUrfvHCIJBPlLge3Ytgmxq gVR0RZjuasAou/5rvgUNgXtBfAsVfizbbRud1f9oIXMOdk67DS48VB8C88NN8jrZG39YP0V3kI6 TXxqkFjrAd9x88TN9cgt1PshGf9As3Wc= X-Received: by 2002:a5d:64cb:0:b0:3a1:fa6c:4735 with SMTP id ffacd0b85a97d-3a4cb474157mr7616249f8f.35.1748258642576; Mon, 26 May 2025 04:24:02 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4d8ea9520sm2841634f8f.70.2025.05.26.04.24.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 26 May 2025 04:24:02 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?b?RnLDqWTDqXJpYyBCYXJyYXQ=?= , "Michael S. Tsirkin" , Nicholas Piggin , Igor Mammedov , Daniel Henrique Barboza , qemu-ppc@nongnu.org, =?utf-8?q?C=C3=A9dric_Le_Goater?= , Ani Sinha , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Thomas Huth Subject: [PATCH 3/3] hw/ppc: Add stub for pnv_chip_find_core() Date: Mon, 26 May 2025 13:23:46 +0200 Message-ID: <20250526112346.48744-4-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250526112346.48744-1-philmd@linaro.org> References: <20250526112346.48744-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Since commit 9808ce6d5cb, building QEMU configured with '--without-default-devices' fails: Undefined symbols for architecture arm64: "_pnv_chip_find_core", referenced from: _helper_load_sprd in target_ppc_misc_helper.c.o _helper_store_sprd in target_ppc_misc_helper.c.o ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 Fix by adding a stub when CONFIG_POWERNV is not available. Reported-by: Thomas Huth Fixes: 9808ce6d5cb ("target/ppc: Big-core scratch register fix") Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/pnv_stub.c | 15 +++++++++++++++ hw/ppc/meson.build | 3 ++- 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 hw/ppc/pnv_stub.c diff --git a/hw/ppc/pnv_stub.c b/hw/ppc/pnv_stub.c new file mode 100644 index 00000000000..8d11c8b65bb --- /dev/null +++ b/hw/ppc/pnv_stub.c @@ -0,0 +1,15 @@ +/* + * QEMU PowerPC PowerNV stubs + * + * Copyright (c) Linaro + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "hw/ppc/pnv.h" + +PnvCore *pnv_chip_find_core(PnvChip *chip, uint32_t core_id) +{ + g_assert_not_reached(); +} diff --git a/hw/ppc/meson.build b/hw/ppc/meson.build index 9893f8adebb..02f248f5f46 100644 --- a/hw/ppc/meson.build +++ b/hw/ppc/meson.build @@ -55,7 +55,8 @@ ppc_ss.add(when: 'CONFIG_POWERNV', if_true: files( 'pnv_pnor.c', 'pnv_nest_pervasive.c', 'pnv_n1_chiplet.c', -)) +), if_false: files('pnv_stub.c')) + # PowerPC 4xx boards ppc_ss.add(when: 'CONFIG_PPC440', if_true: files( 'ppc440_bamboo.c',