From patchwork Thu Jun 5 16:26:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 894179 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:ecd:b0:3a4:ee3f:8f15 with SMTP id ea13csp42710wrb; Thu, 5 Jun 2025 09:27:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXQkxU1Jn9R/PYRepvpg8YkSujQjx7H7S9hz23B0/VdhHmf9kpnpoOhbnX/hyJ7iV2GyP6UvQ==@linaro.org X-Google-Smtp-Source: AGHT+IFtY8A1xzYHudf8PV845bqpj/VqHnr91BuuIAL4KdXa2Irox1NdZCtz7BAWK27RvkTKJflJ X-Received: by 2002:a05:6102:c11:b0:4c1:91da:dac1 with SMTP id ada2fe7eead31-4e746d021fdmr5672972137.6.1749140858227; Thu, 05 Jun 2025 09:27:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1749140858; cv=none; d=google.com; s=arc-20240605; b=dePSobnTXnHlltNrWDiLDR1zRZcU8Kyd1wC7nICHBvPrrf2KoxzO7fU2QGAzj30rti Lcgfv5wfSZq/suiZnHeFXOXOEfqgVMQs1KQdr2eLttS73tWXS8CqT+YOz5W3yWC1fojV EJnCPYyHtns9J7lwhKjIy9smI78XhyUUbAk02Xmw1jr7QGxoRcSACui++g3U6hvI6rtJ 6mJbUODuNG+1G7dlDai0vxJmu2W2oyyb0RPIL6XORUph6dZ1pPBtGn7VWLFIeP99okyY xc322FrVHNM59mu5E8VsDMMSeG1DD+oXS5eoJLSnCLcaMkfWGm/hMrsHgJyKZEyg8M2l aZxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tJVseqRaD6Laof0iJpbCH6iD9WwznG/NmTZUaRCwaMA=; fh=Kwva4PF4MU0CAODI8dO98oDU5IqpAA4cnlOSgFn3sAk=; b=bZGZS0YT7frqUluh6AUbO9uPT7bdpwts2Pz2u3LjxjnAA/6R3AETgXwVPdpY3zY2ro IM4Psiq79gOXxdLzZt4O1L4NNc4WOWrBhgj00207flZNdnqeRMddUPJpP5pexP41Mlwg vdxt3qddT3QbS10dd+LAuvUz2fLkcZqXT4KHguprXhliiwVKRVWTA4vodaBX+tLAAhvc zDqy40qiCxeZ8AYA5FCvcYg7UPnV05yD0VMrvAtAgjq0lKNvim82hTyLEL34nvXZyhzK 6KykWgm61xCUwSMU55KDjzdpBdAOCXN26+/OZe1Uu4hmIEOgQlhGH68cp9TXVB1IK750 K6Ng==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oFicJmi9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4e64e9e5dbesi5163456137.256.2025.06.05.09.27.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jun 2025 09:27:38 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oFicJmi9; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNDQt-000773-32; Thu, 05 Jun 2025 12:27:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNDQn-00073A-4w for qemu-devel@nongnu.org; Thu, 05 Jun 2025 12:27:05 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNDQl-0007y5-7D for qemu-devel@nongnu.org; Thu, 05 Jun 2025 12:27:04 -0400 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-acacb8743a7so211291566b.1 for ; Thu, 05 Jun 2025 09:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749140821; x=1749745621; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tJVseqRaD6Laof0iJpbCH6iD9WwznG/NmTZUaRCwaMA=; b=oFicJmi9XhFx04le9Jr3yawLTBS3KSDvqc7aQ+35SlAqhrNuHekgJPc3O/cpXhX5wd UnuA3mgUSxqWTUggVi6HaJuuuDGmiuKpK+EbaZvkglU/9A8r4v1qjOOCWUpDWY8dWMYL lI/y9/uiy2XaBPjV/U9NW4ju/VKipY3M2+Ap8WS+jenZlWotRC7kVRzFe6xPf0daAc+Y Z8yM9zMlB2r7nnMzApcVeqFwG848ryQvIDXP6/QwEMUEuptal7xCkT9q5BpwZuMRW0g4 ws5/5f2iE2YTeHxF8ZsAEmN5WW2EbdhQPbBB4EBUs6e9OndPC10IAm84PwaDeVBSA+El 6BIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749140821; x=1749745621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tJVseqRaD6Laof0iJpbCH6iD9WwznG/NmTZUaRCwaMA=; b=ozXiCVzOswAeXH07tt3rY4x0A2ugI28FZTnEx1ibkpPuSE6P9dxVjC09VEodQyfEnl NeAzTFqpXXHqHLnzghQDfkUctfIEnwMErNqDiIdIbB0Q1mO9VZ9goOI/EZtcPwXXEXjH sh2DlDgsGfx86mOJoUTugj781KgWfN7w3jjwGYpN5G7XA5Yh08lofb3K09MZvYwgbAPW LZFgmiGAb8vy7xiMcQOqq2vbu6IkQ6bWG/TmxA3AIsAYFwqSiV+FGvy5hAKqnmK6FoAn Qhd5CKHJfSsBLmj0wRpemW4+4BfK7MTH6vrvYu53wLwPfIdaPAFyx7O7fSmvzcZTz70k BoqA== X-Gm-Message-State: AOJu0YxMcZcaBZnkBKXs/2EcUw7n27UDrpSySDQcRtrQ7IwxI/QLhC34 bOQR8mg4DB66olCU1GhB47BQsNRwuCrHqOiku9WmIuMzY3ZVgHlvRFrOKmzC7sXqrl7KJGhVEmR ybbW9ea4= X-Gm-Gg: ASbGnctS7xanVtjaoFCwWui0R4VOmqKEqtgaO7UDXw4fBpYATYO4mBe9RHa8WrqQndv 9z1Hkr7a7oqDyBRbRSbp/12nNOJltfEwkEITaBiz/QrZnRGBHLAq5GlQP3RoaFxw57KEuUCks/d bsu36qU72mxc5gYFbEX9en3jFXN/t7D5Ok4SY//ys9kvqm4UyG8S9T0hvYQo/42f3OzwgP4JMy3 M5FSby5GJRb5osF920ZtY2pA9BRdcFNBFYWRZQFbY37RduSEQsVEbcE0rYoBEfKyonxO1GcTs1X 6D1feTUln5CfglqZBM2IylUZfRg1m2txlc8UHsDa2JpvCyzrI3tx X-Received: by 2002:a17:907:3dac:b0:ad2:2fdb:b0ab with SMTP id a640c23a62f3a-ade07901184mr448467866b.29.1749140821295; Thu, 05 Jun 2025 09:27:01 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ade125a01c3sm79920566b.95.2025.06.05.09.26.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jun 2025 09:26:58 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id C3FB85F832; Thu, 05 Jun 2025 17:26:52 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-?= =?utf-8?q?Daud=C3=A9?= Subject: [PULL 15/17] gdbstub: assert earlier in handle_read_all_regs Date: Thu, 5 Jun 2025 17:26:48 +0100 Message-ID: <20250605162651.2614401-16-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250605162651.2614401-1-alex.bennee@linaro.org> References: <20250605162651.2614401-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62e.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org When things go wrong we want to assert on the register that failed to be able to figure out what went wrong. Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-ID: <20250603110204.838117-16-alex.bennee@linaro.org> diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 565f6b33a9..6023c80d25 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1343,8 +1343,8 @@ static void handle_read_all_regs(GArray *params, void *user_ctx) len += gdb_read_register(gdbserver_state.g_cpu, gdbserver_state.mem_buf, reg_id); + g_assert(len == gdbserver_state.mem_buf->len); } - g_assert(len == gdbserver_state.mem_buf->len); gdb_memtohex(gdbserver_state.str_buf, gdbserver_state.mem_buf->data, len); gdb_put_strbuf();