From patchwork Fri Jun 6 16:44:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 894462 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:ecd:b0:3a4:ee3f:8f15 with SMTP id ea13csp614728wrb; Fri, 6 Jun 2025 09:46:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXQS3VH0wM4TSrghHybGKln2sEcW4tUkyCLUIb2GSQicS1FCUP854aQvFSSoXlk4gCwrjn0PQ==@linaro.org X-Google-Smtp-Source: AGHT+IGg8IbEoVCiDAGNZH8Eu12/MA8X/+ka7i48t/Q2G7mZZHCCFhZ1RhCxs0LOaLr+Q/ID07/L X-Received: by 2002:a05:620a:192a:b0:7d2:27ca:3b1 with SMTP id af79cd13be357-7d2298ec101mr748983985a.54.1749228396184; Fri, 06 Jun 2025 09:46:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1749228396; cv=none; d=google.com; s=arc-20240605; b=VJu+ESm+aBS4PGLtic1M12+PBE0QxizdHvziG6RAHBGlUCiy4aaK+NEoAiqmwciQan DMUr4Ntkm6m/kUBHsZAHj15D6BiggZMf5IBFrIB6N5VyXS0fz4P39IxhTs3YiwuMOkiS lFbJsKbua/mlqmkWuoHVzietQ5xghA9MPHQl7yF+0uWYTiSkr2vJB78UbQRjsExO3nR4 yZpUEo0GIAC3bX6GdlFGEeYD6PhcH49GIfbNQj5Eqa2t1eeBC2lC+CqxK3rDmPfvC7Uw OxIQQh9iS2+4BNTwcv2bqbYdt4t3LFn8+Y6fJSVa0FMF9UV3BemRT0Cg1GBB6JK6RDwU g2Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hNDNfI0qG9TUFAdzgUh03+hHn2rhRAOW0ter/WGtavA=; fh=t8eU813ECvXfe9r8ZA9SxVxC1Zyy8joF+mf6kT3Em/U=; b=GOBcFlDELK8B0Sda3lytCqvNcfEVomhKXLt0doEG6Y8DkTWIURvbx98MygacwsF+5q jcycSkeZTrknMn5iq3Kew/8k7Tr0n9dc5b9Jetf9zaexrDFMrAGpjnxJkKq0/MW3M+x9 pIJd+MVyNYCl5rTMetOXM/59jsi0qiFqYfGYSeXX5V5NRoTNnLnEWAaDbgIMzSrGf8Fv LAV4Hg5z0R+elO2ndw7IltN6jjYDBORYf+csI8Ac83jMzqeN5pjq1gRlD+BnU16A3mG7 9P9IKLM8En1IWmv8sL0ZdlLYJWU5gi2Qp/JvOvSCLRi54tc7Lw8TGgfBeT29DpbQmLRJ D2zA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h48OmWAT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6fb09b2fa9bsi19283326d6.387.2025.06.06.09.46.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Jun 2025 09:46:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=h48OmWAT; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaD9-0006aP-TO; Fri, 06 Jun 2025 12:46:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaCo-0006Bh-3O for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:12 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaCm-0003SC-EY for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:09 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3a35c894313so1946011f8f.2 for ; Fri, 06 Jun 2025 09:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228366; x=1749833166; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hNDNfI0qG9TUFAdzgUh03+hHn2rhRAOW0ter/WGtavA=; b=h48OmWATQoOfb1lCMtfKQhArpGp0k7bJw3bRZGaJzo9Fx3L/G5v3AAjIvUze+60kcH UMGdDP3nwg5PD9MOaQ5mU+mBmb0LCDFj6TATlyXNQwkxh7bsg+rWj9b2DlcK9Ovt3HiA T4AeF+kjEh5o0Blvv52zde+KIPlfbzr0LnoaGxIFxBNn4EubRb7bz5tIQwtzAAlKDvQF YyFhyUtk5fwPj88lcoQhMu/SSYCSNrgQovpUojFnxfbdyizBQv/+8jM2RwdadlGUc8nJ 6FwlFHYXjc9JnnZM1nQCTPSc7lax+3vptw7QIqV8PFO8xO8dBsN1soMFO2Vt2SnNjFM6 nHsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228366; x=1749833166; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hNDNfI0qG9TUFAdzgUh03+hHn2rhRAOW0ter/WGtavA=; b=VpjEHvIfkhKgWKgYJf2BgMwK7EM5HrA284KZ1eu3Y55JxK1sXyDKu2Bvw38Bzjqh31 mJbw/4Aii9T8wgaSEnzL072PVgNRKORsU/iiQfGBGsfR+QeSbOJ/fGr6hFg+JiVkDQis UxrjLLx1SV0cmGRKidfltF8CH6rNE0k7TxB0+aqEJwOV0Qzcf99+PADmD6/nDhKX3U8F s50egIpE8wAX8cK5IsMT6ZqC5ETnnC88vCrJHcSSNHBKvdqRlmYufdVV4WSrx5Ikajhn lXVqTnvWN2YmSPcFKu213cxwYNZheemXdTWxhOD2BJW6iAkmDOisC6y8BGy22Vxfr036 NGwQ== X-Gm-Message-State: AOJu0Yx7OY2YPh3buKdxE+0wuB2dX/p7cY3mzKm2fmerwMfpXtlnUPBr Ypjha93Y9SumkC61JT8B0Kr3L0V5fG/hnjb+6MJg2lkLw8KBJqGXuHyokjMECu9wT9Kie0N7UIM 1XcYVRkyFbw== X-Gm-Gg: ASbGncsMwmcpPb0oSXvyTwT1rletFN5VYf7M5JdDWdA5VDvQxws//OhQibHOClW1mff A01lQAT0bKl9z8qSKK/h1Pg4vqubD5DTrGzIgZu0OfCFJHQwRX+gOurJmiMXAhFD2zQm6YR7XNm +M74ZNwTu7J+LFHqCjHFmymbDnG8rMQDC2esFOV8dUxPQvvnIxqBrWItKTob7Y3dKDN6IhgJOHA 4CcgobSOx/Ss4Ohb11bY3DGpYusWh05GbQb9g0QK7qYjlkCitfzddBA7Q06kt4LkNkWFpdNDp57 hqGsBIy83Cx9jmd1EX7BSLe79KR6ELZN4wwaOfxZgIGjPl4O1WRWfCCrGu3R9x7NFwQfbviey0F xfTDPvdUVUFT8b1w9Mxpp0KwIttIkMxV+rs+MXiEXFCL4u1HX X-Received: by 2002:a05:6000:24c7:b0:3a4:f71e:d2e with SMTP id ffacd0b85a97d-3a531ce8887mr3630177f8f.56.1749228366439; Fri, 06 Jun 2025 09:46:06 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4521370936esm30071185e9.20.2025.06.06.09.46.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:46:05 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 14/19] accel/dummy: Convert to AccelOpsClass::cpu_thread_routine Date: Fri, 6 Jun 2025 18:44:13 +0200 Message-ID: <20250606164418.98655-15-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org By converting to AccelOpsClass::cpu_thread_routine we can let the common accel_create_vcpu_thread() create the thread. Signed-off-by: Philippe Mathieu-Daudé --- include/system/cpus.h | 4 +--- accel/dummy-cpus.c | 14 +------------- accel/qtest/qtest.c | 3 ++- accel/xen/xen-all.c | 3 ++- 4 files changed, 6 insertions(+), 18 deletions(-) diff --git a/include/system/cpus.h b/include/system/cpus.h index bfaa339dd73..e7ca9f4d684 100644 --- a/include/system/cpus.h +++ b/include/system/cpus.h @@ -9,9 +9,7 @@ const AccelOpsClass *cpus_get_accel(void); /* accel/dummy-cpus.c */ void dummy_thread_precreate(CPUState *cpu); - -/* Create a dummy vcpu for AccelOpsClass->create_vcpu_thread */ -void dummy_start_vcpu_thread(CPUState *); +void *dummy_cpu_thread_routine(void *arg); /* interface available for cpus accelerator threads */ diff --git a/accel/dummy-cpus.c b/accel/dummy-cpus.c index 7c34e6c0fc5..c6756252550 100644 --- a/accel/dummy-cpus.c +++ b/accel/dummy-cpus.c @@ -18,7 +18,7 @@ #include "qemu/main-loop.h" #include "hw/core/cpu.h" -static void *dummy_cpu_thread_fn(void *arg) +void *dummy_cpu_thread_routine(void *arg) { CPUState *cpu = arg; @@ -70,15 +70,3 @@ void dummy_thread_precreate(CPUState *cpu) qemu_sem_init(&cpu->sem, 0); #endif } - -void dummy_start_vcpu_thread(CPUState *cpu) -{ - char thread_name[VCPU_THREAD_NAME_SIZE]; - - dummy_thread_precreate(cpu); - - snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/DUMMY", - cpu->cpu_index); - qemu_thread_create(cpu->thread, thread_name, dummy_cpu_thread_fn, cpu, - QEMU_THREAD_JOINABLE); -} diff --git a/accel/qtest/qtest.c b/accel/qtest/qtest.c index c5a53ecb6dd..6930cc4cf3e 100644 --- a/accel/qtest/qtest.c +++ b/accel/qtest/qtest.c @@ -63,7 +63,8 @@ static void qtest_accel_ops_class_init(ObjectClass *oc, const void *data) { AccelOpsClass *ops = ACCEL_OPS_CLASS(oc); - ops->create_vcpu_thread = dummy_start_vcpu_thread; + ops->thread_precreate = dummy_thread_precreate; + ops->cpu_thread_routine = dummy_cpu_thread_routine; ops->get_virtual_clock = qtest_get_virtual_clock; ops->set_virtual_clock = qtest_set_virtual_clock; }; diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index de52a8f882a..3bd91889925 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -151,7 +151,8 @@ static void xen_accel_ops_class_init(ObjectClass *oc, const void *data) { AccelOpsClass *ops = ACCEL_OPS_CLASS(oc); - ops->create_vcpu_thread = dummy_start_vcpu_thread; + ops->thread_precreate = dummy_thread_precreate; + ops->cpu_thread_routine = dummy_cpu_thread_routine; } static const TypeInfo xen_accel_ops_type = {