From patchwork Tue Jun 10 12:56:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 895189 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:ecd:b0:3a4:ee3f:8f15 with SMTP id ea13csp2247976wrb; Tue, 10 Jun 2025 05:58:11 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXn57+gnwSXzDBCxOXn+Po7xAcmc3SzRZ71DwMCv6sVM41WqFEx6J06bWGAqcLgxJinfFrTSQ==@linaro.org X-Google-Smtp-Source: AGHT+IFvq1GBgrgTYw65B/lcNsDoPdr9oPpcIz7qQOF+Un232dq6NK8ARBiQ+PDxC56AswMlj7dn X-Received: by 2002:a05:620a:1030:b0:7d2:26f3:83de with SMTP id af79cd13be357-7d2298ed2c8mr2447619885a.54.1749560280070; Tue, 10 Jun 2025 05:58:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1749560280; cv=none; d=google.com; s=arc-20240605; b=TDXRdkx1FrNQ7Ksi46FkM3Nzc0X6Mn4+/gh02jNKlCsQHFbOfkey+GWvJMXXniNQJn h2nNkjgswL/duULbYeObmZYxQ4EVy+1n3wgA0VIc2H6HqUmsBKmwPFI4jNRc7CebA1cV hTQlZcmtUelifh5OzYZI66DDwNsQDsNTDMB+6qcI6PWZk0Hx/dNuHrA6DWF0qJK1bVze xmbJ4Ll6Vn458rdgunONgggJMnlZQh3axQPyWfOdI6AKP7qfmNtbCVlWGKR/6Ku976V8 eaBZ8f1gjVMXbSlqzC0EbU3qgCDH010VwZvFxrCzczUWotJBRakA9r6AiqQ29aHV18Lp 2a2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nPmJc92lIzdWkVRDqUj3SpAKD/Q77Fm/aYA6SSL5Z8Q=; fh=A+psVfaAYVTlu1aNTKJwpkdf61NsFUPDxUJxilErp1A=; b=KX8JjTeONqrUlNwDq7nSWn6OGxzStFSE5Q/Ll8V5W0rD0hPHZccpeRngPONhkpZUtw xvCfbY1vM+nKq56XJ0FyBMdA3JXGvjzJy14zPCmcwwYKeVU6V1uhVO6JqrNX/5wyfoAN +iUvEph/sI9d/w4MCHyn9qATqnWGNDtUy0eZltkSRI6D67WacMQ56klpMt8aVw/gnKps hV1V2AnKcSkvnz/lczmC6NXygR15FLIW5kYlTxrmmCJnbnoKGTHIUcaeJ67Kuqgcdp+c g6YqIJy9+Vrki0UmmWY1nNepwxGRAL7wwANS6f+/43EVY86I9HLlQ93XcRBeYS0IM+sU DhIQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="NSRWm/vK"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7d24b3d0e8asi980002585a.35.2025.06.10.05.57.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jun 2025 05:58:00 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="NSRWm/vK"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uOyXs-0006qL-7b; Tue, 10 Jun 2025 08:57:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uOyXg-0006pU-Iu for qemu-devel@nongnu.org; Tue, 10 Jun 2025 08:57:30 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uOyXb-0002dJ-O9 for qemu-devel@nongnu.org; Tue, 10 Jun 2025 08:57:28 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3a3798794d3so4649078f8f.1 for ; Tue, 10 Jun 2025 05:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749560241; x=1750165041; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nPmJc92lIzdWkVRDqUj3SpAKD/Q77Fm/aYA6SSL5Z8Q=; b=NSRWm/vKXhTfMeGAjSHfoj7Qe2mej7L0pyhAEXbb0Pz/51c+Eurox45fAJZ+8ps6m+ ECKlneZxYxv9Z0WJbEMizUC4pxAIyqsBqdXLcMR02iLlY1qX62L7u/N5EuxO1kXDitye q/CY+lrT8zFagl3Afi5dsL6tvkKiSzxntueF0VvvEV8YhO3HehppsUd6gAi5gmAMSaKJ wNicg+l+8aTX05h/DmaF4+tbXDYya2Y84LU4pTwarbNdGMHH4JYYLKS2gaUkcc/1bMyI Km9KlqLVndeY07oXNbeBaPGaThWfmJWWOJKaptAAGckN6Cv46BDm5IkQZ4KNbA7FR96u 7PpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749560241; x=1750165041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nPmJc92lIzdWkVRDqUj3SpAKD/Q77Fm/aYA6SSL5Z8Q=; b=W1RRLXrcIzsu65YxrGDc2xB401Pw0+26+wrcl8uAHhATnd9fKfMvUlVa6JpwK9J6Ld baMfcQcp+1eAofa0yxana8cWPMXfoW1VV4Yd1090PSodqsYPCLFYIovE4RMBA3hb6/ob Qmqx1zfzYcnurNqAJohbQhpArHPbHLsivrzLtNRCLgBTpeEIy5Vwxv6WbABZQjjKbKqa Y9d7n6MiuFrqtT5tfkJiOaNLp+Dhp0FaEbukQw4bDaZXo8zodoxCNFrvMP47fGbTPKfv 3avjoYy5utn33QBvFGMgo/tbrosrFU5C+b2x2a4V40X9laBjMlSB74X9r3w+9/Bsxrl+ n5Pw== X-Gm-Message-State: AOJu0Yy+hcLA9iesD+JwTJR06PLlJl7cl5n6kkwdjK/JiUPFln1t/v+j AEFAER4rllE4sOvnu3Uy6I3Hhr3tGbXGx2XgfEMbM7RetvixJ19rOuhxBgPaPNI08nHved6kCn/ JuupmHQg= X-Gm-Gg: ASbGncuCj4pPIibUJ0aoVQnShFU2F44/SoyHGjMWwAI1oESABB1pzMC2Jc0DWF1tbIv LV+Jt8rlebZpUgtuWGiU07nmgOZxlZMZ47xmc+39m/yKrarm+IOQlvkDvbRd19wBNcK6tz8ozs8 gqtR3xwH25KYWE35RH/hEAQ+otgxnKDGzVNG0SFF7IXfXKIs9PJMZU7DJZo/ONTtuXXJ023U8D1 SlBwhENE4+Waygnw35EVMzKPjE8L1rlyjGv2ShkEJ4WmKdsLIXwBvrvwi+gJr4uV7d03aHIxtrS SUyAoZiWRYr2Sa04C85DYVOOLEqbcRGryP8OrtakhGSbKJc/9R65PzVj7Kos2YklSWvB/QzIRl8 PHbpCFJL0n8pgTDZwk6eVu7xcAizKMfikjMNymQsqag== X-Received: by 2002:a05:6000:4313:b0:3a5:25e4:264f with SMTP id ffacd0b85a97d-3a531cb01acmr14319771f8f.31.1749560241380; Tue, 10 Jun 2025 05:57:21 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229ddf6sm12079422f8f.2.2025.06.10.05.57.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 10 Jun 2025 05:57:20 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Helge Deller , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PULL 10/24] pc-bios: ensure installed ROMs don't have execute permissions Date: Tue, 10 Jun 2025 14:56:19 +0200 Message-ID: <20250610125633.24411-11-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250610125633.24411-1-philmd@linaro.org> References: <20250610125633.24411-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Daniel P. Berrangé We have been inconsistent about whether ROMS stored in git have execute permission set, and by default meson will preserve source file permissions when installing files. This has caused periodic problems in RPM packaging as executable binary files get analysed by various tools/linters, which can trip up on the ROMs. Tell meson explicitly that all the ROMs should be without execute permission when installed. Signed-off-by: Daniel P. Berrangé Reviewed-by: Helge Deller Tested-by: Helge Deller Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20250530152118.65030-1-berrange@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- pc-bios/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/meson.build b/pc-bios/meson.build index 79bb2e18008..3c41620044a 100644 --- a/pc-bios/meson.build +++ b/pc-bios/meson.build @@ -88,7 +88,7 @@ blobs = [ ] if get_option('install_blobs') - install_data(blobs, install_dir: qemu_datadir) + install_data(blobs, install_dir: qemu_datadir, install_mode: 'rw-r--r--') endif subdir('descriptors')