@@ -948,19 +948,21 @@ static const ARMCPRegInfo debug_cp_reginfo[] = {
* DBGDSAR is deprecated and must RAZ from v8 anyway, so it has no AArch64
* accessor.
*/
- { .name = "DBGDRAR", .cp = 14, .crn = 1, .crm = 0, .opc1 = 0, .opc2 = 0,
+ { .name = "DBGDRAR", .cp = 14,
+ .opc0 = 0, .crn = 1, .crm = 0, .opc1 = 0, .opc2 = 0,
.access = PL0_R, .accessfn = access_tdra,
.type = ARM_CP_CONST | ARM_CP_NO_GDB, .resetvalue = 0 },
{ .name = "MDRAR_EL1", .state = ARM_CP_STATE_AA64,
- .opc0 = 2, .opc1 = 0, .crn = 1, .crm = 0, .opc2 = 0,
+ .opc0 = 2, .crn = 1, .crm = 0, .opc1 = 0, .opc2 = 0,
.access = PL1_R, .accessfn = access_tdra,
.type = ARM_CP_CONST, .resetvalue = 0 },
- { .name = "DBGDSAR", .cp = 14, .crn = 2, .crm = 0, .opc1 = 0, .opc2 = 0,
+ { .name = "DBGDSAR", .cp = 14,
+ .opc0 = 0, .opc1 = 0, .crn = 2, .crm = 0,.opc2 = 0,
.access = PL0_R, .accessfn = access_tdra,
.type = ARM_CP_CONST | ARM_CP_NO_GDB, .resetvalue = 0 },
/* Monitor debug system control register; the 32-bit alias is DBGDSCRext. */
- { .name = "MDSCR_EL1", .state = ARM_CP_STATE_BOTH,
- .cp = 14, .opc0 = 2, .opc1 = 0, .crn = 0, .crm = 2, .opc2 = 2,
+ { .name = "MDSCR_EL1", .state = ARM_CP_STATE_BOTH, .cp = 14,
+ .opc0 = 2, .opc1 = 0, .crn = 0, .crm = 2, .opc2 = 2,
.access = PL1_RW, .accessfn = access_tda,
.fgt = FGT_MDSCR_EL1,
.nv2_redirect_offset = 0x158,
Although we are using structure initialisation the order of the op[012]/cr[nm] fields don't match the rest of the code base. Re-organise to be consistent and help the poor engineer who is grepping for system registers. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- target/arm/debug_helper.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)