From patchwork Fri Jun 19 14:34:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 191227 Delivered-To: patch@linaro.org Received: by 2002:a92:cf06:0:0:0:0:0 with SMTP id c6csp636948ilo; Fri, 19 Jun 2020 08:36:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzD1FVcnqwhG2pclc7+zUcwJEOkyy08lWQN4TYfibGoPNkdFkQsrjaBoO8sueFTVK/QifYp X-Received: by 2002:a17:906:4116:: with SMTP id j22mr4104750ejk.303.1592580970224; Fri, 19 Jun 2020 08:36:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592580970; cv=none; d=google.com; s=arc-20160816; b=bUYJ0HkmjuXqEQ4ATa9uVJ4QziHUk4HuKgU1Rcy2Cvl7qZ1tGmG9x6eq/AbgqShxKS gW7bZwFcdK3sBj3bNU+ewtTLBQo4nX+DcfSMdikVHQAFOq3ayXsm1DySgQYD1w+HxGyv wHV51ud/T+oF/o1RXqgO4VK2DsHeLAIp8zSEcHNlk+kMizWgnXrOdY/cE2QHlphAMyPQ cvGmso74J1ZB0xx0GCVV9NywYXoGTuhXfefk27fNZ904QyJrmnUHeRYUNL8gVLm4+1NG PllIL/xOyB7s5f5MD/WzZVf9rJcygxw2FFe4HMd/tcGrfK76Du/FjDw8Q0K1ght3vVYW Y9Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Gu8R6OVg0FO1qlU9xEUHbl46Jrz1mG5kUq5tD61gwDg=; b=l5jI+eRPJwO49vIwu7tfoEFlJBqJ9MXp6KarUqFBdailAwiE0odshvxpg3Rleg5eXP Zgh8lL1HtRxpXaFSS5nvLLVLUvbKrlliMp4ipOOoRasWtdllrMZnHLDAdKnMc03WLBs4 D3NCcYAGsFLorltPI/hxpny4bQS9iQCTWVwx8xHX2uVvzRyZalUOP5twP53w7SXKUj6e 3q3lVo6/AnPpBKfUdnLucX+GoHlEc9Gki4VSi3CdfCBJ+eTQ3VZYuvmCgkbmrC2Z8Rli OLXo92ccIcaVyCTesksLyw0Xw1QvEB8KnVt5r9Ia+30Eb60LizM5nyNeXccK/KDaB6nE /k0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OvTIgpKa; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm27si4099936edb.248.2020.06.19.08.36.10; Fri, 19 Jun 2020 08:36:10 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OvTIgpKa; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391327AbgFSPbG (ORCPT + 15 others); Fri, 19 Jun 2020 11:31:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:35008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393769AbgFSPbC (ORCPT ); Fri, 19 Jun 2020 11:31:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E156B206B7; Fri, 19 Jun 2020 15:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580661; bh=efE9qh+gRAoqSgGMofKgX7fsB1wxtB4Sw4lVk2loedU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OvTIgpKaU90H6WMuuca8gpoa1UrtTZREIQgXhfDl1rZIjegOJkiCAvSkhvUWMwkrt 3NlpbIZ7tdtw6ZpJuS/0ELsL6oqeZR5ANWzDK0I9M04G2WT+n4xEgKngaFhq40B5vk CU/W6H6Up/XVmds1PSWj8oH52UInpQzAPPjhN9oc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Szyprowski , Krzysztof Kozlowski Subject: [PATCH 5.7 334/376] ARM: dts: exynos: Fix GPIO polarity for thr GalaxyS3 CM36651 sensors bus Date: Fri, 19 Jun 2020 16:34:12 +0200 Message-Id: <20200619141726.139875972@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marek Szyprowski commit 8807d356bfea92b0a8f04ce421800ed83400cd22 upstream. GPIO lines for the CM36651 sensor I2C bus use the normal not the inverted polarity. This bug has been there since adding the CM36651 sensor by commit 85cb4e0bd229 ("ARM: dts: add cm36651 light/proximity sensor node for exynos4412-trats2"), but went unnoticed because the "i2c-gpio" driver ignored the GPIO polarity specified in the device-tree. The recent conversion of "i2c-gpio" driver to the new, descriptor based GPIO API, automatically made it the DT-specified polarity aware, what broke the CM36651 sensor operation. Fixes: 85cb4e0bd229 ("ARM: dts: add cm36651 light/proximity sensor node for exynos4412-trats2") CC: stable@vger.kernel.org # 4.16+ Signed-off-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski Signed-off-by: Greg Kroah-Hartman --- arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi @@ -68,7 +68,7 @@ i2c_cm36651: i2c-gpio-2 { compatible = "i2c-gpio"; - gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>; + gpios = <&gpf0 0 GPIO_ACTIVE_HIGH>, <&gpf0 1 GPIO_ACTIVE_HIGH>; i2c-gpio,delay-us = <2>; #address-cells = <1>; #size-cells = <0>;