From patchwork Tue Jun 8 18:27:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "gregkh@linuxfoundation.org" X-Patchwork-Id: 455831 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp4031955jae; Tue, 8 Jun 2021 12:13:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzz6mRj0fI58GhPSxaMUxzhpa3l9cXiYpguaujJB2TAvMJ+xxJQV8m3u/FFtMS6MEsG8zoc X-Received: by 2002:a05:6402:31f3:: with SMTP id dy19mr27161865edb.153.1623179624188; Tue, 08 Jun 2021 12:13:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623179624; cv=none; d=google.com; s=arc-20160816; b=OaEgc+hO+UEEUvK5SgLvRAPfEfTOMWH4FwFE7yxzsNogcj32CmX073lnDiE9nopkfB +/dQYDG84FrtunqPH+yE6xOxKgyJv5Vr/Z/9cuUO/k7uhBgpho2rhi2A9Ou37XC/hKTa WxNGmOsP8Y1Hl+YlbiC1y3Ipa5/cxgtkX7Gz89bxzCS3u9FC+f4hIARNceJJZL4mF9RJ ameHi3yescpZBmmroC/3PPXnef0yh9/F67pxqFKx4wmpJUsfD/dTEywtsLp9sd/9Egnp b9aAynZDl3la3ZXaiPu84jnlpRBJGgJJ4CHr3D8XUlwGkOnlJszojw+sU4o8/6Gyl5Jv vLww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Lppqu2tYg+juwz1bl6AFBu0iOdoN70dBcJZGA7POgkM=; b=PBPfxhKR2HCogIY6mcnay9fn8mWRa+4oJjPczBrL4jOA/ZxkJLaWaeZCkffKbdvLEN vYS7vFagengv/Urxax3aiG3re7XwiQ28z6JM9uiqcbKxEsV0w4ZJ/4PDZ98F7cVWGew5 rXaazYZIzRmFnAFZCxY2yPmmW8fo+1DrpI4duhCTaO1T0fThQDimRRCaAyQ1OnPSk0BQ 1E42l68uu0DccO5tybwGUaDwZ8pWQE2/9Xrk7tdodXldi7hlCs0cEUodgqm3fFBDy5Af 7orf2E7geUnRpr6TU750aUV9G/SYGmyEoX1RE+ZQJuYytScO1AIHKnbj96qP7jD603Yo YdrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qnZDfauH; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l23si509825ejb.573.2021.06.08.12.13.44; Tue, 08 Jun 2021 12:13:44 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qnZDfauH; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234858AbhFHTNx (ORCPT + 12 others); Tue, 8 Jun 2021 15:13:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:58908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236629AbhFHTLx (ORCPT ); Tue, 8 Jun 2021 15:11:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EBF1461947; Tue, 8 Jun 2021 18:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623178144; bh=k9qimZzS8pLMIf5jz271FfERmtM2ILCnjbYXe/DJ3QY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qnZDfauHkO6iyeLqB2ySUxBO6qHdS0WGaHAIi0IqddsEJiQ3p3kUJdRfDvv50U6lf nOBI7PEgwdcsb4XbWy2XxtZnYZQ9N4sxtcfn3BGHi9zQyN+UssOY8Wc9rRMqmLL6mO GTsgvDLxb3lFfSGGZ5W7d+RyufZTfU+VjjkeyZ+c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Linus Torvalds , "Jason A. Donenfeld" , "David S. Miller" Subject: [PATCH 5.12 094/161] wireguard: do not use -O3 Date: Tue, 8 Jun 2021 20:27:04 +0200 Message-Id: <20210608175948.623093629@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210608175945.476074951@linuxfoundation.org> References: <20210608175945.476074951@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jason A. Donenfeld commit cc5060ca0285efe2728bced399a1955a7ce808b2 upstream. Apparently, various versions of gcc have O3-related miscompiles. Looking at the difference between -O2 and -O3 for gcc 11 doesn't indicate miscompiles, but the difference also doesn't seem so significant for performance that it's worth risking. Link: https://lore.kernel.org/lkml/CAHk-=wjuoGyxDhAF8SsrTkN0-YfCx7E6jUN3ikC_tn2AKWTTsA@mail.gmail.com/ Link: https://lore.kernel.org/lkml/CAHmME9otB5Wwxp7H8bR_i2uH2esEMvoBMC8uEXBMH9p0q1s6Bw@mail.gmail.com/ Reported-by: Linus Torvalds Fixes: e7096c131e51 ("net: WireGuard secure network tunnel") Cc: stable@vger.kernel.org Signed-off-by: Jason A. Donenfeld Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireguard/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/wireguard/Makefile +++ b/drivers/net/wireguard/Makefile @@ -1,5 +1,4 @@ -ccflags-y := -O3 -ccflags-y += -D'pr_fmt(fmt)=KBUILD_MODNAME ": " fmt' +ccflags-y := -D'pr_fmt(fmt)=KBUILD_MODNAME ": " fmt' ccflags-$(CONFIG_WIREGUARD_DEBUG) += -DDEBUG wireguard-y := main.o wireguard-y += noise.o