mbox series

[v2,0/3] gpio: intel_gpio: Fix Intel gpio driver

Message ID 20200203103806.29445-1-wolfgang.wallner@br-automation.com
Headers show
Series gpio: intel_gpio: Fix Intel gpio driver | expand

Message

Wolfgang Wallner Feb. 3, 2020, 10:38 a.m. UTC 
This series fixes some issues in the Intel gpio driver.
I have tested it on an Apollo Lake device, where U-Boot is booted as a
coreboot payload.

Changes in v2:
- Fixed typo in the commit description
- Fixed the same error in both intel_gpio_direction_output() and
intel_gpio_set_value() (Thanks to Bin Meng for catching this)
- Reworded commit description
- Added reviewed-by tags

Wolfgang Wallner (3):
  gpio: intel_gpio: Pass pinctrl device to pcr_clrsetbits32()
  gpio: intel_gpio: Clear tx state bit when setting output
  gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()

 drivers/gpio/intel_gpio.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Andy Shevchenko Feb. 3, 2020, 12:35 p.m. UTC | #1 
On Mon, Feb 3, 2020 at 12:38 PM Wolfgang Wallner
<wolfgang.wallner at br-automation.com> wrote:
>
>
> This series fixes some issues in the Intel gpio driver.
> I have tested it on an Apollo Lake device, where U-Boot is booted as a
> coreboot payload.
>

When you send series, be sure you put all maintainers (not me, but
like Bin) to *all* patches in it.

> Changes in v2:
> - Fixed typo in the commit description
> - Fixed the same error in both intel_gpio_direction_output() and
> intel_gpio_set_value() (Thanks to Bin Meng for catching this)
> - Reworded commit description
> - Added reviewed-by tags
>
> Wolfgang Wallner (3):
>   gpio: intel_gpio: Pass pinctrl device to pcr_clrsetbits32()
>   gpio: intel_gpio: Clear tx state bit when setting output
>   gpio: intel_gpio: Fix register/bit offsets intel_gpio_get_value()
>
>  drivers/gpio/intel_gpio.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> --
> 2.25.0
>
>
Wolfgang Wallner Feb. 3, 2020, 1:19 p.m. UTC | #2 
Hi Andy,

> -----"Andy Shevchenko" <andy.shevchenko at gmail.com> schrieb: -----
> On Mon, Feb 3, 2020 at 12:38 PM Wolfgang Wallner
> <wolfgang.wallner at br-automation.com> wrote:
> >
> >
> > This series fixes some issues in the Intel gpio driver.
> > I have tested it on an Apollo Lake device, where U-Boot is booted as a
> > coreboot payload.
> >

> When you send series, be sure you put all maintainers (not me, but
> like Bin) to *all* patches in it.

I can't follow you.
I have used the following configuration for patman:

  Series-to: u-boot
  Series-cc: bmeng, sjg

And according to my local mail client all patches in this series have
been sent with this configuration (U-Boot mailing list as receiver,
Bin Meng and Simon Glass as CC).

Does it look different for you?
Or did I miss something (e.g. other maintainers)?

regards, Wolfgang
Andy Shevchenko Feb. 3, 2020, 2:17 p.m. UTC | #3 
On Mon, Feb 3, 2020 at 3:19 PM Wolfgang Wallner
<wolfgang.wallner at br-automation.com> wrote:
>
> Hi Andy,
>
> > -----"Andy Shevchenko" <andy.shevchenko at gmail.com> schrieb: -----
> > On Mon, Feb 3, 2020 at 12:38 PM Wolfgang Wallner
> > <wolfgang.wallner at br-automation.com> wrote:
> > >
> > >
> > > This series fixes some issues in the Intel gpio driver.
> > > I have tested it on an Apollo Lake device, where U-Boot is booted as a
> > > coreboot payload.
> > >
>
> > When you send series, be sure you put all maintainers (not me, but
> > like Bin) to *all* patches in it.
>
> I can't follow you.
> I have used the following configuration for patman:
>
>   Series-to: u-boot
>   Series-cc: bmeng, sjg
>
> And according to my local mail client all patches in this series have
> been sent with this configuration (U-Boot mailing list as receiver,
> Bin Meng and Simon Glass as CC).
>
> Does it look different for you?

Yes, for example for this mail (initial cover letter above) I see only
ML in To and none in Cc.

from: Wolfgang Wallner <wolfgang.wallner at br-automation.com> via lists.denx.de
to: u-boot at lists.denx.de
date: Feb 3, 2020, 12:38 PM
subject: [PATCH v2 0/3] gpio: intel_gpio: Fix Intel gpio driver
mailing list: u-boot at lists.denx.de Filter messages from this mailing list
mailed-by: lists.denx.de
unsubscribe: Unsubscribe from this mailing list
security:  Standard encryption (TLS) Learn more

Are you sure you have Cc filled at the end before sending?
Bin Meng Feb. 3, 2020, 2:26 p.m. UTC | #4 
Hi Andy,

On Mon, Feb 3, 2020 at 10:17 PM Andy Shevchenko
<andy.shevchenko at gmail.com> wrote:
>
> On Mon, Feb 3, 2020 at 3:19 PM Wolfgang Wallner
> <wolfgang.wallner at br-automation.com> wrote:
> >
> > Hi Andy,
> >
> > > -----"Andy Shevchenko" <andy.shevchenko at gmail.com> schrieb: -----
> > > On Mon, Feb 3, 2020 at 12:38 PM Wolfgang Wallner
> > > <wolfgang.wallner at br-automation.com> wrote:
> > > >
> > > >
> > > > This series fixes some issues in the Intel gpio driver.
> > > > I have tested it on an Apollo Lake device, where U-Boot is booted as a
> > > > coreboot payload.
> > > >
> >
> > > When you send series, be sure you put all maintainers (not me, but
> > > like Bin) to *all* patches in it.
> >
> > I can't follow you.
> > I have used the following configuration for patman:
> >
> >   Series-to: u-boot
> >   Series-cc: bmeng, sjg
> >
> > And according to my local mail client all patches in this series have
> > been sent with this configuration (U-Boot mailing list as receiver,
> > Bin Meng and Simon Glass as CC).
> >
> > Does it look different for you?
>
> Yes, for example for this mail (initial cover letter above) I see only
> ML in To and none in Cc.
>
> from: Wolfgang Wallner <wolfgang.wallner at br-automation.com> via lists.denx.de
> to: u-boot at lists.denx.de
> date: Feb 3, 2020, 12:38 PM
> subject: [PATCH v2 0/3] gpio: intel_gpio: Fix Intel gpio driver
> mailing list: u-boot at lists.denx.de Filter messages from this mailing list
> mailed-by: lists.denx.de
> unsubscribe: Unsubscribe from this mailing list
> security:  Standard encryption (TLS) Learn more

I can see both Simon and me are cc'ed.

From: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
To: u-boot at lists.denx.de
Cc: Simon Glass <sjg at chromium.org>, Bin Meng <bmeng.cn at gmail.com>,
Wolfgang Wallner <wolfgang.wallner at br-automation.com>
Subject: [PATCH v2 0/3] gpio: intel_gpio: Fix Intel gpio driver
Date: Mon, 3 Feb 2020 11:38:03 +0100
Message-Id: <20200203103806.29445-1-wolfgang.wallner at br-automation.com>

Regards,
Bin
Andy Shevchenko Feb. 3, 2020, 2:28 p.m. UTC | #5 
On Mon, Feb 3, 2020 at 4:27 PM Bin Meng <bmeng.cn at gmail.com> wrote:
> On Mon, Feb 3, 2020 at 10:17 PM Andy Shevchenko
> <andy.shevchenko at gmail.com> wrote:
> > On Mon, Feb 3, 2020 at 3:19 PM Wolfgang Wallner
> > <wolfgang.wallner at br-automation.com> wrote:

...

> > > Does it look different for you?
> >
> > Yes, for example for this mail (initial cover letter above) I see only
> > ML in To and none in Cc.
> >
> > from: Wolfgang Wallner <wolfgang.wallner at br-automation.com> via lists.denx.de
> > to: u-boot at lists.denx.de
> > date: Feb 3, 2020, 12:38 PM
> > subject: [PATCH v2 0/3] gpio: intel_gpio: Fix Intel gpio driver
> > mailing list: u-boot at lists.denx.de Filter messages from this mailing list
> > mailed-by: lists.denx.de
> > unsubscribe: Unsubscribe from this mailing list
> > security:  Standard encryption (TLS) Learn more
>
> I can see both Simon and me are cc'ed.

Okay, that means Gmail is somehow broken. :-(

> From: Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> To: u-boot at lists.denx.de
> Cc: Simon Glass <sjg at chromium.org>, Bin Meng <bmeng.cn at gmail.com>,
> Wolfgang Wallner <wolfgang.wallner at br-automation.com>
> Subject: [PATCH v2 0/3] gpio: intel_gpio: Fix Intel gpio driver
> Date: Mon, 3 Feb 2020 11:38:03 +0100
> Message-Id: <20200203103806.29445-1-wolfgang.wallner at br-automation.com>