| Message ID | 20200226081439.15994-1-faiz_abbas@ti.com |
|---|---|
| Headers | show |
| Series | Add Support for eMMC boot in AM65x and J721e | expand |
Hi Faiz, On 2/26/20 5:14 PM, Faiz Abbas wrote: > The following patches add support for eMMC boot in TI's Am65x and J721e > devices. About adding deferred_probe(), i want to know Peng's opinion. But it's my preference. I will review about your series. Thanks for accepting my suggestion. Best Regards, Jaehoon Chung > > v3: > 1. Added a patch to fix a clash between two dummy clocks of the same > name in k3-j721e-r5-common-proc-board.dtb > 2. Converted the init() API patch to two patches adding deferred_probe() > APIs to the mmc core and sdhci layers respectively. > 3. Fixed up config_pm_pre_callback() call order in patch 9. > > v2: > 1. Reordered the patches according to Lokesh's preference > 2. Fixed patch 2 breaking platforms where DM_MMC is not enabled. > > Faiz Abbas (11): > mmc: Add a saved_clock member > mmc: Add a deferred_probe() API > sdhci: Add sdhci_deferred_probe() API > mmc: Merge SD_LEGACY and MMC_LEGACY bus modes > mmc: am654_sdhci: Update output tap delay writes > mmc: am654_sdhci: Implement workaround for card detect > spl: mmc: Fix spl_mmc_get_uboot_raw_sector() implementation > arm: K3: sysfw-loader: Add a config_pm_pre_callback() > arm: dts: k3-j721e-r5-common-proc-board: Use unique names for dummy > clocks > configs: am65x_evm: Add CONFIG_SUPPORT_EMMC_BOOT > configs: j721e_evm: Add Support for eMMC boot > > arch/arm/dts/k3-am65-main.dtsi | 12 +- > arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 11 +- > arch/arm/dts/k3-j721e-main.dtsi | 15 +- > .../arm/dts/k3-j721e-r5-common-proc-board.dts | 4 +- > arch/arm/mach-imx/imx8/image.c | 3 +- > arch/arm/mach-k3/am6_init.c | 33 +++- > arch/arm/mach-k3/include/mach/sysfw-loader.h | 2 +- > arch/arm/mach-k3/j721e_init.c | 33 +++- > arch/arm/mach-k3/sysfw-loader.c | 6 +- > common/spl/spl_mmc.c | 11 +- > configs/am65x_evm_a53_defconfig | 1 + > configs/am65x_evm_r5_defconfig | 1 + > configs/j721e_evm_a72_defconfig | 3 + > configs/j721e_evm_r5_defconfig | 3 + > drivers/mmc/am654_sdhci.c | 173 +++++++++++++----- > drivers/mmc/fsl_esdhc_imx.c | 1 - > drivers/mmc/mmc-uclass.c | 15 ++ > drivers/mmc/mmc.c | 20 +- > drivers/mmc/omap_hsmmc.c | 1 - > drivers/mmc/sdhci.c | 15 ++ > drivers/mmc/zynq_sdhci.c | 1 - > include/configs/am65x_evm.h | 2 - > include/mmc.h | 12 +- > include/sdhci.h | 1 + > 24 files changed, 298 insertions(+), 81 deletions(-) >
Peng, On 26/02/20 4:31 pm, Jaehoon Chung wrote: > Hi Faiz, > > On 2/26/20 5:14 PM, Faiz Abbas wrote: >> The following patches add support for eMMC boot in TI's Am65x and J721e >> devices. > > About adding deferred_probe(), i want to know Peng's opinion. > But it's my preference. I will review about your series. > Thanks for accepting my suggestion. > Any feedback? Can you pick these patches up for next? Thanks, Faiz
> Subject: Re: [PATCH v3 00/11] Add Support for eMMC boot in AM65x and > J721e > > Peng, > > On 26/02/20 4:31 pm, Jaehoon Chung wrote: > > Hi Faiz, > > > > On 2/26/20 5:14 PM, Faiz Abbas wrote: > >> The following patches add support for eMMC boot in TI's Am65x and > >> J721e devices. > > > > About adding deferred_probe(), i want to know Peng's opinion. > > But it's my preference. I will review about your series. > > Thanks for accepting my suggestion. > > > > Any feedback? Can you pick these patches up for next? When first glance to deferred_probe, I thought it behaviors as Linux defer probe :) I am ok with this series. I need run a CI for this series, then send pull request to Tom's next tree. Should be tomorrow, if no concern or issues Regards, Peng. > > Thanks, > Faiz
On 3/5/20 8:00 PM, Peng Fan wrote: >> Subject: Re: [PATCH v3 00/11] Add Support for eMMC boot in AM65x and >> J721e >> >> Peng, >> >> On 26/02/20 4:31 pm, Jaehoon Chung wrote: >>> Hi Faiz, >>> >>> On 2/26/20 5:14 PM, Faiz Abbas wrote: >>>> The following patches add support for eMMC boot in TI's Am65x and >>>> J721e devices. >>> >>> About adding deferred_probe(), i want to know Peng's opinion. >>> But it's my preference. I will review about your series. >>> Thanks for accepting my suggestion. >>> >> >> Any feedback? Can you pick these patches up for next? > > When first glance to deferred_probe, I thought it behaviors > as Linux defer probe :) > > I am ok with this series. I need run a CI for this series, then > send pull request to Tom's next tree. Should be tomorrow, > if no concern or issues Sounds good. I'm not still checking fully. But looks good to me. Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com> Best Regards, Jaehoon Chung > > Regards, > Peng. >> >> Thanks, >> Faiz
The following patches add support for eMMC boot in TI's Am65x and J721e devices. v3: 1. Added a patch to fix a clash between two dummy clocks of the same name in k3-j721e-r5-common-proc-board.dtb 2. Converted the init() API patch to two patches adding deferred_probe() APIs to the mmc core and sdhci layers respectively. 3. Fixed up config_pm_pre_callback() call order in patch 9. v2: 1. Reordered the patches according to Lokesh's preference 2. Fixed patch 2 breaking platforms where DM_MMC is not enabled. Faiz Abbas (11): mmc: Add a saved_clock member mmc: Add a deferred_probe() API sdhci: Add sdhci_deferred_probe() API mmc: Merge SD_LEGACY and MMC_LEGACY bus modes mmc: am654_sdhci: Update output tap delay writes mmc: am654_sdhci: Implement workaround for card detect spl: mmc: Fix spl_mmc_get_uboot_raw_sector() implementation arm: K3: sysfw-loader: Add a config_pm_pre_callback() arm: dts: k3-j721e-r5-common-proc-board: Use unique names for dummy clocks configs: am65x_evm: Add CONFIG_SUPPORT_EMMC_BOOT configs: j721e_evm: Add Support for eMMC boot arch/arm/dts/k3-am65-main.dtsi | 12 +- arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 11 +- arch/arm/dts/k3-j721e-main.dtsi | 15 +- .../arm/dts/k3-j721e-r5-common-proc-board.dts | 4 +- arch/arm/mach-imx/imx8/image.c | 3 +- arch/arm/mach-k3/am6_init.c | 33 +++- arch/arm/mach-k3/include/mach/sysfw-loader.h | 2 +- arch/arm/mach-k3/j721e_init.c | 33 +++- arch/arm/mach-k3/sysfw-loader.c | 6 +- common/spl/spl_mmc.c | 11 +- configs/am65x_evm_a53_defconfig | 1 + configs/am65x_evm_r5_defconfig | 1 + configs/j721e_evm_a72_defconfig | 3 + configs/j721e_evm_r5_defconfig | 3 + drivers/mmc/am654_sdhci.c | 173 +++++++++++++----- drivers/mmc/fsl_esdhc_imx.c | 1 - drivers/mmc/mmc-uclass.c | 15 ++ drivers/mmc/mmc.c | 20 +- drivers/mmc/omap_hsmmc.c | 1 - drivers/mmc/sdhci.c | 15 ++ drivers/mmc/zynq_sdhci.c | 1 - include/configs/am65x_evm.h | 2 - include/mmc.h | 12 +- include/sdhci.h | 1 + 24 files changed, 298 insertions(+), 81 deletions(-)