| Message ID | 20200506191459.10668-1-michael@walle.cc |
|---|---|
| Headers | show |
| Series | phy: atheros: dt bindings and cleanup | expand |
Am 2020-05-06 21:14, schrieb Michael Walle: > This patch series superseeds the following two: > From Vladimir Oltean > https://patchwork.ozlabs.org/cover/1031360/ > From me: > https://patchwork.ozlabs.org/cover/1184507/ > > Although the first is marked as accepted into u-boot-net I guess it was > removed due to broken boards ("DT as ABI", RGMII delay was fixed and > thus > breaks the board). > > After disussing with Vladimir, I've integrated his patches with this > series. Also the first one > Address packet drops at low traffic rate due to SmartEEE feature > was dropped because it will likely be fixed by making u-boot support > the > eee-broken-X device tree properties. Apart from that, only the subject > was > changed and a note about possible board breakage was added the patch > which > changes the delay behaviour. > > For all of those, who will test this patchset, the device tree binding > needs the phydev->node property, which needs to be set in every network > driver. If the device tree binding is not working for you have a look > at > the > ar803x_of_init: found PHY node: phy at 0 > output. In the case above "phy at 0" is the phy node in the device tree. > If > instead the node of your network device is displayed, you have to set > the phydev->node property in your network device driver. > > For the fsl_enetc driver this patchset will add it: > https://patchwork.ozlabs.org/cover/1188043/ > > changes since v2: > - rebased onto latest master, esp. #include <dm/device_compat.h> > > changes since v1: > - pull all Vladimirs Oltan's patches and rebase mine onto them > - fix the CLK_25M settings for the AR8035 > - add two new patches "fix AR8021 PHY ID mask" and "use defines for > PHY > IDs" > - use the new kernel device tree binding for the AR803x PHYs: > https://patchwork.ozlabs.org/patch/1188293/ > - add debugging output > > Michael Walle (7): > phy: atheros: fix AR8021 PHY ID mask > phy: atheros: use defines for PHY IDs > phy: atheros: introduce debug read and write functions > phy: atheros: move delay config to common function > phy: atheros: add device tree bindings and config > phy: atheros: ar8035: remove static clock config > phy: atheros: consolidate {ar8031|ar8035}_config() Oh I've actually forgot the "Acked-by:" from Joe from the v2 series. All but the > phy: atheros: fix AR8021 PHY ID mask were acked by Joe. Tom, should I send a v4 where I drop that patch and could you pull this series? -michael > > Vladimir Oltean (5): > phy: atheros: Make RGMII Tx delays actually configurable for AR8035 > phy: atheros: Use common functions for RGMII internal delays > phy: atheros: Clarify the configuration of the CLK_25M output pin > phy: atheros: Explicitly disable RGMII delays > phy: atheros: Clarify the intention of ar8021_config > > doc/device-tree-bindings/net/phy/atheros.txt | 35 ++ > drivers/net/phy/atheros.c | 350 ++++++++++++++++--- > include/dt-bindings/net/qca-ar803x.h | 13 + > 3 files changed, 345 insertions(+), 53 deletions(-) > create mode 100644 doc/device-tree-bindings/net/phy/atheros.txt > create mode 100644 include/dt-bindings/net/qca-ar803x.h
On Wed, May 06, 2020 at 09:47:10PM +0200, Michael Walle wrote: > Am 2020-05-06 21:14, schrieb Michael Walle: > > This patch series superseeds the following two: > > From Vladimir Oltean > > https://patchwork.ozlabs.org/cover/1031360/ > > From me: > > https://patchwork.ozlabs.org/cover/1184507/ > > > > Although the first is marked as accepted into u-boot-net I guess it was > > removed due to broken boards ("DT as ABI", RGMII delay was fixed and > > thus > > breaks the board). > > > > After disussing with Vladimir, I've integrated his patches with this > > series. Also the first one > > Address packet drops at low traffic rate due to SmartEEE feature > > was dropped because it will likely be fixed by making u-boot support the > > eee-broken-X device tree properties. Apart from that, only the subject > > was > > changed and a note about possible board breakage was added the patch > > which > > changes the delay behaviour. > > > > For all of those, who will test this patchset, the device tree binding > > needs the phydev->node property, which needs to be set in every network > > driver. If the device tree binding is not working for you have a look at > > the > > ar803x_of_init: found PHY node: phy at 0 > > output. In the case above "phy at 0" is the phy node in the device tree. If > > instead the node of your network device is displayed, you have to set > > the phydev->node property in your network device driver. > > > > For the fsl_enetc driver this patchset will add it: > > https://patchwork.ozlabs.org/cover/1188043/ > > > > changes since v2: > > - rebased onto latest master, esp. #include <dm/device_compat.h> > > > > changes since v1: > > - pull all Vladimirs Oltan's patches and rebase mine onto them > > - fix the CLK_25M settings for the AR8035 > > - add two new patches "fix AR8021 PHY ID mask" and "use defines for PHY > > IDs" > > - use the new kernel device tree binding for the AR803x PHYs: > > https://patchwork.ozlabs.org/patch/1188293/ > > - add debugging output > > > > Michael Walle (7): > > phy: atheros: fix AR8021 PHY ID mask > > phy: atheros: use defines for PHY IDs > > phy: atheros: introduce debug read and write functions > > phy: atheros: move delay config to common function > > phy: atheros: add device tree bindings and config > > phy: atheros: ar8035: remove static clock config > > phy: atheros: consolidate {ar8031|ar8035}_config() > > Oh I've actually forgot the "Acked-by:" from Joe from the v2 series. > > All but the > > phy: atheros: fix AR8021 PHY ID mask > were acked by Joe. > > Tom, should I send a v4 where I drop that patch and could you pull > this series? Yes please, sounds like a plan, thanks for the explanation!