mbox series

[0/3] mkimage usability fixes

Message ID 20201111111833.741937-1-joel@jms.id.au
Headers show
Series mkimage usability fixes | expand

Message

Joel Stanley Nov. 11, 2020, 11:18 a.m. UTC 
Hello,

I was learning about signed FIT today and was unable to convince mkimage
to produce a signature node in my control device tree. It turns out that
Debian's packaged mkimage doesn't enable FIT_SIGNATURE, so the options I
was passing were silently ignored.

There's an existing Debian bug for that[1] but in the mean time this
changes mkimage's behaviour to fail loudly when FIT_SIGNATURE is
disabled.

The first two patches fix some issues I found when testing the third
patch under sandbox_defconfig with FIT_SIGNATURE=n.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=972513

Joel Stanley (3):
  tools/Makefile: FIT_CIPHER requires libssl
  image-cipher: Fix FIT_CIPHER linking
  mkimge: Reject signing-related flags without FIT_SIGNATURE

 common/image-cipher.c | 14 ++++++++++++++
 tools/Makefile        |  2 +-
 tools/mkimage.c       |  9 +++++++--
 3 files changed, 22 insertions(+), 3 deletions(-)

-- 
2.28.0