| Message ID | 20231207091850.17776-1-ilias.apalodimas@linaro.org |
|---|---|
| Headers | show |
| Series | Provide a fallback to smbios tables | expand |
Hi Heinrich, On Mon, 18 Dec 2023 at 10:11, Heinrich Schuchardt <heinrich.schuchardt@gmx.de> wrote: > > On 12/7/23 10:18, Ilias Apalodimas wrote: > > Hi, > > > > This is v3 of the smbios series [0]. > > v3 has a bigger cleanup in the existing smbios code, folding in > > smbios_add_string() that were sprinkled around to smbios_add_prop(). > > > > The latter is now the only caller of smbios_add_string(). > > > > Simon asked for a selftest which makes sense, but we plan to refactor some > > of the smbios creation code anyway. I am happy to add tests once we do that > > > > I've also removed the r-b tags from Peter and Tom, since some of the code > > they reviewed changed. > > QEMU provides SMBIOS tables for x86, ARM, and Longsoon. I have just sent > a patch QEMU upstream to add the missing SMBIOS support on RISC-V. > > Like we do for ACPI on QEMU we should not rely on the device-tree to > build U-Boot specific SMBIOS tables but we should forward what QEMU > provides. > > This can be done after the current patch series. Fair enough. I'll add it to my backlog Thanks /Ilias > > Best regards > > Heinrich
On Thu, Dec 07, 2023 at 11:18:48AM +0200, Ilias Apalodimas wrote: > Hi, > > This is v3 of the smbios series [0]. > v3 has a bigger cleanup in the existing smbios code, folding in > smbios_add_string() that were sprinkled around to smbios_add_prop(). > > The latter is now the only caller of smbios_add_string(). > > Simon asked for a selftest which makes sense, but we plan to refactor some > of the smbios creation code anyway. I am happy to add tests once we do that > > I've also removed the r-b tags from Peter and Tom, since some of the code > they reviewed changed. > > [0] https://lore.kernel.org/u-boot/20231127171058.165777-1-ilias.apalodimas@linaro.org/ > Ilias Apalodimas (2): > smbios: Simplify reporting of unknown values > smbios: Fallback to the default DT if sysinfo nodes are missing > > lib/smbios.c | 163 ++++++++++++++++++++++++++++++++++++++------------- > 1 file changed, 122 insertions(+), 41 deletions(-) With the understanding that tests will be added "soon" as well as any reasonable cleanup of the code (along with adding features like chassis-type being added), I've applied the series to u-boot/next now.