| Message ID | 20241106124215.677519-1-andrew.goodbody@linaro.org |
|---|---|
| Headers | show |
| Series | Select CONFIG_64BIT for sandbox64 and x86_64 | expand |
Thanks, Andrew! regards, dan carpenter
On Wed, Nov 06, 2024 at 12:42:13PM +0000, Andrew Goodbody wrote: > Picking up a series from Dan Carpenter and applying requested > changes for v2. > > I had previously set CONFIG_64BIT for arm64. This patchset does the > same thing for sandbox64 and x86_64. (Mips and riscv were already > doing it). This CONFIG option is used in the Makefile to determine > if it's a 32 or 64 bit system for the CHECKER. > > Makefile > 1052 # the checker needs the correct machine size > 1053 CHECKFLAGS += $(if $(CONFIG_64BIT),-m64,-m32) > > Changes in v2: > Resubmitted by Andrew Goodbody with changes requested by reviewer > > Andrew Goodbody (2): > sandbox: select CONFIG_64BIT for SANDBOX64 > x86: select CONFIG_64BIT for X86_64 > > arch/sandbox/Kconfig | 1 + > arch/x86/Kconfig | 1 + > 2 files changed, 2 insertions(+) Unfortunately this leads to various CI failures: https://source.denx.de/u-boot/u-boot/-/pipelines/23345 Azure would show them too, but I cancelled the pipeline to free up the queue. Please see https://docs.u-boot.org/en/latest/develop/ci_testing.html if needed for how to get Azure runs done. Also on a related note, can you please update test/lib/str.c to use CONFIG_64BIT and not CONFIG_PHYS_64BIT while you're doing these kind of corrections? Thanks!
On 13/11/2024 21:53, Tom Rini wrote: > On Wed, Nov 06, 2024 at 12:42:13PM +0000, Andrew Goodbody wrote: > >> Picking up a series from Dan Carpenter and applying requested >> changes for v2. >> >> I had previously set CONFIG_64BIT for arm64. This patchset does the >> same thing for sandbox64 and x86_64. (Mips and riscv were already >> doing it). This CONFIG option is used in the Makefile to determine >> if it's a 32 or 64 bit system for the CHECKER. >> >> Makefile >> 1052 # the checker needs the correct machine size >> 1053 CHECKFLAGS += $(if $(CONFIG_64BIT),-m64,-m32) >> >> Changes in v2: >> Resubmitted by Andrew Goodbody with changes requested by reviewer >> >> Andrew Goodbody (2): >> sandbox: select CONFIG_64BIT for SANDBOX64 >> x86: select CONFIG_64BIT for X86_64 >> >> arch/sandbox/Kconfig | 1 + >> arch/x86/Kconfig | 1 + >> 2 files changed, 2 insertions(+) > > Unfortunately this leads to various CI failures: > https://source.denx.de/u-boot/u-boot/-/pipelines/23345 > Azure would show them too, but I cancelled the pipeline to free up the > queue. Please see > https://docs.u-boot.org/en/latest/develop/ci_testing.html if needed for > how to get Azure runs done. Also on a related note, can you please > update test/lib/str.c to use CONFIG_64BIT and not CONFIG_PHYS_64BIT > while you're doing these kind of corrections? Thanks! > I am about to send v3 of this series. Passing CI run at https://github.com/u-boot/u-boot/pull/696 Andrew