| Message ID | 20250303133231.405279-1-sughosh.ganu@linaro.org |
|---|---|
| Headers | show |
| Series | lmb: miscellaneous fixes and improvements | expand |
On Mon, 03 Mar 2025 19:02:25 +0530, Sughosh Ganu wrote: > The patch series contains some fixes and improvements in the lmb > code, along with addition of corresponding test cases for the changes > made. > > The lmb_reserve() function currently does not check if the requested > reservation would overlap with existing reserved regions. While some > scenarios are being handled, some corner cases still exist. These are > being handled by patch 1, along with adding test cases for these > scenarios. > > [...] Applied to u-boot/next, thanks! [1/6] lmb: check if a region can be reserved by lmb_reserve() commit: 56f186a68b35e8b45136fd44b69c554a0bb0ce35 [2/6] lmb: handle scenario of encompassing overlap commit: e0a7ea3725d8931a2c31f29ed665ec1f22e37172 [3/6] lmb: check for a region's coalescing with all existing regions commit: 6e4df5886d27cff043561c8087f373e26cfe9f34 [4/6] lmb: remove superfluous address overlap check from lmb_add_region_flags() commit: f5f0a0287134223c16ce64303df60c3708684e6a [5/6] lmb: use a common function to check if regions overlap or are adjacent commit: fa5b4f5a5f99d1f4ab995d07845d2bff50aaabb7 [6/6] lmb: optimise the lmb allocation functions commit: 2bf5811e22efffe37bf5dccb8d13529c51fc65dd
The patch series contains some fixes and improvements in the lmb code, along with addition of corresponding test cases for the changes made. The lmb_reserve() function currently does not check if the requested reservation would overlap with existing reserved regions. While some scenarios are being handled, some corner cases still exist. These are being handled by patch 1, along with adding test cases for these scenarios. Patch 2 is handling the case of reserving a new region of memory, but that region overlaps with an existing region. The current code only handles one particular scenario, but prints a message for the other scenario of an encompassing overlap and returns back. The patch handles the encompassing overlap. Patch 3 is an improvement whereby we allow coalescing a newly reserved region with an existing region. The current code exits this check prematurely. Patch 4 is removing a now superfluous check for overlapping regions with flag other than LMB_NONE. This now gets handled at an earlier point in lmb_reserve(). Patch 5 is clubbing the functionality to check if two regions are adjacent, or overlap, allowing some code re-use. Patch 6 is optimising the lmb_alloc() function by having it call _lmb_alloc_base() directly. Changes since V2: * Add more description to the commit message on the logic behind this change (patch 4) * Change the print for allocation failure into a debug message as per suggestion from Heinrich Sughosh Ganu (6): lmb: check if a region can be reserved by lmb_reserve() lmb: handle scenario of encompassing overlap lmb: check for a region's coalescing with all existing regions lmb: remove superfluous address overlap check from lmb_add_region_flags() lmb: use a common function to check if regions overlap or are adjacent lmb: optimise the lmb allocation functions lib/lmb.c | 140 +++++++++++++++++++++++++++++-------------------- test/lib/lmb.c | 114 ++++++++++++++++++++++++++++++++++++++-- 2 files changed, 194 insertions(+), 60 deletions(-)