| Message ID | 20250314215525.579655-1-jerome.forissier@linaro.org |
|---|---|
| Headers | show |
| Series | lwIP sandbox tests | expand |
Hi Simon, Any feedback on this series? https://patchwork.ozlabs.org/project/uboot/list/?series=448553 Thanks,
Hi Jerome, On Tue, 1 Apr 2025 at 03:14, Jerome Forissier <jerome.forissier@linaro.org> wrote: > > Hi Simon, > > Any feedback on this series? > > https://patchwork.ozlabs.org/project/uboot/list/?series=448553 No, not from me, but thanks for doing it! Regards, SImon > > Thanks, > > -- > Jerome > > On 3/14/25 22:55, Jerome Forissier wrote: > > This series enables most of the driver model tests for network features > > with NET_LWIP (test/dm/eth.c and test/dm/dsa.c). > > - Patches 1-5 fix a few bugs (device selection) and add missing features > > (sandbox timer, restart support) to NET_LWIP > > - Patch 6 decouples the sandbox ethernet driver from NET > > - Patch 7 adds missing static IP addresses that NET_LWIP needs > > - Patches 8 and 9 update the tests to use a common interface to send > > ICMP packets (do_ping(...) instead of net_loop(PING)) > > - Patch 10 enables DM_DSA and the associated tests with NET_LWIP > > - Patch 11 adds a sandbox64 configuration with NET_LWIP=y > > - Patch 12 adds that configuration to the CI > > > > Jerome Forissier (12): > > net: lwip: do_ping() should return CMD_RET_FAILURE when no device > > net: lwip: fix initialization sequence before a command > > net: lwip: provide net_start_again() > > net: lwip: add restart support to ping > > net: lwip: use timer_early_get_count() when CONFIG_SANDBOX_TIMER=y > > drivers: net: sandbox: add support for NET_LWIP > > sandbox: provide static IP addresses for eth{2,3,5,6,7} > > net: ping: make do_ping() available via <net.h> > > test: dm: eth, dsa: update tests for NET_LWIP > > net: lwip: allow DM_DSA=y when NET_LWIP=y > > configs: add sandbox64_lwip_defconfig > > CI: add sandbox64_lwip > > > > .azure-pipelines.yml | 2 + > > .gitlab-ci.yml | 11 ++ > > board/sandbox/sandbox.env | 5 + > > cmd/net.c | 3 +- > > configs/sandbox64_lwip_defconfig | 5 + > > drivers/net/Kconfig | 14 +- > > drivers/net/Makefile | 1 - > > drivers/net/sandbox-lwip.c | 85 ----------- > > drivers/net/sandbox.c | 240 ++++++++++++++++++++----------- > > include/net-common.h | 15 ++ > > include/net-legacy.h | 3 - > > include/net-lwip.h | 10 +- > > net/Makefile | 2 +- > > net/lwip/dhcp.c | 3 +- > > net/lwip/dns.c | 3 +- > > net/lwip/net-lwip.c | 86 +++++++++-- > > net/lwip/ping.c | 13 +- > > net/lwip/tftp.c | 5 +- > > net/lwip/wget.c | 6 +- > > test/dm/Makefile | 2 - > > test/dm/dsa.c | 8 +- > > test/dm/eth.c | 77 +++++----- > > 22 files changed, 351 insertions(+), 248 deletions(-) > > create mode 100644 configs/sandbox64_lwip_defconfig > > delete mode 100644 drivers/net/sandbox-lwip.c > >
Hi Simon On Tue, 1 Apr 2025 at 18:42, Simon Glass <sjg@chromium.org> wrote: > > Hi Jerome, > > On Tue, 1 Apr 2025 at 03:14, Jerome Forissier > <jerome.forissier@linaro.org> wrote: > > > > Hi Simon, > > > > Any feedback on this series? > > > > https://patchwork.ozlabs.org/project/uboot/list/?series=448553 > > No, not from me, but thanks for doing it! Aren't you maintaining the sandbox drivers? Thanks /Ilias > > Regards, > SImon > > > > > > Thanks, > > > > -- > > Jerome > > > > On 3/14/25 22:55, Jerome Forissier wrote: > > > This series enables most of the driver model tests for network features > > > with NET_LWIP (test/dm/eth.c and test/dm/dsa.c). > > > - Patches 1-5 fix a few bugs (device selection) and add missing features > > > (sandbox timer, restart support) to NET_LWIP > > > - Patch 6 decouples the sandbox ethernet driver from NET > > > - Patch 7 adds missing static IP addresses that NET_LWIP needs > > > - Patches 8 and 9 update the tests to use a common interface to send > > > ICMP packets (do_ping(...) instead of net_loop(PING)) > > > - Patch 10 enables DM_DSA and the associated tests with NET_LWIP > > > - Patch 11 adds a sandbox64 configuration with NET_LWIP=y > > > - Patch 12 adds that configuration to the CI > > > > > > Jerome Forissier (12): > > > net: lwip: do_ping() should return CMD_RET_FAILURE when no device > > > net: lwip: fix initialization sequence before a command > > > net: lwip: provide net_start_again() > > > net: lwip: add restart support to ping > > > net: lwip: use timer_early_get_count() when CONFIG_SANDBOX_TIMER=y > > > drivers: net: sandbox: add support for NET_LWIP > > > sandbox: provide static IP addresses for eth{2,3,5,6,7} > > > net: ping: make do_ping() available via <net.h> > > > test: dm: eth, dsa: update tests for NET_LWIP > > > net: lwip: allow DM_DSA=y when NET_LWIP=y > > > configs: add sandbox64_lwip_defconfig > > > CI: add sandbox64_lwip > > > > > > .azure-pipelines.yml | 2 + > > > .gitlab-ci.yml | 11 ++ > > > board/sandbox/sandbox.env | 5 + > > > cmd/net.c | 3 +- > > > configs/sandbox64_lwip_defconfig | 5 + > > > drivers/net/Kconfig | 14 +- > > > drivers/net/Makefile | 1 - > > > drivers/net/sandbox-lwip.c | 85 ----------- > > > drivers/net/sandbox.c | 240 ++++++++++++++++++++----------- > > > include/net-common.h | 15 ++ > > > include/net-legacy.h | 3 - > > > include/net-lwip.h | 10 +- > > > net/Makefile | 2 +- > > > net/lwip/dhcp.c | 3 +- > > > net/lwip/dns.c | 3 +- > > > net/lwip/net-lwip.c | 86 +++++++++-- > > > net/lwip/ping.c | 13 +- > > > net/lwip/tftp.c | 5 +- > > > net/lwip/wget.c | 6 +- > > > test/dm/Makefile | 2 - > > > test/dm/dsa.c | 8 +- > > > test/dm/eth.c | 77 +++++----- > > > 22 files changed, 351 insertions(+), 248 deletions(-) > > > create mode 100644 configs/sandbox64_lwip_defconfig > > > delete mode 100644 drivers/net/sandbox-lwip.c > > >
Hi Ilias, On Wed, 2 Apr 2025 at 05:33, Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote: > > Hi Simon > > On Tue, 1 Apr 2025 at 18:42, Simon Glass <sjg@chromium.org> wrote: > > > > Hi Jerome, > > > > On Tue, 1 Apr 2025 at 03:14, Jerome Forissier > > <jerome.forissier@linaro.org> wrote: > > > > > > Hi Simon, > > > > > > Any feedback on this series? > > > > > > https://patchwork.ozlabs.org/project/uboot/list/?series=448553 > > > > No, not from me, but thanks for doing it! > > Aren't you maintaining the sandbox drivers? Yes, I'm listed as maintainer for lots of things. What sort of feedback are you looking for? Regards. Simon
Hi Simon, On 4/1/25 19:55, Simon Glass wrote: > Hi Ilias, > > On Wed, 2 Apr 2025 at 05:33, Ilias Apalodimas > <ilias.apalodimas@linaro.org> wrote: >> >> Hi Simon >> >> On Tue, 1 Apr 2025 at 18:42, Simon Glass <sjg@chromium.org> wrote: >>> >>> Hi Jerome, >>> >>> On Tue, 1 Apr 2025 at 03:14, Jerome Forissier >>> <jerome.forissier@linaro.org> wrote: >>>> >>>> Hi Simon, >>>> >>>> Any feedback on this series? >>>> >>>> https://patchwork.ozlabs.org/project/uboot/list/?series=448553 >>> >>> No, not from me, but thanks for doing it! >> >> Aren't you maintaining the sandbox drivers? > > Yes, I'm listed as maintainer for lots of things. What sort of > feedback are you looking for? Well, you were pretty explicit that those tests were important to you ([1], [2] and especially [3]), so I was expecting some kind of review/ack on your part. The series is currently assigned to me in patchwork and I got zero comments, so I'm not sure what to do with it. Unless someone objects I will probably add it to my next PR to Tom for -next. [1] https://lists.denx.de/pipermail/u-boot/2025-February/581988.html [2] https://lists.denx.de/pipermail/u-boot/2025-March/582435.html [3] https://lists.denx.de/pipermail/u-boot/2025-March/583362.html Thanks,
Hi Jerome, On Wed, 2 Apr 2025 at 20:48, Jerome Forissier <jerome.forissier@linaro.org> wrote: > > Hi Simon, > > On 4/1/25 19:55, Simon Glass wrote: > > Hi Ilias, > > > > On Wed, 2 Apr 2025 at 05:33, Ilias Apalodimas > > <ilias.apalodimas@linaro.org> wrote: > >> > >> Hi Simon > >> > >> On Tue, 1 Apr 2025 at 18:42, Simon Glass <sjg@chromium.org> wrote: > >>> > >>> Hi Jerome, > >>> > >>> On Tue, 1 Apr 2025 at 03:14, Jerome Forissier > >>> <jerome.forissier@linaro.org> wrote: > >>>> > >>>> Hi Simon, > >>>> > >>>> Any feedback on this series? > >>>> > >>>> https://patchwork.ozlabs.org/project/uboot/list/?series=448553 > >>> > >>> No, not from me, but thanks for doing it! > >> > >> Aren't you maintaining the sandbox drivers? > > > > Yes, I'm listed as maintainer for lots of things. What sort of > > feedback are you looking for? > > Well, you were pretty explicit that those tests were important to > you ([1], [2] and especially [3]), so I was expecting some kind of > review/ack on your part. The series is currently assigned to me in > patchwork and I got zero comments, so I'm not sure what to do with > it. Unless someone objects I will probably add it to my next PR to > Tom for -next. OK, good. Yes you can add my review tag to the series: Reviewed-by: Simon Glass <sjg@chromium.org> Thanks again for doing this. > > [1] https://lists.denx.de/pipermail/u-boot/2025-February/581988.html > [2] https://lists.denx.de/pipermail/u-boot/2025-March/582435.html > [3] https://lists.denx.de/pipermail/u-boot/2025-March/583362.html Regards, Simon
On 4/2/25 21:22, Simon Glass wrote: > Hi Jerome, > > On Wed, 2 Apr 2025 at 20:48, Jerome Forissier > <jerome.forissier@linaro.org> wrote: >> >> Hi Simon, >> >> On 4/1/25 19:55, Simon Glass wrote: >>> Hi Ilias, >>> >>> On Wed, 2 Apr 2025 at 05:33, Ilias Apalodimas >>> <ilias.apalodimas@linaro.org> wrote: >>>> >>>> Hi Simon >>>> >>>> On Tue, 1 Apr 2025 at 18:42, Simon Glass <sjg@chromium.org> wrote: >>>>> >>>>> Hi Jerome, >>>>> >>>>> On Tue, 1 Apr 2025 at 03:14, Jerome Forissier >>>>> <jerome.forissier@linaro.org> wrote: >>>>>> >>>>>> Hi Simon, >>>>>> >>>>>> Any feedback on this series? >>>>>> >>>>>> https://patchwork.ozlabs.org/project/uboot/list/?series=448553 >>>>> >>>>> No, not from me, but thanks for doing it! >>>> >>>> Aren't you maintaining the sandbox drivers? >>> >>> Yes, I'm listed as maintainer for lots of things. What sort of >>> feedback are you looking for? >> >> Well, you were pretty explicit that those tests were important to >> you ([1], [2] and especially [3]), so I was expecting some kind of >> review/ack on your part. The series is currently assigned to me in >> patchwork and I got zero comments, so I'm not sure what to do with >> it. Unless someone objects I will probably add it to my next PR to >> Tom for -next. > > OK, good. Yes you can add my review tag to the series: > > Reviewed-by: Simon Glass <sjg@chromium.org> Cool, thanks! > > Thanks again for doing this. You're welcome. Regards,
This series enables most of the driver model tests for network features with NET_LWIP (test/dm/eth.c and test/dm/dsa.c). - Patches 1-5 fix a few bugs (device selection) and add missing features (sandbox timer, restart support) to NET_LWIP - Patch 6 decouples the sandbox ethernet driver from NET - Patch 7 adds missing static IP addresses that NET_LWIP needs - Patches 8 and 9 update the tests to use a common interface to send ICMP packets (do_ping(...) instead of net_loop(PING)) - Patch 10 enables DM_DSA and the associated tests with NET_LWIP - Patch 11 adds a sandbox64 configuration with NET_LWIP=y - Patch 12 adds that configuration to the CI Jerome Forissier (12): net: lwip: do_ping() should return CMD_RET_FAILURE when no device net: lwip: fix initialization sequence before a command net: lwip: provide net_start_again() net: lwip: add restart support to ping net: lwip: use timer_early_get_count() when CONFIG_SANDBOX_TIMER=y drivers: net: sandbox: add support for NET_LWIP sandbox: provide static IP addresses for eth{2,3,5,6,7} net: ping: make do_ping() available via <net.h> test: dm: eth, dsa: update tests for NET_LWIP net: lwip: allow DM_DSA=y when NET_LWIP=y configs: add sandbox64_lwip_defconfig CI: add sandbox64_lwip .azure-pipelines.yml | 2 + .gitlab-ci.yml | 11 ++ board/sandbox/sandbox.env | 5 + cmd/net.c | 3 +- configs/sandbox64_lwip_defconfig | 5 + drivers/net/Kconfig | 14 +- drivers/net/Makefile | 1 - drivers/net/sandbox-lwip.c | 85 ----------- drivers/net/sandbox.c | 240 ++++++++++++++++++++----------- include/net-common.h | 15 ++ include/net-legacy.h | 3 - include/net-lwip.h | 10 +- net/Makefile | 2 +- net/lwip/dhcp.c | 3 +- net/lwip/dns.c | 3 +- net/lwip/net-lwip.c | 86 +++++++++-- net/lwip/ping.c | 13 +- net/lwip/tftp.c | 5 +- net/lwip/wget.c | 6 +- test/dm/Makefile | 2 - test/dm/dsa.c | 8 +- test/dm/eth.c | 77 +++++----- 22 files changed, 351 insertions(+), 248 deletions(-) create mode 100644 configs/sandbox64_lwip_defconfig delete mode 100644 drivers/net/sandbox-lwip.c