From patchwork Thu Jun 19 20:52:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Rae X-Patchwork-Id: 32251 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f69.google.com (mail-pb0-f69.google.com [209.85.160.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id CCF64203F4 for ; Thu, 19 Jun 2014 20:52:34 +0000 (UTC) Received: by mail-pb0-f69.google.com with SMTP id uo5sf9825064pbc.0 for ; Thu, 19 Jun 2014 13:52:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=6lkzaJE6p4Y6S/7L3vLu/nkwWkwEIJyZeECgJvjEhkM=; b=JssVqOx7BpF02kJnUNoco7mMXshDUrR3ZV3Oo/po6WOdf8Iz8G0CX1SpFnySc5osWu GKizj7CTfC6AzQW3CN77TUx+TBTQeLvl8euU4qJvbZ84x5FMsCBKF4vSIs+Qsd7lwzZV bgxIDi42bSLvrMWE++WQ23KRc34lwXqU/WLndDsxk30esXmI1Ro4Yuaseb7NrLwolKRN 91i59GUMgHo5scnDZukDZjeNPl8Y9VMy/+MyooAV4eA1yp6kTq/hIhJhLnq/DmuNY2jT WYlfpu8CqWk/DiL4PnzJRzN4rzEjA6A874QIk6UI0sY/hjpO1QQpvUyhXjw+AQnZ9SUm Trag== X-Gm-Message-State: ALoCoQkdz3p/D3LqU6FV2DexGnlL6MEBi4USFmqSJDP72P7vxmxe5vkYZM5mgZ7a4ozvvE8qifxB X-Received: by 10.68.195.9 with SMTP id ia9mr3285387pbc.7.1403211154163; Thu, 19 Jun 2014 13:52:34 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.41.243 with SMTP id z106ls709410qgz.54.gmail; Thu, 19 Jun 2014 13:52:34 -0700 (PDT) X-Received: by 10.58.207.33 with SMTP id lt1mr177881vec.63.1403211154000; Thu, 19 Jun 2014 13:52:34 -0700 (PDT) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx.google.com with ESMTPS id c1si2951245vei.68.2014.06.19.13.52.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Jun 2014 13:52:33 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.173 as permitted sender) client-ip=209.85.128.173; Received: by mail-ve0-f173.google.com with SMTP id db11so2840811veb.18 for ; Thu, 19 Jun 2014 13:52:33 -0700 (PDT) X-Received: by 10.58.119.75 with SMTP id ks11mr6022087veb.20.1403211153918; Thu, 19 Jun 2014 13:52:33 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp390468vcb; Thu, 19 Jun 2014 13:52:33 -0700 (PDT) X-Received: by 10.180.89.233 with SMTP id br9mr9737105wib.14.1403211153074; Thu, 19 Jun 2014 13:52:33 -0700 (PDT) Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id a17si7183275wib.72.2014.06.19.13.52.32 for ; Thu, 19 Jun 2014 13:52:33 -0700 (PDT) Received-SPF: none (google.com: u-boot-bounces@lists.denx.de does not designate permitted sender hosts) client-ip=85.214.87.163; Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 84242A740F; Thu, 19 Jun 2014 22:52:26 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m0AUqSRCOUki; Thu, 19 Jun 2014 22:52:26 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6F64FA7411; Thu, 19 Jun 2014 22:52:10 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 394074B80F for ; Thu, 19 Jun 2014 22:52:02 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U4Nz5p4hkqW7 for ; Thu, 19 Jun 2014 22:52:00 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-gw1-out.broadcom.com (mail-gw1-out.broadcom.com [216.31.210.62]) by theia.denx.de (Postfix) with ESMTP id 81B3F4B812 for ; Thu, 19 Jun 2014 22:51:56 +0200 (CEST) X-IronPort-AV: E=Sophos;i="5.01,508,1400050800"; d="scan'208";a="35568139" Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw1-out.broadcom.com with ESMTP; 19 Jun 2014 14:09:56 -0700 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 19 Jun 2014 13:51:54 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.3.174.1; Thu, 19 Jun 2014 13:51:54 -0700 Received: from mail.broadcom.com (lbrmn-vmlnx03.ric.broadcom.com [10.136.4.105]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id EBDED9F9F7; Thu, 19 Jun 2014 13:51:53 -0700 (PDT) From: Steve Rae To: Rob Herring , Sebastian Siewior Date: Thu, 19 Jun 2014 13:52:08 -0700 Message-ID: <1403211128-19631-4-git-send-email-srae@broadcom.com> X-Mailer: git-send-email 1.8.5 In-Reply-To: <1403211128-19631-1-git-send-email-srae@broadcom.com> References: <1403211128-19631-1-git-send-email-srae@broadcom.com> MIME-Version: 1.0 Cc: Tom Rini , u-boot@lists.denx.de, Steve Rae , Pantelis Antoniou Subject: [U-Boot] [RFC PATCH 3/3] usb/gadget: fastboot: add support for flash command X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: srae@broadcom.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 - implement 'fastboot flash' for eMMC devices Signed-off-by: Steve Rae --- README | 10 ++++++++++ doc/README.android-fastboot | 5 +++-- drivers/usb/gadget/f_fastboot.c | 31 +++++++++++++++++++++++++++++++ 3 files changed, 44 insertions(+), 2 deletions(-) diff --git a/README b/README index 7129df8..73071fc 100644 --- a/README +++ b/README @@ -1600,6 +1600,16 @@ The following options need to be configured: downloads. This buffer should be as large as possible for a platform. Define this to the size available RAM for fastboot. + CONFIG_FASTBOOT_FLASH + The fastboot protocol includes a "flash" command for writing + the downloaded image to a non-volatile storage device. Define + this to enable the "fastboot flash" command. + + CONFIG_FASTBOOT_FLASH_MMC_DEV + The fastboot "flash" command requires addition information + regarding the non-volatile storage device. Define this to + the eMMC device that fastboot should use to store the image. + - Journaling Flash filesystem support: CONFIG_JFFS2_NAND, CONFIG_JFFS2_NAND_OFF, CONFIG_JFFS2_NAND_SIZE, CONFIG_JFFS2_NAND_DEV diff --git a/doc/README.android-fastboot b/doc/README.android-fastboot index f1d128c..f00fd41 100644 --- a/doc/README.android-fastboot +++ b/doc/README.android-fastboot @@ -6,8 +6,9 @@ Overview The protocol that is used over USB is described in README.android-fastboot-protocol in same directory. -The current implementation does not yet support the flash and erase -commands. +The current implementation does not yet support the erase +command, and there is minimal support for the flash command; +it only supports eMMC devices. Client installation =================== diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c index 9dd85b6..89c2d3e 100644 --- a/drivers/usb/gadget/f_fastboot.c +++ b/drivers/usb/gadget/f_fastboot.c @@ -19,6 +19,9 @@ #include #include #include +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV +#include +#endif #define FASTBOOT_VERSION "0.4" @@ -466,6 +469,28 @@ static void cb_boot(struct usb_ep *ep, struct usb_request *req) fastboot_tx_write_str("OKAY"); } +#ifdef CONFIG_FASTBOOT_FLASH +static void cb_flash(struct usb_ep *ep, struct usb_request *req) +{ + char *cmd = req->buf; + char response[RESPONSE_LEN]; + + strsep(&cmd, ":"); + if (!cmd) { + printf("%s: missing partition name\n", __func__); + fastboot_tx_write_str("FAILmissing partition name"); + return; + } + + strcpy(response, "FAILno flash device defined"); +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV + fb_mmc_flash_write(cmd, (void *)CONFIG_USB_FASTBOOT_BUF_ADDR, + download_bytes, response); +#endif + fastboot_tx_write_str(response); +} +#endif + struct cmd_dispatch_info { char *cmd; void (*cb)(struct usb_ep *ep, struct usb_request *req); @@ -485,6 +510,12 @@ static const struct cmd_dispatch_info cmd_dispatch_info[] = { .cmd = "boot", .cb = cb_boot, }, +#ifdef CONFIG_FASTBOOT_FLASH + { + .cmd = "flash", + .cb = cb_flash, + }, +#endif }; static void rx_handler_command(struct usb_ep *ep, struct usb_request *req)