diff mbox series

[2/2] mtd: nand: do not check R/B# for CMD_SET_FEATURES in nand_command(_lp)

Message ID 1505479499-2862-2-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit fe3fddfad71aa228eedcc78a58b34d056724b2c9
Headers show
Series [1/2] mtd: nand: do not check R/B# for CMD_READID in nand_command(_lp) | expand

Commit Message

Masahiro Yamada Sept. 15, 2017, 12:44 p.m. UTC 
Set Features (0xEF) command toggles the R/B# pin after 4 sub feature
parameters are written.

Currently, nand_command(_lp) calls chip->dev_ready immediately after
the address cycle because NAND_CMD_SET_FEATURES falls into default:
label.  No wait is needed at this point.

If you see nand_onfi_set_features(), R/B# is already cared by the
chip->waitfunc call.

[masahiro: import Linux commit c5d664aa5a4c4b257a54eb35045031630d105f49]

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---

 drivers/mtd/nand/nand_base.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Masahiro Yamada Oct. 15, 2017, 1:31 p.m. UTC | #1 
2017-09-15 21:44 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Set Features (0xEF) command toggles the R/B# pin after 4 sub feature
> parameters are written.
>
> Currently, nand_command(_lp) calls chip->dev_ready immediately after
> the address cycle because NAND_CMD_SET_FEATURES falls into default:
> label.  No wait is needed at this point.
>
> If you see nand_onfi_set_features(), R/B# is already cared by the
> chip->waitfunc call.
>
> [masahiro: import Linux commit c5d664aa5a4c4b257a54eb35045031630d105f49]
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---


Scott is silent, but this patch was accepted in Linux.

Applied to u-boot-uniphier.
diff mbox series

Patch

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 776c20f..a95134c 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -652,6 +652,7 @@  static void nand_command(struct mtd_info *mtd, unsigned int command,
 	case NAND_CMD_SEQIN:
 	case NAND_CMD_STATUS:
 	case NAND_CMD_READID:
+	case NAND_CMD_SET_FEATURES:
 		return;
 
 	case NAND_CMD_RESET:
@@ -750,6 +751,7 @@  static void nand_command_lp(struct mtd_info *mtd, unsigned int command,
 	case NAND_CMD_RNDIN:
 	case NAND_CMD_STATUS:
 	case NAND_CMD_READID:
+	case NAND_CMD_SET_FEATURES:
 		return;
 
 	case NAND_CMD_RESET: