From patchwork Thu Jul 2 17:31:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philippe REYNES X-Patchwork-Id: 240657 List-Id: U-Boot discussion From: philippe.reynes at softathome.com (Philippe Reynes) Date: Thu, 2 Jul 2020 19:31:29 +0200 Subject: [PATCH] lib: libfdt: fdt_region: avoid NULL pointer access Message-ID: <1593711089-9494-1-git-send-email-philippe.reynes@softathome.com> The function fdt_find_regions look in the exclude list for each property, even if the name is NULL. It could happen if the fit image is corrupted. On sandbox, it generates a segfault. To avoid this issue, if the name of a property is NULL, we report an error and avoid looking in the exclude list. Signed-off-by: Philippe Reynes Reviewed-by: Simon Glass --- common/fdt_region.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/fdt_region.c b/common/fdt_region.c index 6676590..ff12c51 100644 --- a/common/fdt_region.c +++ b/common/fdt_region.c @@ -65,6 +65,8 @@ int fdt_find_regions(const void *fdt, char * const inc[], int inc_count, stop_at = offset; prop = fdt_get_property_by_offset(fdt, offset, NULL); str = fdt_string(fdt, fdt32_to_cpu(prop->nameoff)); + if (!str) + return -FDT_ERR_BADSTRUCTURE; if (str_in_list(str, exc_prop, exc_prop_count)) include = 0; break;