[15/17] efi_loader: file: support creating a directory

Message ID	20180720025723.6736-16-takahiro.akashi@linaro.org
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; From: AKASHI Takahiro <takahiro.akashi@linaro.org> To: trini@konsulko.com Date: Fri, 20 Jul 2018 11:57:21 +0900 Message-Id: <20180720025723.6736-16-takahiro.akashi@linaro.org> In-Reply-To: <20180720025723.6736-1-takahiro.akashi@linaro.org> References: <20180720025723.6736-1-takahiro.akashi@linaro.org> Cc: u-boot@lists.denx.de, xypron.glpk@gmx.de, agraf@suse.de Subject: [U-Boot] [PATCH 15/17] efi_loader: file: support creating a directory Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	fs: fat: extend FAT write operations \| expand [00/17] fs: fat: extend FAT write operations [01/17] fs: fat: extend get_fs_info() for write use [02/17] fs: fat: handle "." and ".." of root dir correctly with fat_itr_resolve() [03/17] fs: fat: make directory iterator global for write use [04/17] fs: fat: assure iterator's ->dent belongs to ->clust [05/17] fs: fat: check and normailze file name [06/17] fs: fat: write returns error code instead of -1 [07/17] fs: fat: support write with sub-directory path [08/17] fs: fat: refactor write interface for a file offset [09/17] fs: fat: support write with non-zero offset [10/17] cmd: fat: add offset parameter to fatwrite [11/17] fs: add mkdir interface [12/17] fs: fat: remember the starting cluster number of directory [13/17] fs: fat: support mkdir [14/17] cmd: fat: add fatmkdir command [15/17] efi_loader: file: support creating a directory [16/17] efi_loader: implement a pseudo "file delete" [17/17] fs-test: fix false positive error at Test Case 12

Message ID

20180720025723.6736-16-takahiro.akashi@linaro.org

State

Superseded

Headers

Received-SPF: pass (google.com: best guess record for domain of
	u-boot-bounces@lists.denx.de designates 81.169.180.215 as
	permitted sender) client-ip=81.169.180.215; 
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: trini@konsulko.com
Date: Fri, 20 Jul 2018 11:57:21 +0900
Message-Id: <20180720025723.6736-16-takahiro.akashi@linaro.org>
In-Reply-To: <20180720025723.6736-1-takahiro.akashi@linaro.org>
References: <20180720025723.6736-1-takahiro.akashi@linaro.org>
Cc: u-boot@lists.denx.de, xypron.glpk@gmx.de, agraf@suse.de
Subject: [U-Boot] [PATCH 15/17] efi_loader: file: support creating a
	directory
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

fs: fat: extend FAT write operations | expand

Commit Message

AKASHI Takahiro July 20, 2018, 2:57 a.m. UTC

In efi world, there is no obvious "mkdir" interface, instead, Open()
with EFI_FILE_MODE_CREATE in mode parameter and EFI_FILE_DIRECTORY
in attributes parameter creates a directory.

In this patch, efi_file_open() is extended so as to accept such
a combination of parameters and call u-boot's mkdir interface for
expected action.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 lib/efi_loader/efi_file.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/lib/efi_loader/efi_file.c b/lib/efi_loader/efi_file.c
index e6a15bcb52..6ec98c8022 100644
--- a/lib/efi_loader/efi_file.c
+++ b/lib/efi_loader/efi_file.c
@@ -130,7 +130,8 @@  static int sanitize_path(char *path)
  * With windoze style backlashes, ofc.
  */
 static struct efi_file_handle *file_open(struct file_system *fs,
-		struct file_handle *parent, s16 *file_name, u64 mode)
+		struct file_handle *parent, s16 *file_name, u64 mode,
+		u64 attributes)
 {
 	struct file_handle *fh;
 	char f0[MAX_UTF8_PER_UTF16] = {0};
@@ -173,7 +174,12 @@  static struct efi_file_handle *file_open(struct file_system *fs,
 		if (set_blk_dev(fh))
 			goto error;
 
-		if (!((mode & EFI_FILE_MODE_CREATE) || fs_exists(fh->path)))
+		if ((mode & EFI_FILE_MODE_CREATE) &&
+		    (attributes & EFI_FILE_DIRECTORY)) {
+			if (fs_mkdir(fh->path))
+				goto error;
+		} else if (!((mode & EFI_FILE_MODE_CREATE) ||
+			     fs_exists(fh->path)))
 			goto error;
 
 		/* figure out if file is a directory: */
@@ -199,7 +205,7 @@  static efi_status_t EFIAPI efi_file_open(struct efi_file_handle *file,
 	EFI_ENTRY("%p, %p, \"%ls\", %llx, %llu", file, new_handle, file_name,
 		  open_mode, attributes);
 
-	*new_handle = file_open(fh->fs, fh, file_name, open_mode);
+	*new_handle = file_open(fh->fs, fh, file_name, open_mode, attributes);
 	if (!*new_handle)
 		return EFI_EXIT(EFI_NOT_FOUND);
 
@@ -598,7 +604,7 @@  efi_open_volume(struct efi_simple_file_system_protocol *this,
 
 	EFI_ENTRY("%p, %p", this, root);
 
-	*root = file_open(fs, NULL, NULL, 0);
+	*root = file_open(fs, NULL, NULL, 0, 0);
 
 	return EFI_EXIT(EFI_SUCCESS);
 }

[15/17] efi_loader: file: support creating a directory

Commit Message

Patch