| Message ID | 20200613205717.v2.32.I2d1da16437c44c8356d84d743cc1fb4e0c93a42a@changeid |
|---|---|
| State | Accepted |
| Commit | be17bcb9af3bf8c0054c4cd5b2a5e469181897b5 |
| Headers | show |
| Series | rockchip: x86: Support building ROM files automatically with binman | expand |
On Sun, Jun 14, 2020 at 10:58 AM Simon Glass <sjg at chromium.org> wrote: > > Quite a few boards using this SoC family don't use binman, yet > CONFIG_BINMAN is enabled for all of them. But the option should only be > enabled if we expect binman to produce an image. Calling binman when the > device tree is missing, etc. will cause failer. > > Add a condition so that CONFIG_BINMAN is only enabled as needed. > > Signed-off-by: Simon Glass <sjg at chromium.org> > --- > > (no changes since v1) > > arch/powerpc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index c2c577f60c..6a2e88fed2 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -20,7 +20,7 @@ config MPC85xx select CREATE_ARCH_SYMLINK select SYS_FSL_DDR select SYS_FSL_DDR_BE - select BINMAN + select BINMAN if OF_SEPARATE imply CMD_HASH imply CMD_IRQ imply USB_EHCI_HCD if USB
Quite a few boards using this SoC family don't use binman, yet CONFIG_BINMAN is enabled for all of them. But the option should only be enabled if we expect binman to produce an image. Calling binman when the device tree is missing, etc. will cause failer. Add a condition so that CONFIG_BINMAN is only enabled as needed. Signed-off-by: Simon Glass <sjg at chromium.org> --- (no changes since v1) arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)