From patchwork Tue Dec 8 04:12:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 339685 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp3365311jai; Mon, 7 Dec 2020 20:12:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwBwATaWJM9GVQ1q+5tabxYC4KyG8v5//IMFFnj2NT5cge6WGLHxOO9/Vq7xzykOY2t5Gs/ X-Received: by 2002:a17:906:52c4:: with SMTP id w4mr21842109ejn.165.1607400767167; Mon, 07 Dec 2020 20:12:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607400767; cv=none; d=google.com; s=arc-20160816; b=ghqD8Mn6FWBWlNUrqJCOe2KdZg63Ac8dFenxtihoQc3gN7hwoPwLgwkCtLME6fGW+1 nTr+LcOQXtGJwMs/Trl/pT06MCZnwslhcV0FGl/7HBjXSXS4OsKZnFLbll5Tdc0KAl16 bK0vBtNnNZ51/piLIzmVaks6ncuxA/OGVTdYU65QgIJ+YqrX9cMKsetAEHz7eDCPjZeO n84cLRqJzmGJvsiuqex8DIOf/SH4MVsccyB0KVx74t0gll8V1Oq6qcTOdjx2+t2oKW8S Xa0/0A2WMIkVBddwYj7laaOkZl9qyaUQ++68ImOceWMnSfXQ3DsCmKbaD4itbveBfuIw bieg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fdfYOrDQ+5jHBpj98tjZyiZwzoA4eUHCyBe+aQEaYaI=; b=nBs/V1hrwjhZF1bYperlh+VflwKX1CV0TE8ROzoBWYTo/uFRJvYyz4YKlyTMdN7wn9 RD/io5FnA50XolRQHRhyirT2D1X5NNIHzZL2qQvKPdUGtml878aWTsxRep0JyqScH0VU WXAWhmjW4lsM8lUl5+IpoEpq60roMvwGYyqH0CCVmh9qD+0ozNQ+AGI3/BViJSI0vRh5 eh1F24CDk59cWtKHF1oDwdYfAMR/iGqOm2TtIzMzgrxfdAdRiMTgQ1qb893XsxVujaSM AKQ6Af0LmhTrOoldf3IjvP0coz7zafc7vzzsRyu110zlyttH0EzJazdo0k+BTHgADoL6 vecg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=iFgbxjfc; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id a11si7674005eje.119.2020.12.07.20.12.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 20:12:47 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=iFgbxjfc; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 349478232D; Tue, 8 Dec 2020 05:12:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="iFgbxjfc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1191082300; Tue, 8 Dec 2020 05:12:36 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: * X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8269F806C5 for ; Tue, 8 Dec 2020 05:12:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=joel.stan@gmail.com Received: by mail-pf1-x444.google.com with SMTP id d2so8732464pfq.5 for ; Mon, 07 Dec 2020 20:12:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fdfYOrDQ+5jHBpj98tjZyiZwzoA4eUHCyBe+aQEaYaI=; b=iFgbxjfckcDw4N+LfpCGIbb7Gz38LaT0Wg6GJSYr7hrM12jByEru0Q7l3NvzYsXLlq 4DBXBjOOhjTFMSpqNGtZrCgQkIdwlR3ekkfl6f9z57jvhhguKwnbtSmMSF2e5WbLvX9m ZWbGtXYN+UKblN+cH2H4LKGZHw9vK2//x5AFotzmO8YFZFMOtdSNhYsO2kMTChL+m8mw mMJx80wJ6aNAEjSktBXJvn/cjToZ6ZeR4F9JXDtwov7Uf+Aa2yR2sh5LMNN/PUUpUhRE DhQmiSZKomnrgBANjKFt8dwilUtECXWBhhb3u4s/r754FB9ltxmx/0UcM+8ihzLZT/Mm cIhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fdfYOrDQ+5jHBpj98tjZyiZwzoA4eUHCyBe+aQEaYaI=; b=XoMKarXwSxLrVX+7i4awwr7rtn3RWEWibtV1E6mE0r2EwnbuqUxR4TELNUG0hw6Xin 8QJ7t5FHYZvCwpIcuhRYWh7mu4FLd1O7F0Icaqn7QaPBeyEwgB/LMZFEWBJJgDFMo4Wi AduLIBwMIHDGkFvyusIX61EJFSoqSPncQPtxh7b5ZQ5GTyW7zr46nUZNHzPlH3NqEeuS Ug21LcFP7nfblfT2GrxpwBQ8RoJsx15QXbFEVel5x7lK2mvlwQzCW36fJcnZ2/GO77RY Ixw7Xf2vsXJL6LVdy81/lPc9JjEy89DiR2piv4HWCe6wtNik6FlZXACUFH0g3In1tDkS Rl7g== X-Gm-Message-State: AOAM5324F4tokyB8QBoHAhg+4Wo7TerqhaH1R1O2xleNeGmGDgs9dKsY dgF2KOmEa4eAtOkSSgXXBYI= X-Received: by 2002:a63:1113:: with SMTP id g19mr11675540pgl.23.1607400752021; Mon, 07 Dec 2020 20:12:32 -0800 (PST) Received: from localhost.localdomain ([45.124.203.14]) by smtp.gmail.com with ESMTPSA id j20sm6055162pfd.106.2020.12.07.20.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Dec 2020 20:12:30 -0800 (PST) From: Joel Stanley To: Simon Glass , Heinrich Schuchardt , Philippe REYNES Cc: u-boot@lists.denx.de Subject: [PATCH v2 1/4] tools/Makefile: FIT_CIPHER requires libssl Date: Tue, 8 Dec 2020 14:42:13 +1030 Message-Id: <20201208041216.888902-2-joel@jms.id.au> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201208041216.888902-1-joel@jms.id.au> References: <20201208041216.888902-1-joel@jms.id.au> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean If CONFIG_FIT_CIPHER is enabled without CONFIG_FIT_SIGNATURE then mkimage/dumpimage will fail to link: /usr/bin/ld: tools/common/image-cipher.o: in function `fit_image_decrypt_data': image-cipher.c:(.text+0x9a): undefined reference to `image_get_host_blob' /usr/bin/ld: tools/common/image-cipher.o:(.data.rel+0x10): undefined reference to `EVP_aes_128_cbc' /usr/bin/ld: tools/common/image-cipher.o:(.data.rel+0x40): undefined reference to `EVP_aes_192_cbc' /usr/bin/ld: tools/common/image-cipher.o:(.data.rel+0x70): undefined reference to `EVP_aes_256_cbc' /usr/bin/ld: tools/lib/aes/aes-encrypt.o: in function `image_aes_encrypt': aes-encrypt.c:(.text+0x22): undefined reference to `EVP_CIPHER_CTX_new' /usr/bin/ld: aes-encrypt.c:(.text+0x6f): undefined reference to `EVP_EncryptInit_ex' /usr/bin/ld: aes-encrypt.c:(.text+0x8d): undefined reference to `EVP_EncryptUpdate' /usr/bin/ld: aes-encrypt.c:(.text+0xac): undefined reference to `EVP_CIPHER_CTX_free' /usr/bin/ld: aes-encrypt.c:(.text+0xf2): undefined reference to `EVP_EncryptFinal_ex' collect2: error: ld returned 1 exit status Signed-off-by: Joel Stanley --- tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.2 diff --git a/tools/Makefile b/tools/Makefile index 253a6b97065b..99a931312cd8 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -154,7 +154,7 @@ HOSTCFLAGS_kwbimage.o += -DCONFIG_KWB_SECURE endif # MXSImage needs LibSSL -ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_ARMADA_38X)$(CONFIG_ARMADA_39X)$(CONFIG_FIT_SIGNATURE),) +ifneq ($(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_ARMADA_38X)$(CONFIG_ARMADA_39X)$(CONFIG_FIT_SIGNATURE)$(CONFIG_FIT_CIPHER),) HOSTCFLAGS_kwbimage.o += \ $(shell pkg-config --cflags libssl libcrypto 2> /dev/null || echo "") HOSTLDLIBS_mkimage += \