From patchwork Thu Nov 25 07:12:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sughosh Ganu X-Patchwork-Id: 519370 Delivered-To: patch@linaro.org Received: by 2002:ac0:c605:0:0:0:0:0 with SMTP id p5csp368441imj; Wed, 24 Nov 2021 23:14:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJz0jN99zaLD/A9o0tVz4rRgLGfyDHVxI32SKhAAuqmIYHYI+XTQfknBfPgOc+HOgMeT8++y X-Received: by 2002:a17:907:7210:: with SMTP id dr16mr28616542ejc.267.1637824458056; Wed, 24 Nov 2021 23:14:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1637824458; cv=none; d=google.com; s=arc-20160816; b=ebAR33caYN0ms1uahem5DTESIEJurDH4v1f2CJ9MOkwvRaINnYMPJrihSaUvjoodIW ftkMEjZ9a8hQ/jmietvTvRkOH0L3up304QKI+8UbSCh/87r6/xwm7O/9sn/IxFhbeNiA fQfr4GA4aebvrLgOBkOxRl1NbuxNquu+421gdkiCde/ZSLMj05JlJ+fvWfWD85EoUbI9 380lhzwMgjapcRAGvhTIm43MjSnLv/Mn+lwj6xM7T+wTcjUXdxWwqD0Y3DPYnRcENthk G0DAu9qfx6zFMbTFpTsjtNDky1O09jdt7XZCD8Hqzlp5imFxkl9MZrP1O7E/yiM1aM3o lp8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:references:in-reply-to :message-id:date:subject:cc:to:from; bh=JIqyWQbDwwhrZENTfNmz/Fxv4anjVb810vu/1sq7Dps=; b=NbWY1munSZ/pT7b5uSizcUwLlQvGkP9NSSGitmCcQrzU3sJv280oNgP6hqgfBf5ZWp 3d/RW+626Y+OiHFsz4VE8OC9UmhEr2RVTTW/L9MmxQOXe7aBn5m1yE9W98Gq6xjS6DZR k4tjP/PNgVRE3y2OEmNvQTPFmxJ1w1QCZTkSeNGqAACIB/vnOPfrqEdRG5A7BAFcC1uL jHYqW6Qhql263urvxmpQTrgPGW8npTqUar6vSMzkeNAnmczouWSMfTUXcI0Q3TMlzAY5 2YSkOLCdCIhq/SL4eNhR0Wjx2UGmv1ZadkKv6t9zgzCaB5lplpre3XvUEmYWqoXFt6Iu 3TXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [85.214.62.61]) by mx.google.com with ESMTPS id z19si4547166ejx.623.2021.11.24.23.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 23:14:18 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; Authentication-Results: mx.google.com; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 97C6E8374D; Thu, 25 Nov 2021 08:13:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id E528A8128B; Thu, 25 Nov 2021 08:13:46 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.2 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 41AF7836E2 for ; Thu, 25 Nov 2021 08:13:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sughosh.ganu@linaro.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB18B150C; Wed, 24 Nov 2021 23:13:40 -0800 (PST) Received: from a076522.blr.arm.com (a076522.blr.arm.com [10.162.16.44]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A7F833F5A1; Wed, 24 Nov 2021 23:13:36 -0800 (PST) From: Sughosh Ganu To: u-boot@lists.denx.de Cc: Patrick Delaunay , Patrice Chotard , Heinrich Schuchardt , Alexander Graf , Simon Glass , Bin Meng , Peng Fan , AKASHI Takahiro , Ilias Apalodimas , Jose Marinho , Grant Likely , Jason Liu , Sughosh Ganu Subject: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata Date: Thu, 25 Nov 2021 12:42:55 +0530 Message-Id: <20211125071302.3644-4-sughosh.ganu@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211125071302.3644-1-sughosh.ganu@linaro.org> References: <20211125071302.3644-1-sughosh.ganu@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean In the FWU Multi Bank Update feature, the information about the updatable images is stored as part of the metadata, which is stored on a dedicated partition. Add the metadata structure, and functions to access the metadata. These are generic API's, and implementations can be added based on parameters like how the metadata partition is accessed and what type of storage device houses the metadata. Signed-off-by: Sughosh Ganu --- include/fwu_metadata.h | 125 +++++++++++++++ lib/fwu_updates/fwu_metadata.c | 275 +++++++++++++++++++++++++++++++++ 2 files changed, 400 insertions(+) create mode 100644 include/fwu_metadata.h create mode 100644 lib/fwu_updates/fwu_metadata.c diff --git a/include/fwu_metadata.h b/include/fwu_metadata.h new file mode 100644 index 0000000000..e692ef7506 --- /dev/null +++ b/include/fwu_metadata.h @@ -0,0 +1,125 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright (c) 2021, Linaro Limited + */ + +#if !defined _FWU_METADATA_H_ +#define _FWU_METADATA_H_ + +#include +#include +#include + +#include + +/** + * struct fwu_image_bank_info - firmware image information + * @image_uuid: Guid value of the image in this bank + * @accepted: Acceptance status of the image + * @reserved: Reserved + * + * The structure contains image specific fields which are + * used to identify the image and to specify the image's + * acceptance status + */ +struct fwu_image_bank_info { + efi_guid_t image_uuid; + u32 accepted; + u32 reserved; +}; + +/** + * struct fwu_image_entry - information for a particular type of image + * @image_type_uuid: Guid value for identifying the image type + * @location_uuid: Guid of the storage volume where the image is located + * @img_bank_info: Array containing properties of images + * + * This structure contains information on various types of updatable + * firmware images. Each image type then contains an array of image + * information per bank. + */ +struct fwu_image_entry { + efi_guid_t image_type_uuid; + efi_guid_t location_uuid; + struct fwu_image_bank_info img_bank_info[CONFIG_FWU_NUM_BANKS]; +}; + +/** + * struct fwu_metadata - Metadata structure for multi-bank updates + * @crc32: crc32 value for the metadata + * @version: Metadata version + * @active_index: Index of the bank currently used for booting images + * @previous_active_inde: Index of the bank used before the current bank + * being used for booting + * @img_entry: Array of information on various firmware images that can + * be updated + * + * This structure is used to store all the needed information for performing + * multi bank updates on the platform. This contains info on the bank being + * used to boot along with the information needed for identification of + * individual images + */ +struct fwu_metadata { + u32 crc32; + u32 version; + u32 active_index; + u32 previous_active_index; + + struct fwu_image_entry img_entry[CONFIG_FWU_NUM_IMAGES_PER_BANK]; +}; + +/** + * @get_active_index: get the current active_index value + * @update_active_index: update the active_index value + * @fill_partition_guid_array: fill the array with guid values of the + * partitions found on the storage media + * @get_image_alt_num: get the alt number to be used for the image + * @metadata_check: check the validity of the metadata partitions + * @revert_boot_index: set the active_index to previous_active_index + * @set_accept_image: set the accepted bit for the image + * @clear_accept_image: clear the accepted bit for the image + * @get_metadata() - Get a metadata copy + */ +struct fwu_metadata_ops { + int (*get_active_index)(u32 *active_idx); + + int (*update_active_index)(u32 active_idx); + + int (*fill_partition_guid_array)(efi_guid_t **part_guid_arr, + u32 *nparts); + + int (*get_image_alt_num)(efi_guid_t image_type_id, u32 update_bank, + int *alt_num); + + int (*metadata_check)(void); + + int (*revert_boot_index)(u32 *active_idx); + + int (*set_accept_image)(efi_guid_t *img_type_id); + + int (*clear_accept_image)(efi_guid_t *img_type_id, u32 bank); + + int (*get_metadata)(struct fwu_metadata **metadata); +}; + +#define FWU_METADATA_GUID \ + EFI_GUID(0x8a7a84a0, 0x8387, 0x40f6, 0xab, 0x41, \ + 0xa8, 0xb9, 0xa5, 0xa6, 0x0d, 0x23) + +#define FWU_METADATA_VERSION 0x1 + +extern struct fwu_metadata_ops fwu_gpt_blk_ops; + +struct fwu_metadata_ops *get_plat_fwu_metadata_ops(void); +int fwu_get_active_index(u32 *active_idx); +int fwu_update_active_index(u32 active_idx); +int fwu_fill_partition_guid_array(efi_guid_t **part_guid_arr, u32 *nparts); +int fwu_get_image_alt_num(efi_guid_t image_type_id, u32 update_bank, + int *alt_num); +int fwu_metadata_check(void); +int fwu_revert_boot_index(u32 *active_idx); +int fwu_accept_image(efi_guid_t *img_type_id); +int fwu_clear_accept_image(efi_guid_t *img_type_id, u32 bank); +int fwu_get_metadata(struct fwu_metadata **metadata); + +#endif /* _FWU_METADATA_H_ */ diff --git a/lib/fwu_updates/fwu_metadata.c b/lib/fwu_updates/fwu_metadata.c new file mode 100644 index 0000000000..ebc3eaa04a --- /dev/null +++ b/lib/fwu_updates/fwu_metadata.c @@ -0,0 +1,275 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (c) 2021, Linaro Limited + */ + +#include + +#include +#include + +static inline struct fwu_metadata_ops *get_fwu_metadata_ops(void) +{ + return get_plat_fwu_metadata_ops(); +} + +/** + * fwu_get_active_index() - Get active_index from the metadata + * @active_idx: active_index value to be read + * + * Read the active_index field from the metadata and place it in + * the variable pointed to be the function argument. + * + * Return: 0 if OK, -ve on error + * + */ +int fwu_get_active_index(u32 *active_idx) +{ + struct fwu_metadata_ops *ops; + + ops = get_fwu_metadata_ops(); + if (!ops) { + log_err("Unable to get fwu ops\n"); + return -EPROTONOSUPPORT; + } + + if (!ops->get_active_index) { + log_err("get_active_index() method not defined for the platform\n"); + return -ENOSYS; + } + + return ops->get_active_index(active_idx); +} + +/** + * fwu_update_active_index() - Update active_index from the metadata + * @active_idx: active_index value to be updated + * + * Update the active_index field in the metadata + * + * Return: 0 if OK, -ve on error + * + */ +int fwu_update_active_index(u32 active_idx) +{ + struct fwu_metadata_ops *ops; + + ops = get_fwu_metadata_ops(); + if (!ops) { + log_err("Unable to get fwu ops\n"); + return -EPROTONOSUPPORT; + } + + if (!ops->update_active_index) { + log_err("update_active_index() method not defined for the platform\n"); + return -ENOSYS; + } + + return ops->update_active_index(active_idx); +} + +/** + * fwu_fill_partition_guid_array() - Fill the part_guid_arr array with the guid's of + * the partitions + * @part_guid_arr: array of partition guid's + * @nparts: Number of gpt partitions on the device + * + * Get the information on the partition guid's, filling the array with the guid + * values and also the number of partitions. + * + * Return: 0 if OK, -ve on error + * + */ +int fwu_fill_partition_guid_array(efi_guid_t **part_guid_arr, u32 *nparts) +{ + struct fwu_metadata_ops *ops; + + ops = get_fwu_metadata_ops(); + if (!ops) { + log_err("Unable to get fwu ops\n"); + return -EPROTONOSUPPORT; + } + + if (!ops->fill_partition_guid_array) { + log_err("fill_partition_guid_array() method not defined for the platform\n"); + return -ENOSYS; + } + + return ops->fill_partition_guid_array(part_guid_arr, nparts); +} + +/** + * fwu_get_image_alt_num() - Get the dfu alt number to be used for capsule update + * @image_type_id: image guid as passed in the capsule + * @update_bank: Bank to which the update is to be made + * @alt_num: The alt_num for the image + * + * Based on the guid value passed in the capsule, along with the bank to which the + * image needs to be updated, get the dfu alt number which will be used for the + * capsule update + * + * Return: 0 if OK, -ve on error + * + */ +int fwu_get_image_alt_num(efi_guid_t image_type_id, u32 update_bank, + int *alt_num) +{ + struct fwu_metadata_ops *ops; + + ops = get_fwu_metadata_ops(); + if (!ops) { + log_err("Unable to get fwu ops\n"); + return -EPROTONOSUPPORT; + } + + if (!ops->get_image_alt_num) { + log_err("get_image_alt_num() method not defined for the platform\n"); + return -ENOSYS; + } + + return ops->get_image_alt_num(image_type_id, update_bank, alt_num); +} + +/** + * fwu_metadata_check() - Check if the metadata is valid + * + * Validate both copies of metadata. If one of the copies + * has gone bad, restore it from the other bad copy. + * + * Return: 0 if OK, -ve on error + * + */ +int fwu_metadata_check(void) +{ + struct fwu_metadata_ops *ops; + + ops = get_fwu_metadata_ops(); + if (!ops) { + log_err("Unable to get fwu ops\n"); + return -EPROTONOSUPPORT; + } + + if (!ops->metadata_check) { + log_err("metadata_check() method not defined for the platform\n"); + return -ENOSYS; + } + + return ops->metadata_check(); +} + +/** + * fwu_revert_boot_index() - Revert the active index in the metadata + * @active_idx: Value of the updated active_index + * + * Revert the active_index value in the metadata, by swapping the values + * of active_index and previous_active_index in both copies of the + * metadata. + * + * Return: 0 if OK, -ve on error + * + */ +int fwu_revert_boot_index(u32 *active_idx) +{ + struct fwu_metadata_ops *ops; + + ops = get_fwu_metadata_ops(); + if (!ops) { + log_err("Unable to get fwu ops\n"); + return -EPROTONOSUPPORT; + } + + if (!ops->revert_boot_index) { + log_err("revert_boot_index() method not defined for the platform\n"); + return -ENOSYS; + } + + return ops->revert_boot_index(active_idx); +} + +/** + * fwu_accept_image() - Set the Acceptance bit for the image + * @img_type_id: Guid of the image type for which the accepted bit is to be + * cleared + * + * Set the accepted bit for the image specified by the img_guid parameter. This + * indicates acceptance of image for subsequent boots by some governing component + * like OS(or firmware). + * + * Return: 0 if OK, -ve on error + * + */ +int fwu_accept_image(efi_guid_t *img_type_id) +{ + struct fwu_metadata_ops *ops; + + ops = get_fwu_metadata_ops(); + if (!ops) { + log_err("Unable to get fwu ops\n"); + return -EPROTONOSUPPORT; + } + + if (!ops->set_accept_image) { + log_err("set_accept_image() method not defined for the platform\n"); + return -ENOSYS; + } + + return ops->set_accept_image(img_type_id); +} + +/** + * fwu_clear_accept_image() - Clear the Acceptance bit for the image + * @img_type_id: Guid of the image type for which the accepted bit is to be + * cleared + * + * Clear the accepted bit for the image type specified by the img_type_id parameter. + * This function is called after the image has been updated. The accepted bit is + * cleared to be set subsequently after passing the image acceptance criteria, by + * either the OS(or firmware) + * + * Return: 0 if OK, -ve on error + * + */ +int fwu_clear_accept_image(efi_guid_t *img_type_id, u32 bank) +{ + struct fwu_metadata_ops *ops; + + ops = get_fwu_metadata_ops(); + if (!ops) { + log_err("Unable to get fwu ops\n"); + return -EPROTONOSUPPORT; + } + + if (!ops->clear_accept_image) { + log_err("clear_accept_image() method not defined for the platform\n"); + return -ENOSYS; + } + + return ops->clear_accept_image(img_type_id, bank); +} + +/** + * fwu_get_metadata() - Get a metadata copy + * @metadata: Copy of the metadata + * + * Get a valid copy of the metadata. + * + * Return: 0 if OK, -ve on error + * + */ +int fwu_get_metadata(struct fwu_metadata **metadata) +{ + struct fwu_metadata_ops *ops; + + ops = get_fwu_metadata_ops(); + if (!ops) { + log_err("Unable to get fwu ops\n"); + return -EPROTONOSUPPORT; + } + + if (!ops->get_metadata) { + log_err("get_metadata() method not defined for the platform\n"); + return -ENOSYS; + } + + return ops->get_metadata(metadata); +}