| Message ID | 20220720122926.415659-8-sughosh.ganu@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tpm: rng: Move TPM RNG functionality to driver model | expand |
On Wed, 20 Jul 2022 at 15:30, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > The 'rng' command dumps a number of random bytes on the console. Add a > set of tests for the 'rng' command. The test function performs basic > sanity testing of the command. > > Since a unit test is being added for the command, enable it by default > in the sandbox platforms. > > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org> > Reviewed-by: Simon Glass <sjg@chromium.org> > --- > Changes since V6: None > > cmd/Kconfig | 1 + > test/dm/rng.c | 29 +++++++++++++++++++++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index d5f842136c..76878ce307 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -1961,6 +1961,7 @@ config CMD_GETTIME > config CMD_RNG > bool "rng command" > depends on DM_RNG > + default y if SANDBOX > select HEXDUMP > help > Print bytes from the hardware random number generator. > diff --git a/test/dm/rng.c b/test/dm/rng.c > index 5b34c93ed6..6d1f68848d 100644 > --- a/test/dm/rng.c > +++ b/test/dm/rng.c > @@ -25,3 +25,32 @@ static int dm_test_rng_read(struct unit_test_state *uts) > return 0; > } > DM_TEST(dm_test_rng_read, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT); > + > +/* Test the rng command */ > +static int dm_test_rng_cmd(struct unit_test_state *uts) > +{ > + struct udevice *dev; > + > + ut_assertok(uclass_get_device(UCLASS_RNG, 0, &dev)); > + ut_assertnonnull(dev); > + > + ut_assertok(console_record_reset_enable()); > + > + run_command("rng", 0); > + ut_assert_nextlinen("00000000:"); > + ut_assert_nextlinen("00000010:"); > + ut_assert_nextlinen("00000020:"); > + ut_assert_nextlinen("00000030:"); > + ut_assert_console_end(); > + > + run_command("rng 0 10", 0); > + ut_assert_nextlinen("00000000:"); > + ut_assert_console_end(); > + > + run_command("rng 20", 0); > + ut_assert_nextlinen("No RNG device"); > + ut_assert_console_end(); > + > + return 0; > +} > +DM_TEST(dm_test_rng_cmd, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT | UT_TESTF_CONSOLE_REC); > -- > 2.34.1 > Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff --git a/cmd/Kconfig b/cmd/Kconfig index d5f842136c..76878ce307 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1961,6 +1961,7 @@ config CMD_GETTIME config CMD_RNG bool "rng command" depends on DM_RNG + default y if SANDBOX select HEXDUMP help Print bytes from the hardware random number generator. diff --git a/test/dm/rng.c b/test/dm/rng.c index 5b34c93ed6..6d1f68848d 100644 --- a/test/dm/rng.c +++ b/test/dm/rng.c @@ -25,3 +25,32 @@ static int dm_test_rng_read(struct unit_test_state *uts) return 0; } DM_TEST(dm_test_rng_read, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT); + +/* Test the rng command */ +static int dm_test_rng_cmd(struct unit_test_state *uts) +{ + struct udevice *dev; + + ut_assertok(uclass_get_device(UCLASS_RNG, 0, &dev)); + ut_assertnonnull(dev); + + ut_assertok(console_record_reset_enable()); + + run_command("rng", 0); + ut_assert_nextlinen("00000000:"); + ut_assert_nextlinen("00000010:"); + ut_assert_nextlinen("00000020:"); + ut_assert_nextlinen("00000030:"); + ut_assert_console_end(); + + run_command("rng 0 10", 0); + ut_assert_nextlinen("00000000:"); + ut_assert_console_end(); + + run_command("rng 20", 0); + ut_assert_nextlinen("No RNG device"); + ut_assert_console_end(); + + return 0; +} +DM_TEST(dm_test_rng_cmd, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT | UT_TESTF_CONSOLE_REC);