From patchwork Tue Dec 26 15:46:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Uvarov X-Patchwork-Id: 758380 Delivered-To: patch@linaro.org Received: by 2002:a5d:67c6:0:b0:336:6142:bf13 with SMTP id n6csp3131737wrw; Tue, 26 Dec 2023 07:49:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGXOzleLduwLdPQgLHhz+217tlND4vComzurxf4gXavMAfUyHKyCjdLxsS9k5JmApwgKcc X-Received: by 2002:a05:600c:4e8e:b0:40d:55dd:baf2 with SMTP id f14-20020a05600c4e8e00b0040d55ddbaf2mr2491854wmq.25.1703605758993; Tue, 26 Dec 2023 07:49:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703605758; cv=none; d=google.com; s=arc-20160816; b=xayf5EYHvcD/rYSHuU3v8FuvjB930Kg19RqBBfcfID1MPgPGts3dAlO2tptcOKNZM5 gKBNEZl8DWYpg7FnaTz4HUiIGoFw7zhaLC7njXFMSwpLsqRDe0w4NrvDiKAiBCIV1HcB c9khpTfCHTZfrhiZjUI1KdqVyyW/U6s83kgjQQFKrt8U8FI2Fgp8FRxjQUqTLWEoiQza EjcGBxCGGhJm8TcignCOg8m49/y0rvMOmwIATc2PfhzBY1Q5eRNfOjR11S9FA2lH7Sht 9c56fSjSvumQ4z9ytZkiGBsagCmMZp93E7XT2G2LLbM1k+DDZRT/aPTGbEAHpg7Fc3KQ SL7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=npN69VVzc7obA2Z0hr4liDGB2Jr09YIPDZiBD6W8bC8=; fh=al8TO5kxNSCLdK6Wct4/S1Ky9QCKGaknFfrx/Rr/20U=; b=KbIHJFUfxRqU9KwuYv8rRzaI8MB7/1x/GryL2uIyCdcG4Ap/xeXFOwalBGiyLJ2VNQ tBbTmQQd7woTASqmwo9Fyc14AeEKK9QMwCio7Fq9xv7NZ/N1EnXPgc6dK+GU5JffdDRb 6fcuT6MWhx/8BIaiRB5usFayX2w8HEsrv8aDLIJ+7pgJRlY5ukmflLPEn5/4rrBAi7YL svI6JfoibNqJqrLVKsU0OkP3pHdt9FiHCvIGt20beKVCqKZnZQpYvS24MJREr3IqkYB0 ksUGy0HDQZ58pVWGHVp+v0+9oPAosLU9e3Attd3kCDD46mAuuBJuqk7KliXCQa2EQo2f hGuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cw++8Z3i; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id c5-20020a05600c0ac500b0040d5c89e24dsi168646wmr.213.2023.12.26.07.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 07:49:18 -0800 (PST) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cw++8Z3i; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 393868786F; Tue, 26 Dec 2023 16:48:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Cw++8Z3i"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 330E086F56; Tue, 26 Dec 2023 16:48:49 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3633B878FC for ; Tue, 26 Dec 2023 16:48:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maxim.uvarov@linaro.org Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50e81761e43so618225e87.2 for ; Tue, 26 Dec 2023 07:48:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703605726; x=1704210526; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=npN69VVzc7obA2Z0hr4liDGB2Jr09YIPDZiBD6W8bC8=; b=Cw++8Z3iQSoWJb8eTd2D62Z7KTMxweq3bk6fRvV6JWiG+1r7CllXmcSJE2qCrtmtS5 mZvsjsZ3ZmPr3WiRX6jAeMk/6QC1mVbeSFn2HhFirSvwd71s0mBQCF3nOHoJD6JM3SI2 r49W+xC/3pRa0ySEvyxxuyN8RihD74kDir4QESU/xQR71YUjRDBSES9p5vcpnD8/1HQo boMVk14ytZRNninPS4q4Ky4Q2gtDioUBkzhPAo6gC5tWau15s3eg8wC+aZPVM581M9ZS Yoj2KjbW2kYk6b9xZ9qG3qDSmj1F5p8g7j8AXE4/fHnW2gzmHzP/+Xn8uAbOPPxkqdeA cU6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703605726; x=1704210526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=npN69VVzc7obA2Z0hr4liDGB2Jr09YIPDZiBD6W8bC8=; b=phHy6uzyZf9BK65uOiuZXw+fwD6DROSBnICxbpdUueKxiqZ58T1Z7v4k+Y1h9+HtWN ZrlMprZu6CAVc6v3/e7s9hhwa0+nFcW7KcTGLSilrgJp26z1NroKnfhGLAD3FpSqVu5J JfJsNBDk+sqcZBhnVgA4miMGg1dRgBIbetClyoyw7huVorNtT/oNLXI+kjzK2NHbkeh4 nxAaBPeeeVMFsaOnzAJRoBl5rTp30IQTLwpCL+v9UZ89cKzOjnzEs7rBhT7u0ooYg4uc BZsWCvK1PhV+DmIuhy7iS1HYJoTlndvJbhdjE3fhV/uOQprgQL9WqvgQ09IUTjFguaMU opSQ== X-Gm-Message-State: AOJu0YzPbenATHPNnULQSlvDsPuLThKLGbfyaksdVM98eV0UrzrhnBbD cM6lmijY64gTXrna9dfAK/0h1hZVXv/vzYy/0R2va6WYJZE= X-Received: by 2002:a05:6512:b84:b0:50e:7d4f:b402 with SMTP id b4-20020a0565120b8400b0050e7d4fb402mr1059388lfv.117.1703605726303; Tue, 26 Dec 2023 07:48:46 -0800 (PST) Received: from localhost.localdomain ([45.82.14.220]) by smtp.gmail.com with ESMTPSA id d25-20020a0565123d1900b0050e743b0b2csm1089336lfv.34.2023.12.26.07.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 07:48:46 -0800 (PST) From: Maxim Uvarov To: u-boot@lists.denx.de Cc: simon.k.r.goldschmidt@gmail.com, tien.fong.chee@intel.com, sjg@chromium.org, joe.hershberger@ni.com, rfried.dev@gmail.com, bharat.gooty@broadcom.com, rayagonda.kokatanur@broadcom.com, trini@konsulko.com, Maxim Uvarov Subject: [PATHv3 4/8] driver/net/rtl8139: remove debug print Date: Tue, 26 Dec 2023 21:46:15 +0600 Message-Id: <20231226154619.5071-5-maxim.uvarov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231226154619.5071-1-maxim.uvarov@linaro.org> References: <20231226154619.5071-1-maxim.uvarov@linaro.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean debug print delays reset of the driver. Finally I see bunch of "rx error FFFF" errors in the screen. CI can not handle many prints. While network works fine there Reproduced with: make CROSS_COMPILE=sh2-linux- r2dplus_defconfig all qemu-system-sh4 -M r2d -nographic -serial null \ -serial mon:stdio -net user,tftp=`pwd` \ -net nic,model=rtl8139 -kernel ./u-boot.bin Signed-off-by: Maxim Uvarov Reviewed-by: Simon Glass --- drivers/net/rtl8139.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/rtl8139.c b/drivers/net/rtl8139.c index 106bc1c7ae..d8f24ec81a 100644 --- a/drivers/net/rtl8139.c +++ b/drivers/net/rtl8139.c @@ -453,7 +453,7 @@ static int rtl8139_recv_common(struct rtl8139_priv *priv, unsigned char *rxdata, RTL_STS_RXBADALIGN)) || (rx_size < ETH_ZLEN) || (rx_size > ETH_FRAME_LEN + 4)) { - printf("rx error %hX\n", rx_status); + debug("rx error %hX\n", rx_status); /* this clears all interrupts still pending */ rtl8139_reset(priv); return 0;