diff mbox series

[v4,12/39] sandbox: dts: fix qcom pmic gpio

Message ID 20240215-b4-qcom-common-target-v4-12-ed06355c634a@linaro.org
State Superseded
Headers show
Series Qualcomm generic board support | expand

Commit Message

Caleb Connolly Feb. 15, 2024, 8:52 p.m. UTC
Adjust the DT to match upstream bindings.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
 arch/sandbox/dts/sandbox.dtsi | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Neil Armstrong Feb. 19, 2024, 9:48 a.m. UTC | #1
On 15/02/2024 21:52, Caleb Connolly wrote:
> Adjust the DT to match upstream bindings.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>   arch/sandbox/dts/sandbox.dtsi | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/sandbox/dts/sandbox.dtsi b/arch/sandbox/dts/sandbox.dtsi
> index 241f397ba6e7..c93ce7128942 100644
> --- a/arch/sandbox/dts/sandbox.dtsi
> +++ b/arch/sandbox/dts/sandbox.dtsi
> @@ -419,17 +419,16 @@
>   		#size-cells = <0x1>;
>   		pm8916@0 {
>   			compatible = "qcom,spmi-pmic";
> -			reg = <0x0 0x1>;
> +			reg = <0x0 0x0>;
>   			#address-cells = <0x1>;
> -			#size-cells = <0x1>;
> +			#size-cells = <0x0>;
>   
>   			spmi_gpios: gpios@c000 {
>   				compatible = "qcom,pm8916-gpio";
> -				reg = <0xc000 0x400>;
> +				reg = <0xc000>;
>   				gpio-controller;
> -				gpio-count = <4>;
> +				gpio-ranges = <&spmi_gpios 0 0 4>;
>   				#gpio-cells = <2>;
> -				gpio-bank-name="spmi";
>   			};
>   		};
>   	};
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Sumit Garg Feb. 20, 2024, 6:30 a.m. UTC | #2
On Fri, 16 Feb 2024 at 02:22, Caleb Connolly <caleb.connolly@linaro.org> wrote:
>
> Adjust the DT to match upstream bindings.
>
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>  arch/sandbox/dts/sandbox.dtsi | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

-Sumit

> diff --git a/arch/sandbox/dts/sandbox.dtsi b/arch/sandbox/dts/sandbox.dtsi
> index 241f397ba6e7..c93ce7128942 100644
> --- a/arch/sandbox/dts/sandbox.dtsi
> +++ b/arch/sandbox/dts/sandbox.dtsi
> @@ -419,17 +419,16 @@
>                 #size-cells = <0x1>;
>                 pm8916@0 {
>                         compatible = "qcom,spmi-pmic";
> -                       reg = <0x0 0x1>;
> +                       reg = <0x0 0x0>;
>                         #address-cells = <0x1>;
> -                       #size-cells = <0x1>;
> +                       #size-cells = <0x0>;
>
>                         spmi_gpios: gpios@c000 {
>                                 compatible = "qcom,pm8916-gpio";
> -                               reg = <0xc000 0x400>;
> +                               reg = <0xc000>;
>                                 gpio-controller;
> -                               gpio-count = <4>;
> +                               gpio-ranges = <&spmi_gpios 0 0 4>;
>                                 #gpio-cells = <2>;
> -                               gpio-bank-name="spmi";
>                         };
>                 };
>         };
>
> --
> 2.43.1
>
diff mbox series

Patch

diff --git a/arch/sandbox/dts/sandbox.dtsi b/arch/sandbox/dts/sandbox.dtsi
index 241f397ba6e7..c93ce7128942 100644
--- a/arch/sandbox/dts/sandbox.dtsi
+++ b/arch/sandbox/dts/sandbox.dtsi
@@ -419,17 +419,16 @@ 
 		#size-cells = <0x1>;
 		pm8916@0 {
 			compatible = "qcom,spmi-pmic";
-			reg = <0x0 0x1>;
+			reg = <0x0 0x0>;
 			#address-cells = <0x1>;
-			#size-cells = <0x1>;
+			#size-cells = <0x0>;
 
 			spmi_gpios: gpios@c000 {
 				compatible = "qcom,pm8916-gpio";
-				reg = <0xc000 0x400>;
+				reg = <0xc000>;
 				gpio-controller;
-				gpio-count = <4>;
+				gpio-ranges = <&spmi_gpios 0 0 4>;
 				#gpio-cells = <2>;
-				gpio-bank-name="spmi";
 			};
 		};
 	};