| Message ID | 20240215-b4-qcom-common-target-v4-24-ed06355c634a@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Qualcomm generic board support | expand |
On Fri, 16 Feb 2024 at 02:22, Caleb Connolly <caleb.connolly@linaro.org> wrote: > > This board is entirely supported by the generic arch code and DTS. The > board code used to handle turning on the vbus regulator, however this is > now handled via DT. > > With this, the board specific defconfig is also no longer needed, so > drop it as well. > > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > board/qualcomm/qcs404-evb/Makefile | 6 ---- > board/qualcomm/qcs404-evb/qcs404-evb.c | 49 ----------------------------- > configs/qcs404evb_defconfig | 56 ---------------------------------- > 3 files changed, 111 deletions(-) > Glad to see qcs404 being supported by generic defconfig. Reviewed-by: Sumit Garg <sumit.garg@linaro.org> -Sumit > diff --git a/board/qualcomm/qcs404-evb/Makefile b/board/qualcomm/qcs404-evb/Makefile > deleted file mode 100644 > index 4665827e0859..000000000000 > --- a/board/qualcomm/qcs404-evb/Makefile > +++ /dev/null > @@ -1,6 +0,0 @@ > -# SPDX-License-Identifier: GPL-2.0+ > -# > -# (C) Copyright 2022 Sumit Garg <sumit.garg@linaro.org> > -# > - > -obj-y += qcs404-evb.o > diff --git a/board/qualcomm/qcs404-evb/qcs404-evb.c b/board/qualcomm/qcs404-evb/qcs404-evb.c > deleted file mode 100644 > index 1a4b1f97a3ae..000000000000 > --- a/board/qualcomm/qcs404-evb/qcs404-evb.c > +++ /dev/null > @@ -1,49 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0+ > -/* > - * Board init file for QCS404-EVB > - * > - * (C) Copyright 2022 Sumit Garg <sumit.garg@linaro.org> > - */ > - > -#include <common.h> > -#include <cpu_func.h> > -#include <dm.h> > -#include <env.h> > -#include <init.h> > -#include <asm/cache.h> > -#include <asm/gpio.h> > -#include <asm/global_data.h> > -#include <fdt_support.h> > - > -DECLARE_GLOBAL_DATA_PTR; > - > -void qcom_board_init(void) > -{ > - struct udevice *pmic_gpio; > - struct gpio_desc usb_vbus_boost_pin; > - int ret, node; > - > - ret = uclass_get_device_by_name(UCLASS_GPIO, > - "pms405_gpios@c000", > - &pmic_gpio); > - if (ret < 0) { > - printf("Failed to find pms405_gpios@c000 node.\n"); > - return; > - } > - > - node = fdt_subnode_offset(gd->fdt_blob, dev_of_offset(pmic_gpio), > - "usb_vbus_boost_pin"); > - if (node < 0) { > - printf("Failed to find usb_hub_reset_pm dt node.\n"); > - return; > - } > - ret = gpio_request_by_name_nodev(offset_to_ofnode(node), "gpios", 0, > - &usb_vbus_boost_pin, 0); > - if (ret < 0) { > - printf("Failed to request usb_hub_reset_pm gpio.\n"); > - return; > - } > - > - dm_gpio_set_dir_flags(&usb_vbus_boost_pin, > - GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE); > -} > diff --git a/configs/qcs404evb_defconfig b/configs/qcs404evb_defconfig > deleted file mode 100644 > index d85d193895b0..000000000000 > --- a/configs/qcs404evb_defconfig > +++ /dev/null > @@ -1,56 +0,0 @@ > -CONFIG_ARM=y > -CONFIG_SYS_BOARD="qcs404-evb" > -CONFIG_SKIP_LOWLEVEL_INIT=y > -CONFIG_COUNTER_FREQUENCY=19000000 > -CONFIG_POSITION_INDEPENDENT=y > -CONFIG_ARCH_SNAPDRAGON=y > -CONFIG_DEFAULT_DEVICE_TREE="qcs404-evb" > -CONFIG_IDENT_STRING="\nQualcomm QCS404-EVB" > -CONFIG_SYS_LOAD_ADDR=0x80000000 > -CONFIG_FIT=y > -CONFIG_FIT_VERBOSE=y > -CONFIG_BOOTDELAY=5 > -CONFIG_USE_BOOTARGS=y > -CONFIG_BOOTARGS="earlycon ignore_loglevel root= clk_ignore_unused" > -CONFIG_SAVE_PREV_BL_FDT_ADDR=y > -CONFIG_SAVE_PREV_BL_INITRAMFS_START_ADDR=y > -CONFIG_SYS_CBSIZE=512 > -# CONFIG_DISPLAY_CPUINFO is not set > -CONFIG_HUSH_PARSER=y > -CONFIG_SYS_MAXARGS=64 > -CONFIG_CMD_GPIO=y > -CONFIG_CMD_GPT=y > -CONFIG_CMD_MMC=y > -CONFIG_CMD_PART=y > -CONFIG_CMD_USB=y > -CONFIG_CMD_EXT2=y > -CONFIG_CMD_EXT4=y > -CONFIG_CMD_EXT4_WRITE=y > -CONFIG_CMD_FAT=y > -CONFIG_CMD_FS_GENERIC=y > -# CONFIG_NET is not set > -CONFIG_CLK=y > -CONFIG_CLK_QCOM_QCS404=y > -CONFIG_MSM_GPIO=y > -CONFIG_QCOM_PMIC_GPIO=y > -CONFIG_MISC=y > -CONFIG_MMC_HS400_SUPPORT=y > -CONFIG_MMC_SDHCI=y > -CONFIG_MMC_SDHCI_ADMA=y > -CONFIG_MMC_SDHCI_MSM=y > -CONFIG_PHY=y > -CONFIG_PHY_QCOM_USB_HS_28NM=y > -CONFIG_PHY_QCOM_USB_SS=y > -CONFIG_PINCTRL=y > -CONFIG_PINCTRL_QCOM_QCS404=y > -CONFIG_DM_PMIC=y > -CONFIG_PMIC_QCOM=y > -CONFIG_MSM_SERIAL=y > -CONFIG_SPMI_MSM=y > -CONFIG_USB=y > -CONFIG_USB_XHCI_HCD=y > -CONFIG_USB_XHCI_DWC3=y > -CONFIG_USB_DWC3=y > -CONFIG_USB_DWC3_GENERIC=y > -CONFIG_USB_STORAGE=y > -CONFIG_LMB_MAX_REGIONS=64 > > -- > 2.43.1 >
diff --git a/board/qualcomm/qcs404-evb/Makefile b/board/qualcomm/qcs404-evb/Makefile deleted file mode 100644 index 4665827e0859..000000000000 --- a/board/qualcomm/qcs404-evb/Makefile +++ /dev/null @@ -1,6 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0+ -# -# (C) Copyright 2022 Sumit Garg <sumit.garg@linaro.org> -# - -obj-y += qcs404-evb.o diff --git a/board/qualcomm/qcs404-evb/qcs404-evb.c b/board/qualcomm/qcs404-evb/qcs404-evb.c deleted file mode 100644 index 1a4b1f97a3ae..000000000000 --- a/board/qualcomm/qcs404-evb/qcs404-evb.c +++ /dev/null @@ -1,49 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ -/* - * Board init file for QCS404-EVB - * - * (C) Copyright 2022 Sumit Garg <sumit.garg@linaro.org> - */ - -#include <common.h> -#include <cpu_func.h> -#include <dm.h> -#include <env.h> -#include <init.h> -#include <asm/cache.h> -#include <asm/gpio.h> -#include <asm/global_data.h> -#include <fdt_support.h> - -DECLARE_GLOBAL_DATA_PTR; - -void qcom_board_init(void) -{ - struct udevice *pmic_gpio; - struct gpio_desc usb_vbus_boost_pin; - int ret, node; - - ret = uclass_get_device_by_name(UCLASS_GPIO, - "pms405_gpios@c000", - &pmic_gpio); - if (ret < 0) { - printf("Failed to find pms405_gpios@c000 node.\n"); - return; - } - - node = fdt_subnode_offset(gd->fdt_blob, dev_of_offset(pmic_gpio), - "usb_vbus_boost_pin"); - if (node < 0) { - printf("Failed to find usb_hub_reset_pm dt node.\n"); - return; - } - ret = gpio_request_by_name_nodev(offset_to_ofnode(node), "gpios", 0, - &usb_vbus_boost_pin, 0); - if (ret < 0) { - printf("Failed to request usb_hub_reset_pm gpio.\n"); - return; - } - - dm_gpio_set_dir_flags(&usb_vbus_boost_pin, - GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE); -} diff --git a/configs/qcs404evb_defconfig b/configs/qcs404evb_defconfig deleted file mode 100644 index d85d193895b0..000000000000 --- a/configs/qcs404evb_defconfig +++ /dev/null @@ -1,56 +0,0 @@ -CONFIG_ARM=y -CONFIG_SYS_BOARD="qcs404-evb" -CONFIG_SKIP_LOWLEVEL_INIT=y -CONFIG_COUNTER_FREQUENCY=19000000 -CONFIG_POSITION_INDEPENDENT=y -CONFIG_ARCH_SNAPDRAGON=y -CONFIG_DEFAULT_DEVICE_TREE="qcs404-evb" -CONFIG_IDENT_STRING="\nQualcomm QCS404-EVB" -CONFIG_SYS_LOAD_ADDR=0x80000000 -CONFIG_FIT=y -CONFIG_FIT_VERBOSE=y -CONFIG_BOOTDELAY=5 -CONFIG_USE_BOOTARGS=y -CONFIG_BOOTARGS="earlycon ignore_loglevel root= clk_ignore_unused" -CONFIG_SAVE_PREV_BL_FDT_ADDR=y -CONFIG_SAVE_PREV_BL_INITRAMFS_START_ADDR=y -CONFIG_SYS_CBSIZE=512 -# CONFIG_DISPLAY_CPUINFO is not set -CONFIG_HUSH_PARSER=y -CONFIG_SYS_MAXARGS=64 -CONFIG_CMD_GPIO=y -CONFIG_CMD_GPT=y -CONFIG_CMD_MMC=y -CONFIG_CMD_PART=y -CONFIG_CMD_USB=y -CONFIG_CMD_EXT2=y -CONFIG_CMD_EXT4=y -CONFIG_CMD_EXT4_WRITE=y -CONFIG_CMD_FAT=y -CONFIG_CMD_FS_GENERIC=y -# CONFIG_NET is not set -CONFIG_CLK=y -CONFIG_CLK_QCOM_QCS404=y -CONFIG_MSM_GPIO=y -CONFIG_QCOM_PMIC_GPIO=y -CONFIG_MISC=y -CONFIG_MMC_HS400_SUPPORT=y -CONFIG_MMC_SDHCI=y -CONFIG_MMC_SDHCI_ADMA=y -CONFIG_MMC_SDHCI_MSM=y -CONFIG_PHY=y -CONFIG_PHY_QCOM_USB_HS_28NM=y -CONFIG_PHY_QCOM_USB_SS=y -CONFIG_PINCTRL=y -CONFIG_PINCTRL_QCOM_QCS404=y -CONFIG_DM_PMIC=y -CONFIG_PMIC_QCOM=y -CONFIG_MSM_SERIAL=y -CONFIG_SPMI_MSM=y -CONFIG_USB=y -CONFIG_USB_XHCI_HCD=y -CONFIG_USB_XHCI_DWC3=y -CONFIG_USB_DWC3=y -CONFIG_USB_DWC3_GENERIC=y -CONFIG_USB_STORAGE=y -CONFIG_LMB_MAX_REGIONS=64