| Message ID | 20240528-topic-sm8x50-pinctrl-pinconf-v1-1-54d1e9ad7dfa@linaro.org |
|---|---|
| State | Accepted |
| Commit | e948fe5f01dafa07f6fc3e1fcae1354983e5f5a7 |
| Headers | show |
| Series | pinctrl: qcom: allow setting pins configuration for sepcial pins | expand |
Hi Neil, On Tue, 28 May 2024 at 14:02, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Add support for bias-pull-down as an alternate of bias-pull-up. nit: s/alternate/alternative/ > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/pinctrl/qcom/pinctrl-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-qcom.c b/drivers/pinctrl/qcom/pinctrl-qcom.c > index 3c3336e7635..4f4e9a83949 100644 > --- a/drivers/pinctrl/qcom/pinctrl-qcom.c > +++ b/drivers/pinctrl/qcom/pinctrl-qcom.c > @@ -44,6 +44,7 @@ static const struct pinconf_param msm_conf_params[] = { > { "drive-strength", PIN_CONFIG_DRIVE_STRENGTH, 2 }, > { "bias-disable", PIN_CONFIG_BIAS_DISABLE, 0 }, > { "bias-pull-up", PIN_CONFIG_BIAS_PULL_UP, 3 }, > + { "bias-pull-down", PIN_CONFIG_BIAS_PULL_UP, 1 }, Did you mean PIN_CONFIG_BIAS_PULL_DOWN here instead? -Sumit > { "output-high", PIN_CONFIG_OUTPUT, 1, }, > { "output-low", PIN_CONFIG_OUTPUT, 0, }, > }; > > -- > 2.34.1 >
On 29/05/2024 07:33, Sumit Garg wrote: > Hi Neil, > > On Tue, 28 May 2024 at 14:02, Neil Armstrong <neil.armstrong@linaro.org> wrote: >> >> Add support for bias-pull-down as an alternate of bias-pull-up. > > nit: s/alternate/alternative/ > >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> drivers/pinctrl/qcom/pinctrl-qcom.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-qcom.c b/drivers/pinctrl/qcom/pinctrl-qcom.c >> index 3c3336e7635..4f4e9a83949 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-qcom.c >> +++ b/drivers/pinctrl/qcom/pinctrl-qcom.c >> @@ -44,6 +44,7 @@ static const struct pinconf_param msm_conf_params[] = { >> { "drive-strength", PIN_CONFIG_DRIVE_STRENGTH, 2 }, >> { "bias-disable", PIN_CONFIG_BIAS_DISABLE, 0 }, >> { "bias-pull-up", PIN_CONFIG_BIAS_PULL_UP, 3 }, >> + { "bias-pull-down", PIN_CONFIG_BIAS_PULL_UP, 1 }, > > Did you mean PIN_CONFIG_BIAS_PULL_DOWN here instead? Nop, I use the same flag but with the "1" argument instead of "3" which does set a pull-down. Neil > > -Sumit > >> { "output-high", PIN_CONFIG_OUTPUT, 1, }, >> { "output-low", PIN_CONFIG_OUTPUT, 0, }, >> }; >> >> -- >> 2.34.1 >>
diff --git a/drivers/pinctrl/qcom/pinctrl-qcom.c b/drivers/pinctrl/qcom/pinctrl-qcom.c index 3c3336e7635..4f4e9a83949 100644 --- a/drivers/pinctrl/qcom/pinctrl-qcom.c +++ b/drivers/pinctrl/qcom/pinctrl-qcom.c @@ -44,6 +44,7 @@ static const struct pinconf_param msm_conf_params[] = { { "drive-strength", PIN_CONFIG_DRIVE_STRENGTH, 2 }, { "bias-disable", PIN_CONFIG_BIAS_DISABLE, 0 }, { "bias-pull-up", PIN_CONFIG_BIAS_PULL_UP, 3 }, + { "bias-pull-down", PIN_CONFIG_BIAS_PULL_UP, 1 }, { "output-high", PIN_CONFIG_OUTPUT, 1, }, { "output-low", PIN_CONFIG_OUTPUT, 0, }, };
Add support for bias-pull-down as an alternate of bias-pull-up. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- drivers/pinctrl/qcom/pinctrl-qcom.c | 1 + 1 file changed, 1 insertion(+)