| Message ID | 20240821-b4-rb3gen2-v2-2-49b07633f3a8@linaro.org |
|---|---|
| State | Accepted |
| Commit | 259dba80dc8f53ea344ed2b3d4e9f5f06edf6422 |
| Headers | show |
| Series | Qualcomm: add support for SC7280 and the RB3 Gen 2 | expand |
Hi Caleb, On Wed, 21 Aug 2024 at 07:42, Caleb Connolly <caleb.connolly@linaro.org> wrote: > > For running U-Boot as primary bootloader we must define the memory > layout statically. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi b/arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi > new file mode 100644 > index 000000000000..c3ec4a317f7c > --- /dev/null > +++ b/arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2024 Linaro Ltd. > + */ > +/ { > + /* When running as the primary bootloader there is no prior We normally have an empty /* on the first line > + * stage to populate the memory layout for us. We *should* > + * have two nodes here, but ABL does NOT like that. > + * sooo we're stuck with this. > + */ > + memory@80000000 { > + device_type = "memory"; > + reg = <0 0x80000000 0 0x3A800000>, > + <0 0xC0000000 0 0x01800000>, > + <0 0xC3400000 0 0x3CC00000>, > + <1 0x00000000 1 0x00000000>; > + }; > +}; > + > +// RAM Entry 0 : Base 0x0080000000 Size 0x003A800000 > +// RAM Entry 1 : Base 0x00C0000000 Size 0x0001800000 > +// RAM Entry 2 : Base 0x00C3400000 Size 0x003CC00000 > +// RAM Entry 3 : Base 0x0100000000 Size 0x0100000000 > > -- > 2.46.0 > Can you please use lower-case hex? Regards, Simon
diff --git a/arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi b/arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi new file mode 100644 index 000000000000..c3ec4a317f7c --- /dev/null +++ b/arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2024 Linaro Ltd. + */ +/ { + /* When running as the primary bootloader there is no prior + * stage to populate the memory layout for us. We *should* + * have two nodes here, but ABL does NOT like that. + * sooo we're stuck with this. + */ + memory@80000000 { + device_type = "memory"; + reg = <0 0x80000000 0 0x3A800000>, + <0 0xC0000000 0 0x01800000>, + <0 0xC3400000 0 0x3CC00000>, + <1 0x00000000 1 0x00000000>; + }; +}; + +// RAM Entry 0 : Base 0x0080000000 Size 0x003A800000 +// RAM Entry 1 : Base 0x00C0000000 Size 0x0001800000 +// RAM Entry 2 : Base 0x00C3400000 Size 0x003CC00000 +// RAM Entry 3 : Base 0x0100000000 Size 0x0100000000
For running U-Boot as primary bootloader we must define the memory layout statically. Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> --- arch/arm/dts/qcs6490-rb3gen2-u-boot.dtsi | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)