diff mbox series

[v2,1/4] lmb: Fix flags data type in lmb_add_region_flags()

Message ID 20241211022550.2995-2-semen.protsenko@linaro.org
State New
Headers show
Series lmb: Improve style | expand

Commit Message

Sam Protsenko Dec. 11, 2024, 2:25 a.m. UTC 
rgnflags variable in lmb_add_region_flags() has incorrect type: it's
declared as phys_size_t when it should be enum lmb_flags. That
copy-paste mistake was firstly introduced in commit 59c0ea5df33f ("lmb:
Add support of flags for no-map properties"), and then copied further
into commit ed17a33fed29 ("lmb: make LMB memory map persistent and
global"). Fix it by using the correct type to match struct lmb_region
field.

No functional change.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Acked-by: Sughosh Ganu <sughosh.ganu@linaro.org>
---
Changes in v2:
  - Added R-b tag from Ilias
  - Added Acked-by tag from Sughosh
  - Removed Fixes tags, as suggested by Sughosh

 lib/lmb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/lib/lmb.c b/lib/lmb.c
index a695edf70dfa..1d57f48bff67 100644
--- a/lib/lmb.c
+++ b/lib/lmb.c
@@ -202,7 +202,7 @@  static long lmb_add_region_flags(struct alist *lmb_rgn_lst, phys_addr_t base,
 	for (i = 0; i < lmb_rgn_lst->count; i++) {
 		phys_addr_t rgnbase = rgn[i].base;
 		phys_size_t rgnsize = rgn[i].size;
-		phys_size_t rgnflags = rgn[i].flags;
+		enum lmb_flags rgnflags = rgn[i].flags;
 
 		ret = lmb_addrs_adjacent(base, size, rgnbase, rgnsize);
 		if (ret > 0) {