From patchwork Mon Mar 31 12:23:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 877280 Delivered-To: patch@linaro.org Received: by 2002:a5d:6dae:0:b0:38f:210b:807b with SMTP id u14csp1722791wrs; Mon, 31 Mar 2025 05:24:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXMdBdHK9meFsDTbJurCtUTFlG0p96eABpiIfxCvIRSMZF8yRAHEav4zbbe9hvan3hCGkWIEw==@linaro.org X-Google-Smtp-Source: AGHT+IE1169LQeP0zCzM8rdCDHPL+t+8AnQszuREs67QV/2E9odvKf73NeSoNwIjE3Y65/QHDSS1 X-Received: by 2002:a05:6122:218b:b0:520:51a4:b81c with SMTP id 71dfb90a1353d-5261d478794mr4191637e0c.6.1743423875834; Mon, 31 Mar 2025 05:24:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1743423875; cv=none; d=google.com; s=arc-20240605; b=hCEGVMV7xgLEli9cASRbEFSS8G91fJc4FQWQOFpwtviJKIkxFbqaa4hNL08q6uGF6l 7FiQ75SlOFqO64Z7xdcXLorsDrC8s9Kc66Or8Ea2VB6QCNeWEDe8VckOX6zUx/+T13Ro LnffVMsF0IFnNgb/vUPO1vTSgwXwBYtB8kfrKnTwOZ/zJkyszPcKxHfX3I7KS+wRRjn9 63ik6UGVUj0/a+32DGXA/kw2jWM45zfGXVeP4vptF5JVpKZArhjP4OKD1dmoY6nTgeXf R+w2QBPk7tXnacRJP7m3BE37xsE0pg/jCyZFZD196hjxZIzOmSVFHPSAcPT1BOOyiDEC hR4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:cc:to:in-reply-to:references :message-id:content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=Zidw17LZzOK8ylbcZWh7b80v6c7K27Jrs7l8fmBwM94=; fh=7QX1FfKbm7p25v0xg/8cwvM2+AesqalQ3Jmvo/h9Zbc=; b=US1lx5iFtgpjrtr31FT5oYFgxiCoD5owypSIz/g5bHg94nx6cLBJoO9TLHQzPcvhvq sgW7ttYQkNPwmBkEYABTwZenRu5yC0gnvMvbqqtL5nS3Zsi3ErLAlWg6bpAPvNT3+jFq Hqh8fJgYXC1j44zXjhtwLYw+FZBMs9MbYDYf+QOpF7z2/92owccvuEFhUii6w54ceemW iW8+b1jx9IZsy1p0N/Pd4iEl+a29YyD2ZrQU/yOSc97P8EvwFcubPzkLGwxxcnJkpuQj DcIWawE/4xG0aQo0YKmDZ2pnQLZJwQngr74o/09p4QqlrEif8XnXdX69GkzFLrjCkNcT Lf5A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="YPS3/YYn"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from phobos.denx.de (phobos.denx.de. [2a01:238:438b:c500:173d:9f52:ddab:ee01]) by mx.google.com with ESMTPS id 71dfb90a1353d-5260eae2ec7si1713354e0c.185.2025.03.31.05.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 05:24:35 -0700 (PDT) Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="YPS3/YYn"; spf=pass (google.com: domain of u-boot-bounces@lists.denx.de designates 2a01:238:438b:c500:173d:9f52:ddab:ee01 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 179B681FC0; Mon, 31 Mar 2025 14:23:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="YPS3/YYn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8922281F95; Mon, 31 Mar 2025 14:23:54 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7B1F581F32 for ; Mon, 31 Mar 2025 14:23:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=caleb.connolly@linaro.org Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-39c1ef4ae3aso230728f8f.1 for ; Mon, 31 Mar 2025 05:23:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743423832; x=1744028632; darn=lists.denx.de; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Zidw17LZzOK8ylbcZWh7b80v6c7K27Jrs7l8fmBwM94=; b=YPS3/YYnvIMH5QGsJ+ms4ICj9pmrlD8Xcr/1OqmflA9d7tdj3rZY/Ng6jW7In6tw0N xJngEG/ecjfHoQf8t1QdkAYk50WTmIjpONwqrk4gmKS4kXn/2Iiek1926zaz5Mw1vZGP TAkhoAoSlKPJugz528nfqeI50ZsAbExpAkcZjCGy9+sBYincLQtPRP82G3tbI+TIRpqi rYVvY6F32r+f3+kxCitFp3iyiEaeQnhr3/NQ0HaTgUd3QX4UmEDVo58xRz07zBreTJuZ Dun19L8Df2knt2IvieBPBakA6dwJELelmp46TaBZqrwDxA/L3dLWjnf2kmlYRVRxZ/O+ fD1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743423832; x=1744028632; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zidw17LZzOK8ylbcZWh7b80v6c7K27Jrs7l8fmBwM94=; b=HiFPDnJr/iADTPhmnItIGoGbnvCXfxhr9NEmYpeKHPq6kRcMvPrxVn2c5HBZbmRF5J oL5Xqc1cDRLnhsiCeR6HVbQxhzl7JKI9NuznGIzSh6R5DAXvigQkxSaiKkC9cVyILKxk mO8rXL9jYl4B5wClq6TqtVWkmFbY1xTS5nKsztpSHePcarz021bQ/Xi4lchG7uz0zvZ0 wIAaQAAJQmo9L2L4P9FQH1H9K65s8RVyc+m2pax6e14CsnQbRvV7efZp9TgBstxQASjg JZtQDcaD6V0uwh+nzvD8gYs2LfZr2gcT82le6Po0JfRyfu0CDDoSIfS2YuKFPJlhfCEE /cDA== X-Forwarded-Encrypted: i=1; AJvYcCUqBieskIje8xyUvqT4VY0/pe48iomnep9N8CjPQnPtz2rEE9f2wyU+a/CbkzDtLCLF6qQCrw8=@lists.denx.de X-Gm-Message-State: AOJu0YxkKZ4RQ3OsTKgppqbCcn4AV9pDmEh//Y2FAbQOXqgz3YGvnK38 iOunaqRFgdA9OhbrD4vLUyRG+6RoJ7k0EqPwFLAC0eYCUF1h7L+X/NOLHL6RWbk= X-Gm-Gg: ASbGnctIK+X40+GPlK9XtptXzPngQsbaDn2jwRNSAOOVjyU/lBGCxwze1MZ8UhYnfWL D7WU0x+uiYMunhQ8UtGqI+AzoS2T/lc4HEt3VTZseY4+94YYTaNtlsIhj1ecPhHVqn2YsUo0D53 uubrd6CAROfnU2i1IYc/kLdXDM5le5qPNA48m2Qs0Rj7uzb9v3c/H6rmMtcLKM1WLBZjokBayV/ YjtyxNp02y8Qk3L4Weo4Nhac3Q9Vb4iWhWYlPr5X2kntfqcZLZfGZUhD9y4NCG/Tyn6rV/uc4us Y5GR/WxoBEuHmhJeD7+UopIlY3E06fnT7CsWRAodUpyNCz/eIuauRxRViXzIlSeM2kpcYAgOCGN MFqZ6zxIrt3jC X-Received: by 2002:a05:6000:2405:b0:39c:140c:308 with SMTP id ffacd0b85a97d-39c140c036cmr5733307f8f.3.1743423831975; Mon, 31 Mar 2025 05:23:51 -0700 (PDT) Received: from toyger.tail248178.ts.net (i5E863BED.versanet.de. [94.134.59.237]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b60a9ddsm11315562f8f.0.2025.03.31.05.23.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 05:23:50 -0700 (PDT) From: Caleb Connolly Date: Mon, 31 Mar 2025 14:23:22 +0200 Subject: [PATCH v4 5/6] button: qcom-pmic: prettify and standardise button labels MIME-Version: 1.0 Message-Id: <20250331-qcom-phones-v4-5-f52e57d3b8c6@linaro.org> References: <20250331-qcom-phones-v4-0-f52e57d3b8c6@linaro.org> In-Reply-To: <20250331-qcom-phones-v4-0-f52e57d3b8c6@linaro.org> To: Caleb Connolly , Neil Armstrong , Tom Rini , Sumit Garg , Ramon Fried , Jorge Ramirez-Ortiz , Sumit Garg Cc: u-boot-qcom@groups.io, u-boot@lists.denx.de, Danila Tikhonov , Jens Reidel X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2972; i=caleb.connolly@linaro.org; h=from:subject:message-id; bh=fa+Rh9AbOBv8xk5ShaDK49XevY729gSpcGXWYyQnEok=; b=owEBbQKS/ZANAwAKAQWDMSsZX2S2AcsmYgBn6olN98VOFQ9gocXfeRhX1aEHwFBu4Yl8HRvNT FJAc0ktodmJAjMEAAEKAB0WIQS2UaFGPGq+0GkMVc0FgzErGV9ktgUCZ+qJTQAKCRAFgzErGV9k tpT4D/9W1r85BZ238Kt+6v7JmaRFZutT0iRo09XVjXzfKZEYQm1JgabxZyti/jsnmarniStMgHw DfNWfd02n1IVbI/i6MkJuPmOvhQWcLJAgiqjpPPgzJLbKYLcHoowWkP8P0XRRJTEg3pqsbHi7/h sHvfOhrT4zLlUU4TbqodytGcSKbjkWALfjy2UQTW/XKSCcsrf3JyBb7OUKHHPsqLT2wF4Q6q7JQ IdYz3hm+ABXA94nbPZ5K1F/Art6LLFBP3NcSrlBg5qyt/k7ALhlzzIObrueRouSz4hJKkfUipcX nTlmUiebWO+tHgTTxS0rvf8tAOn6xdbotirZp+tNvq72Xdec2ChPGBsgcGNACkOF8p2mouEJXGM /9yctxYUCpg4XAdoTAskkFTznShgfpcIqj5p7B8djo3LrwwcuENnq/YJyPA1CM/9rZjvm5DOF4e pbS61VTwUmrueLpKa7224luunECs6YuEI+M3mSvyjVWH+SL0b8x6bmd2slD1FwHki5qowfm7T2j Yf6xUzbbbnwiY23dBOmw06YrhJlqj6oGPTj7EjfiNDRC2TTQfxRUqljTsFpYWZpO7eLUbI5aC5L dKug1eVFstkOfuWPx6wKxNpT/NBKIboJ+v5X7+zbmcIo8kzxRMwTiqZDj+65YYjajh/CvW31S2D 8Jrza+HQc19e8Yw== X-Developer-Key: i=caleb.connolly@linaro.org; a=openpgp; fpr=83B24DA7FE145076BC38BB250CD904EB673A7C47 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Boards using gpio-keys for volume buttons label them "Volume Down", let's match that here, and make the power button nicer too. This simplifies configuring button_cmds in a board-agnostic way. Tested-by: Danila Tikhonov # google-sunfish Tested-by: Jens Reidel # xiaomi-davinci Signed-off-by: Caleb Connolly Reviewed-by: Neil Armstrong --- board/qualcomm/dragonboard410c/dragonboard410c.c | 2 +- board/qualcomm/dragonboard820c/dragonboard820c.c | 2 +- drivers/button/button-qcom-pmic.c | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/board/qualcomm/dragonboard410c/dragonboard410c.c b/board/qualcomm/dragonboard410c/dragonboard410c.c index fcbf2c3fe60f21bae1c6d64b542a4d9867c33826..d0d82489f53c4f31b7b08bcf6e4269730027874a 100644 --- a/board/qualcomm/dragonboard410c/dragonboard410c.c +++ b/board/qualcomm/dragonboard410c/dragonboard410c.c @@ -71,9 +71,9 @@ int misc_init_r(void) struct udevice *btn; int ret; enum button_state_t state; - ret = button_get_by_label("vol_down", &btn); + ret = button_get_by_label("Volume Down", &btn); if (ret < 0) { printf("Couldn't find power button!\n"); return ret; } diff --git a/board/qualcomm/dragonboard820c/dragonboard820c.c b/board/qualcomm/dragonboard820c/dragonboard820c.c index d3333a59db01caa940224a99df6b43a3375cacf8..12a9273ec4b9d240bc2eaed2834d5265290153ec 100644 --- a/board/qualcomm/dragonboard820c/dragonboard820c.c +++ b/board/qualcomm/dragonboard820c/dragonboard820c.c @@ -105,9 +105,9 @@ int misc_init_r(void) struct udevice *btn; int ret; enum button_state_t state; - ret = button_get_by_label("pwrkey", &btn); + ret = button_get_by_label("Power Button", &btn); if (ret < 0) { printf("Couldn't find power button!\n"); return ret; } diff --git a/drivers/button/button-qcom-pmic.c b/drivers/button/button-qcom-pmic.c index f9f0948ae095f433e35ecfc0f98741ab1a850742..e3bb9bd758aca819b3a10aac84787e703c55d36a 100644 --- a/drivers/button/button-qcom-pmic.c +++ b/drivers/button/button-qcom-pmic.c @@ -72,27 +72,27 @@ static const struct qcom_pmic_btn_data qcom_pmic_btn_data_table[] = { { .compatible = "qcom,pm8941-pwrkey", .status_bit = PON_KPDPWR_N_SET, .code = KEY_ENTER, - .label = "pwrkey", + .label = "Power Button", }, { .compatible = "qcom,pm8941-resin", .status_bit = PON_RESIN_N_SET, .code = KEY_DOWN, - .label = "vol_down", + .label = "Volume Down", }, { .compatible = "qcom,pmk8350-pwrkey", .status_bit = PON_GEN3_KPDPWR_N_SET, .code = KEY_ENTER, - .label = "pwrkey", + .label = "Power Button", }, { .compatible = "qcom,pmk8350-resin", .status_bit = PON_GEN3_RESIN_N_SET, .code = KEY_DOWN, - .label = "vol_down", + .label = "Volume Down", }, }; static const struct qcom_pmic_btn_data *button_qcom_pmic_match(ofnode node)