From patchwork Wed Nov 5 17:22:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Rae X-Patchwork-Id: 40216 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f70.google.com (mail-ee0-f70.google.com [74.125.83.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 296BA240A6 for ; Wed, 5 Nov 2014 17:17:10 +0000 (UTC) Received: by mail-ee0-f70.google.com with SMTP id b57sf1147452eek.5 for ; Wed, 05 Nov 2014 09:17:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:references:in-reply-to:cc:subject:precedence :list-id:list-unsubscribe:list-archive:list-post:list-help :list-subscribe:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list :content-transfer-encoding:content-type; bh=0n87lbVt5a3giWz3Ebv48C3OE60SsIhLFqOmqvG4xcI=; b=OErsJ7esAFRoiWs9SmF/5kUiRsmq/crm4+fuN1Z0mflY6+k7q0LHFxH2F2OYimsiUZ YSLf+dMfYVz7B2lraxeBCEqODPXeQIoKVSkO4QpgRGrD7i5yJq7TA+QSpOXxZqRnFK+P vm6UkoZ/ww5eJFx2T0hQVeMPTs0/F+wu2m6SM7gFENsi+9RYSd59ljVoXe+1sj759FeK 6BTVEM6xljdCRvnjTKY3cN/LSlZuRXkOlUUo6o2rdWYIl2gbf/iSfCTbii7SQt9NpMHS awKEzVUODNfDjX9OqUSg3js3rXRneXHWkb46c0CEPt6YbD62DzqmTLmfJGHddOxRmpOW xIeA== X-Gm-Message-State: ALoCoQmYeEj9uFqJW5cli5KzliuFDFDzSsR4PLS2P2kq9iPtIsMHLpo5u6cjZ6qHsS/Y82nIjfa3 X-Received: by 10.180.90.115 with SMTP id bv19mr5619659wib.1.1415207829420; Wed, 05 Nov 2014 09:17:09 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.22.130 with SMTP id d2ls1128324laf.32.gmail; Wed, 05 Nov 2014 09:17:09 -0800 (PST) X-Received: by 10.152.3.229 with SMTP id f5mr31337492laf.94.1415207829257; Wed, 05 Nov 2014 09:17:09 -0800 (PST) Received: from mail-la0-f49.google.com (mail-la0-f49.google.com. [209.85.215.49]) by mx.google.com with ESMTPS id b4si7236893lbd.70.2014.11.05.09.17.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 05 Nov 2014 09:17:08 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) client-ip=209.85.215.49; Received: by mail-la0-f49.google.com with SMTP id ge10so1062403lab.8 for ; Wed, 05 Nov 2014 09:17:08 -0800 (PST) X-Received: by 10.112.14.69 with SMTP id n5mr68970527lbc.34.1415207828489; Wed, 05 Nov 2014 09:17:08 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp319287lbc; Wed, 5 Nov 2014 09:17:08 -0800 (PST) X-Received: by 10.180.36.229 with SMTP id t5mr33736580wij.56.1415207827816; Wed, 05 Nov 2014 09:17:07 -0800 (PST) Received: from theia.denx.de (theia.denx.de. [85.214.87.163]) by mx.google.com with ESMTP id g10si6291974wiw.5.2014.11.05.09.17.07 for ; Wed, 05 Nov 2014 09:17:07 -0800 (PST) Received-SPF: none (google.com: u-boot-bounces@lists.denx.de does not designate permitted sender hosts) client-ip=85.214.87.163; Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4D3154BE15; Wed, 5 Nov 2014 18:17:06 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BmcVQ4q-e8WJ; Wed, 5 Nov 2014 18:17:05 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 681264BC23; Wed, 5 Nov 2014 18:17:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 020F04BC23 for ; Wed, 5 Nov 2014 18:17:01 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3wr-2EIl5ypn for ; Wed, 5 Nov 2014 18:17:00 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-gw2-out.broadcom.com (mail-gw2-out.broadcom.com [216.31.210.63]) by theia.denx.de (Postfix) with ESMTP id 7F3F14BC17 for ; Wed, 5 Nov 2014 18:16:56 +0100 (CET) X-IronPort-AV: E=Sophos;i="5.07,321,1413270000"; d="scan'208";a="49955279" Received: from irvexchcas07.broadcom.com (HELO IRVEXCHCAS07.corp.ad.broadcom.com) ([10.9.208.55]) by mail-gw2-out.broadcom.com with ESMTP; 05 Nov 2014 09:41:48 -0800 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS07.corp.ad.broadcom.com (10.9.208.55) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 5 Nov 2014 09:16:55 -0800 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.3.174.1; Wed, 5 Nov 2014 09:17:01 -0800 Received: from [10.136.4.105] (lbrmn-vmlnx03.ric.broadcom.com [10.136.4.105]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 7A67B40FED; Wed, 5 Nov 2014 09:16:33 -0800 (PST) Message-ID: <545A5CB9.7090906@broadcom.com> Date: Wed, 5 Nov 2014 09:22:01 -0800 From: Steve Rae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Simon Glass , Jeroen Hofstee References: <54526E0F.5090500@broadcom.com> <5452A2A6.5000601@broadcom.com> <5452A643.6000309@myspectrum.nl> In-Reply-To: Cc: "u-boot@lists.denx.de" Subject: Re: [U-Boot] buildman: using wrong libgcc.a X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: srae@broadcom.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 On 14-11-03 01:14 PM, Simon Glass wrote: > Hi, > > On 30 October 2014 14:57, Jeroen Hofstee wrote: >> Hello Steve, >> >> On 30-10-14 21:42, Steve Rae wrote: >>> >>> Hmmmm -- maybe it would be better to specify the entire path for the >>> CROSS_COMPILE, and not rely on the PATH to find the cross compile tools: >>> >>> diff --git a/tools/buildman/toolchain.py b/tools/buildman/toolchain.py >>> index 27dc318..58c7b1f 100644 >>> --- a/tools/buildman/toolchain.py >>> +++ b/tools/buildman/toolchain.py >>> @@ -33,6 +33,7 @@ class Toolchain: >>> self.cross = os.path.basename(fname)[:-3] >>> pos = self.cross.find('-') >>> self.arch = self.cross[:pos] if pos != -1 else 'sandbox' >>> + self.cross = fname[:-3] >>> >> >> A bit off topic, but is it possible to stop adding these magic 3 >> constants. strlen("clang") != 3. strlen("cc") isn't either. Anyway >> I am aware buildman is already full with it, so I am fine with >> one more (for now). > > This should be isolated to Toolchain. I'd be happy to have a fix that > solves this once and for all. What is needed? > > Regards, > Simon > ( back to the original issue ) @@ -82,7 +83,6 @@ class Toolchain: """ env = dict(os.environ) env['CROSS_COMPILE'] = self.cross - env['PATH'] += (':' + self.path) return env This solves my problem, however, I have only built "arm" and "armv8" targets.... So I don't know whether it breaks any other environments. How can we proceed? Thanks, Steve diff --git a/tools/buildman/toolchain.py b/tools/buildman/toolchain.py index 27dc318..58c7b1f 100644 --- a/tools/buildman/toolchain.py +++ b/tools/buildman/toolchain.py @@ -33,6 +33,7 @@ class Toolchain: self.cross = os.path.basename(fname)[:-3] pos = self.cross.find('-') self.arch = self.cross[:pos] if pos != -1 else 'sandbox' + self.cross = fname[:-3] env = self.MakeEnvironment()