diff mbox series

[v11,20/29] net-lwip: lwIP wget supports user defined port in the uri, so allow it.

Message ID c14ec8b9788c30c205f7b605c9d2b46ebdcdcc91.1727968902.git.jerome.forissier@linaro.org
State New
Headers show
Series Introduce the lwIP network stack | expand

Commit Message

Jerome Forissier Oct. 3, 2024, 3:46 p.m. UTC 
From: Jonathan Humphreys <j-humphreys@ti.com>

Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com>
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
---
 net/lwip/wget.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Ilias Apalodimas Oct. 4, 2024, 7:11 a.m. UTC | #1 
On Thu, 3 Oct 2024 at 18:47, Jerome Forissier
<jerome.forissier@linaro.org> wrote:
>
> From: Jonathan Humphreys <j-humphreys@ti.com>

A short description is missing here

Thanks
/Ilias
>
> Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  net/lwip/wget.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/net/lwip/wget.c b/net/lwip/wget.c
> index e8768fc2acd..b495ebd1aa9 100644
> --- a/net/lwip/wget.c
> +++ b/net/lwip/wget.c
> @@ -349,12 +349,6 @@ bool wget_validate_uri(char *uri)
>                 ret = false;
>                 goto out;
>         }
> -       s = strchr(authority, ':');
> -       if (s) {
> -               log_err("user defined port is not supported\n");
> -               ret = false;
> -               goto out;
> -       }
>
>  out:
>         free(str_copy);
> --
> 2.40.1
>
Jerome Forissier Oct. 4, 2024, 8:36 a.m. UTC | #2 
On 10/4/24 09:11, Ilias Apalodimas wrote:
> On Thu, 3 Oct 2024 at 18:47, Jerome Forissier
> <jerome.forissier@linaro.org> wrote:
>>
>> From: Jonathan Humphreys <j-humphreys@ti.com>
> 
> A short description is missing here

I will fold this patch into the previous one since it was a review
comment from Jonathan H. ; Jonathan I hope you don't mind?

Thanks,
Jon Humphreys Oct. 5, 2024, 3:26 a.m. UTC | #3 
Jerome Forissier <jerome.forissier@linaro.org> writes:

> On 10/4/24 09:11, Ilias Apalodimas wrote:
>> On Thu, 3 Oct 2024 at 18:47, Jerome Forissier
>> <jerome.forissier@linaro.org> wrote:
>>>
>>> From: Jonathan Humphreys <j-humphreys@ti.com>
>> 
>> A short description is missing here
>
> I will fold this patch into the previous one since it was a review
> comment from Jonathan H. ; Jonathan I hope you don't mind?
>

No problem.

Jon

> Thanks,
> -- 
> Jerome
>
>> 
>> Thanks
>> /Ilias
>>>
>>> Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com>
>>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
>>> ---
>>>  net/lwip/wget.c | 6 ------
>>>  1 file changed, 6 deletions(-)
>>>
>>> diff --git a/net/lwip/wget.c b/net/lwip/wget.c
>>> index e8768fc2acd..b495ebd1aa9 100644
>>> --- a/net/lwip/wget.c
>>> +++ b/net/lwip/wget.c
>>> @@ -349,12 +349,6 @@ bool wget_validate_uri(char *uri)
>>>                 ret = false;
>>>                 goto out;
>>>         }
>>> -       s = strchr(authority, ':');
>>> -       if (s) {
>>> -               log_err("user defined port is not supported\n");
>>> -               ret = false;
>>> -               goto out;
>>> -       }
>>>
>>>  out:
>>>         free(str_copy);
>>> --
>>> 2.40.1
>>>
diff mbox series

Patch

diff --git a/net/lwip/wget.c b/net/lwip/wget.c
index e8768fc2acd..b495ebd1aa9 100644
--- a/net/lwip/wget.c
+++ b/net/lwip/wget.c
@@ -349,12 +349,6 @@  bool wget_validate_uri(char *uri)
 		ret = false;
 		goto out;
 	}
-	s = strchr(authority, ':');
-	if (s) {
-		log_err("user defined port is not supported\n");
-		ret = false;
-		goto out;
-	}
 
 out:
 	free(str_copy);