diff mbox series

[v11,02/29] Make AVB_VERIFY depend on FASTBOOT

Message ID c32debd7420b430fdc6cc35695825bf01a5b7b0d.1727968902.git.jerome.forissier@linaro.org
State Accepted
Commit ce1023de730ffa37beae46a5276061a74a041a09
Headers show
Series Introduce the lwIP network stack | expand

Commit Message

Jerome Forissier Oct. 3, 2024, 3:22 p.m. UTC
Note: Patch posted separately [0].

[0] http://patchwork.ozlabs.org/project/uboot/patch/20241002144845.1439316-1-jerome.forissier@linaro.org/

AVB_BUF_ADDR, which is under "if AVB_VERIFY", defaults to
FASTBOOT_BUF_ADDR. Therefore AVB_VERIFY should depend on FASTBOOT.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
---
 common/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass Oct. 9, 2024, 1:51 a.m. UTC | #1
On Thu, 3 Oct 2024 at 09:23, Jerome Forissier
<jerome.forissier@linaro.org> wrote:
>
> Note: Patch posted separately [0].
>
> [0] http://patchwork.ozlabs.org/project/uboot/patch/20241002144845.1439316-1-jerome.forissier@linaro.org/
>
> AVB_BUF_ADDR, which is under "if AVB_VERIFY", defaults to
> FASTBOOT_BUF_ADDR. Therefore AVB_VERIFY should depend on FASTBOOT.
>
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  common/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Simon Glass <sjg@chromium.org>


> diff --git a/common/Kconfig b/common/Kconfig
> index 957de0c5c02..c011ab6e820 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -850,6 +850,7 @@ config AVB_VERIFY
>         depends on LIBAVB
>         depends on MMC
>         depends on PARTITION_UUIDS
> +       depends on FASTBOOT
>         help
>           This option enables compilation of bootloader-dependent operations,
>           used by Android Verified Boot 2.0 library (libavb). Includes:
> --
> 2.40.1
>
Jerome Forissier Oct. 9, 2024, 12:31 p.m. UTC | #2
On 10/9/24 03:51, Simon Glass wrote:
> On Thu, 3 Oct 2024 at 09:23, Jerome Forissier
> <jerome.forissier@linaro.org> wrote:
>>
>> Note: Patch posted separately [0].
>>
>> [0] http://patchwork.ozlabs.org/project/uboot/patch/20241002144845.1439316-1-jerome.forissier@linaro.org/
>>
>> AVB_BUF_ADDR, which is under "if AVB_VERIFY", defaults to
>> FASTBOOT_BUF_ADDR. Therefore AVB_VERIFY should depend on FASTBOOT.
>>
>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
>> ---
>>  common/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>

Thanks. Would you mind replying to the patch linked in the description?
As I will be removing that one from lwIP v12.

Regards,
diff mbox series

Patch

diff --git a/common/Kconfig b/common/Kconfig
index 957de0c5c02..c011ab6e820 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -850,6 +850,7 @@  config AVB_VERIFY
 	depends on LIBAVB
 	depends on MMC
 	depends on PARTITION_UUIDS
+	depends on FASTBOOT
 	help
 	  This option enables compilation of bootloader-dependent operations,
 	  used by Android Verified Boot 2.0 library (libavb). Includes: