mbox series

[edk2,0/7] ArmPlatformPkg cleanup - phase II

Message ID 20171130141509.27230-1-ard.biesheuvel@linaro.org
Headers show
Series ArmPlatformPkg cleanup - phase II | expand

Message

Ard Biesheuvel Nov. 30, 2017, 2:15 p.m. UTC 
Proceed with removing junk from ArmPlatformPkg, and tidying up the bits
we want to keep.

While we make up our minds how to proceed with the migration of
ArmVExpressPkg, and the dependent BootMonFs and ShellCmdRunAxf modules,
this series removes the outdated documentation and CTA9x4 code, moves
some header files out of Include/Drivers, and removes some unused stuff
from ArmPlatformLib.

Ard Biesheuvel (7):
  ArmPlatformPkg/Documentation: remove outdated porting manual
  ArmPlatformPkg: remove unused ArmVExpressLibCTA9x4 code
  ArmPlatformPkg/ArmPlatformLib: remove
    ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR
  ArmPlatformPkg: remove ArmPlatformInitializeSystemMemory
  ArmPlatformPkg: move internal PL061 header into driver directory
  ArmPlatformPkg: move internal SP805 header into driver directory
  ArmPlatformPkg: move internal PL031 header into driver directory

 ArmPlatformPkg/ArmPlatformPkg.dec                                                      |   1 -
 ArmPlatformPkg/ArmVExpressPkg/Include/Platform/CTA9x4/ArmPlatform.h                    | 121 ------------
 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c                |  13 --
 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLib.inf          |  57 ------
 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLibSec.inf       |  54 ------
 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4.c                    | 198 --------------------
 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.S              |  49 -----
 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.asm            |  63 -------
 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c                 | 119 ------------
 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c                        |  14 --
 ArmPlatformPkg/Documentation/ARM-EDK2-Overview.png                                     | Bin 54500 -> 0 bytes
 ArmPlatformPkg/Documentation/ArmPlatformLib-2nd-Stage.png                              | Bin 56506 -> 0 bytes
 ArmPlatformPkg/Documentation/ArmPlatformLib-Full-Boot.png                              | Bin 79676 -> 0 bytes
 ArmPlatformPkg/Documentation/ArmPlatformPkg.txt                                        |  74 --------
 ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c                                        |   3 +-
 ArmPlatformPkg/{Include/Drivers => Drivers/PL061GpioDxe}/PL061Gpio.h                   |   0
 ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c                                |   3 +-
 ArmPlatformPkg/{Include/Drivers => Drivers/SP805WatchdogDxe}/SP805Watchdog.h           |   0
 ArmPlatformPkg/Include/Library/ArmPlatformLib.h                                        |  24 ---
 ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.c                         |  14 --
 ArmPlatformPkg/{Include/Drivers => Library/PL031RealTimeClockLib}/PL031RealTimeClock.h |   0
 ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c                   |  19 +-
 ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c                                          |   8 -
 ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf                                        |   1 -
 BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoard.c                                    |  14 --
 25 files changed, 13 insertions(+), 836 deletions(-)
 delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Include/Platform/CTA9x4/ArmPlatform.h
 delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLib.inf
 delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLibSec.inf
 delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4.c
 delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.S
 delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.asm
 delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c
 delete mode 100644 ArmPlatformPkg/Documentation/ARM-EDK2-Overview.png
 delete mode 100644 ArmPlatformPkg/Documentation/ArmPlatformLib-2nd-Stage.png
 delete mode 100644 ArmPlatformPkg/Documentation/ArmPlatformLib-Full-Boot.png
 delete mode 100644 ArmPlatformPkg/Documentation/ArmPlatformPkg.txt
 rename ArmPlatformPkg/{Include/Drivers => Drivers/PL061GpioDxe}/PL061Gpio.h (100%)
 rename ArmPlatformPkg/{Include/Drivers => Drivers/SP805WatchdogDxe}/SP805Watchdog.h (100%)
 rename ArmPlatformPkg/{Include/Drivers => Library/PL031RealTimeClockLib}/PL031RealTimeClock.h (100%)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Nov. 30, 2017, 3:55 p.m. UTC | #1 
On Thu, Nov 30, 2017 at 02:15:02PM +0000, Ard Biesheuvel wrote:
> Proceed with removing junk from ArmPlatformPkg, and tidying up the bits

> we want to keep.

> 

> While we make up our minds how to proceed with the migration of

> ArmVExpressPkg, and the dependent BootMonFs and ShellCmdRunAxf modules,

> this series removes the outdated documentation and CTA9x4 code, moves

> some header files out of Include/Drivers, and removes some unused stuff

> from ArmPlatformLib.


Good stuff. For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> Ard Biesheuvel (7):

>   ArmPlatformPkg/Documentation: remove outdated porting manual

>   ArmPlatformPkg: remove unused ArmVExpressLibCTA9x4 code

>   ArmPlatformPkg/ArmPlatformLib: remove

>     ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR

>   ArmPlatformPkg: remove ArmPlatformInitializeSystemMemory

>   ArmPlatformPkg: move internal PL061 header into driver directory

>   ArmPlatformPkg: move internal SP805 header into driver directory

>   ArmPlatformPkg: move internal PL031 header into driver directory

> 

>  ArmPlatformPkg/ArmPlatformPkg.dec                                                      |   1 -

>  ArmPlatformPkg/ArmVExpressPkg/Include/Platform/CTA9x4/ArmPlatform.h                    | 121 ------------

>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c                |  13 --

>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLib.inf          |  57 ------

>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLibSec.inf       |  54 ------

>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4.c                    | 198 --------------------

>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.S              |  49 -----

>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.asm            |  63 -------

>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c                 | 119 ------------

>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c                        |  14 --

>  ArmPlatformPkg/Documentation/ARM-EDK2-Overview.png                                     | Bin 54500 -> 0 bytes

>  ArmPlatformPkg/Documentation/ArmPlatformLib-2nd-Stage.png                              | Bin 56506 -> 0 bytes

>  ArmPlatformPkg/Documentation/ArmPlatformLib-Full-Boot.png                              | Bin 79676 -> 0 bytes

>  ArmPlatformPkg/Documentation/ArmPlatformPkg.txt                                        |  74 --------

>  ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c                                        |   3 +-

>  ArmPlatformPkg/{Include/Drivers => Drivers/PL061GpioDxe}/PL061Gpio.h                   |   0

>  ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c                                |   3 +-

>  ArmPlatformPkg/{Include/Drivers => Drivers/SP805WatchdogDxe}/SP805Watchdog.h           |   0

>  ArmPlatformPkg/Include/Library/ArmPlatformLib.h                                        |  24 ---

>  ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.c                         |  14 --

>  ArmPlatformPkg/{Include/Drivers => Library/PL031RealTimeClockLib}/PL031RealTimeClock.h |   0

>  ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c                   |  19 +-

>  ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c                                          |   8 -

>  ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf                                        |   1 -

>  BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoard.c                                    |  14 --

>  25 files changed, 13 insertions(+), 836 deletions(-)

>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Include/Platform/CTA9x4/ArmPlatform.h

>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLib.inf

>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLibSec.inf

>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4.c

>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.S

>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.asm

>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c

>  delete mode 100644 ArmPlatformPkg/Documentation/ARM-EDK2-Overview.png

>  delete mode 100644 ArmPlatformPkg/Documentation/ArmPlatformLib-2nd-Stage.png

>  delete mode 100644 ArmPlatformPkg/Documentation/ArmPlatformLib-Full-Boot.png

>  delete mode 100644 ArmPlatformPkg/Documentation/ArmPlatformPkg.txt

>  rename ArmPlatformPkg/{Include/Drivers => Drivers/PL061GpioDxe}/PL061Gpio.h (100%)

>  rename ArmPlatformPkg/{Include/Drivers => Drivers/SP805WatchdogDxe}/SP805Watchdog.h (100%)

>  rename ArmPlatformPkg/{Include/Drivers => Library/PL031RealTimeClockLib}/PL031RealTimeClock.h (100%)

> 

> -- 

> 2.11.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Nov. 30, 2017, 4:10 p.m. UTC | #2 
On 30 November 2017 at 15:55, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Nov 30, 2017 at 02:15:02PM +0000, Ard Biesheuvel wrote:

>> Proceed with removing junk from ArmPlatformPkg, and tidying up the bits

>> we want to keep.

>>

>> While we make up our minds how to proceed with the migration of

>> ArmVExpressPkg, and the dependent BootMonFs and ShellCmdRunAxf modules,

>> this series removes the outdated documentation and CTA9x4 code, moves

>> some header files out of Include/Drivers, and removes some unused stuff

>> from ArmPlatformLib.

>

> Good stuff. For the series:

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>


Thanks. Pushed as f0d9d2b61726..c6e51751e026

>> Ard Biesheuvel (7):

>>   ArmPlatformPkg/Documentation: remove outdated porting manual

>>   ArmPlatformPkg: remove unused ArmVExpressLibCTA9x4 code

>>   ArmPlatformPkg/ArmPlatformLib: remove

>>     ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR

>>   ArmPlatformPkg: remove ArmPlatformInitializeSystemMemory

>>   ArmPlatformPkg: move internal PL061 header into driver directory

>>   ArmPlatformPkg: move internal SP805 header into driver directory

>>   ArmPlatformPkg: move internal PL031 header into driver directory

>>

>>  ArmPlatformPkg/ArmPlatformPkg.dec                                                      |   1 -

>>  ArmPlatformPkg/ArmVExpressPkg/Include/Platform/CTA9x4/ArmPlatform.h                    | 121 ------------

>>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c                |  13 --

>>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLib.inf          |  57 ------

>>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLibSec.inf       |  54 ------

>>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4.c                    | 198 --------------------

>>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.S              |  49 -----

>>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.asm            |  63 -------

>>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c                 | 119 ------------

>>  ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c                        |  14 --

>>  ArmPlatformPkg/Documentation/ARM-EDK2-Overview.png                                     | Bin 54500 -> 0 bytes

>>  ArmPlatformPkg/Documentation/ArmPlatformLib-2nd-Stage.png                              | Bin 56506 -> 0 bytes

>>  ArmPlatformPkg/Documentation/ArmPlatformLib-Full-Boot.png                              | Bin 79676 -> 0 bytes

>>  ArmPlatformPkg/Documentation/ArmPlatformPkg.txt                                        |  74 --------

>>  ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c                                        |   3 +-

>>  ArmPlatformPkg/{Include/Drivers => Drivers/PL061GpioDxe}/PL061Gpio.h                   |   0

>>  ArmPlatformPkg/Drivers/SP805WatchdogDxe/SP805Watchdog.c                                |   3 +-

>>  ArmPlatformPkg/{Include/Drivers => Drivers/SP805WatchdogDxe}/SP805Watchdog.h           |   0

>>  ArmPlatformPkg/Include/Library/ArmPlatformLib.h                                        |  24 ---

>>  ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.c                         |  14 --

>>  ArmPlatformPkg/{Include/Drivers => Library/PL031RealTimeClockLib}/PL031RealTimeClock.h |   0

>>  ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c                   |  19 +-

>>  ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c                                          |   8 -

>>  ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf                                        |   1 -

>>  BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoard.c                                    |  14 --

>>  25 files changed, 13 insertions(+), 836 deletions(-)

>>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Include/Platform/CTA9x4/ArmPlatform.h

>>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLib.inf

>>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/ArmVExpressLibSec.inf

>>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4.c

>>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.S

>>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Helper.asm

>>  delete mode 100644 ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c

>>  delete mode 100644 ArmPlatformPkg/Documentation/ARM-EDK2-Overview.png

>>  delete mode 100644 ArmPlatformPkg/Documentation/ArmPlatformLib-2nd-Stage.png

>>  delete mode 100644 ArmPlatformPkg/Documentation/ArmPlatformLib-Full-Boot.png

>>  delete mode 100644 ArmPlatformPkg/Documentation/ArmPlatformPkg.txt

>>  rename ArmPlatformPkg/{Include/Drivers => Drivers/PL061GpioDxe}/PL061Gpio.h (100%)

>>  rename ArmPlatformPkg/{Include/Drivers => Drivers/SP805WatchdogDxe}/SP805Watchdog.h (100%)

>>  rename ArmPlatformPkg/{Include/Drivers => Library/PL031RealTimeClockLib}/PL031RealTimeClock.h (100%)

>>

>> --

>> 2.11.0

>>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel