mbox series

[edk2,0/4] remove all 11 occurrences of ELILO on IPF PE/COFF header hack

Message ID 20180906134523.2036-1-ard.biesheuvel@linaro.org
Headers show
Series remove all 11 occurrences of ELILO on IPF PE/COFF header hack | expand

Message

Ard Biesheuvel Sept. 6, 2018, 1:45 p.m. UTC 
Now that Itanium support has been dropped from EDK2, we can remove all 11 (!)
occurrences of the ELILO PE/COFF loader hack from the code base.

Note that SecurityPkg appears to have four mostly identical implementations
of the PE/COFF measuring routine, so this may be another area for cleanup
later.

Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816

Cc: Star Zeng <star.zeng@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>

Ard Biesheuvel (4):
  MdeModulePkg: remove PE/COFF header workaround for ELILO on IPF
  MdePkg/BasePeCoffLib: remove PE/COFF header workaround for ELILO on
    IPF
  SecurityPkg: remove PE/COFF header workaround for ELILO on IPF
  EdkCompatibilityPkg: remove PE/COFF header workaround for ELILO on IPF

 .../Library/BasePeCoffLib/BasePeCoff.c        | 60 +++---------------
 .../Core/Dxe/Mem/MemoryProfileRecord.c        | 31 +---------
 MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 17 +-----
 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 17 +-----
 .../Core/PiSmmCore/MemoryAttributesTable.c    | 17 +-----
 .../Core/PiSmmCore/SmramProfileRecord.c       | 31 +---------
 MdePkg/Library/BasePeCoffLib/BasePeCoff.c     | 61 +++----------------
 .../DxeImageVerificationLib.c                 | 47 +++-----------
 .../DxeTpmMeasureBootLib.c                    | 27 ++------
 SecurityPkg/Tcg/Tcg2Dxe/MeasureBootPeCoff.c   | 27 ++------
 .../SecureBootConfigImpl.c                    | 25 ++------
 11 files changed, 47 insertions(+), 313 deletions(-)

-- 
2.18.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Yao, Jiewen Sept. 6, 2018, 2:05 p.m. UTC | #1 
Thanks for the clean up.

Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>


> -----Original Message-----

> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]

> Sent: Thursday, September 6, 2018 9:45 PM

> To: edk2-devel@lists.01.org

> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Zeng, Star

> <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Kinney, Michael

> D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Zhang,

> Chao B <chao.b.zhang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Laszlo

> Ersek <lersek@redhat.com>; Leif Lindholm <leif.lindholm@linaro.org>

> Subject: [PATCH 0/4] remove all 11 occurrences of ELILO on IPF PE/COFF header

> hack

> 

> Now that Itanium support has been dropped from EDK2, we can remove all 11

> (!)

> occurrences of the ELILO PE/COFF loader hack from the code base.

> 

> Note that SecurityPkg appears to have four mostly identical implementations

> of the PE/COFF measuring routine, so this may be another area for cleanup

> later.

> 

> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=816

> 

> Cc: Star Zeng <star.zeng@intel.com>

> Cc: Jian J Wang <jian.j.wang@intel.com>

> Cc: Michael D Kinney <michael.d.kinney@intel.com>

> Cc: Liming Gao <liming.gao@intel.com>

> Cc: Chao Zhang <chao.b.zhang@intel.com>

> Cc: Jiewen Yao <jiewen.yao@intel.com>

> Cc: Laszlo Ersek <lersek@redhat.com>

> Cc: Leif Lindholm <leif.lindholm@linaro.org>

> 

> Ard Biesheuvel (4):

>   MdeModulePkg: remove PE/COFF header workaround for ELILO on IPF

>   MdePkg/BasePeCoffLib: remove PE/COFF header workaround for ELILO on

>     IPF

>   SecurityPkg: remove PE/COFF header workaround for ELILO on IPF

>   EdkCompatibilityPkg: remove PE/COFF header workaround for ELILO on IPF

> 

>  .../Library/BasePeCoffLib/BasePeCoff.c        | 60 +++---------------

>  .../Core/Dxe/Mem/MemoryProfileRecord.c        | 31 +---------

>  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 17 +-----

>  MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 17 +-----

>  .../Core/PiSmmCore/MemoryAttributesTable.c    | 17 +-----

>  .../Core/PiSmmCore/SmramProfileRecord.c       | 31 +---------

>  MdePkg/Library/BasePeCoffLib/BasePeCoff.c     | 61 +++----------------

>  .../DxeImageVerificationLib.c                 | 47 +++-----------

>  .../DxeTpmMeasureBootLib.c                    | 27 ++------

>  SecurityPkg/Tcg/Tcg2Dxe/MeasureBootPeCoff.c   | 27 ++------

>  .../SecureBootConfigImpl.c                    | 25 ++------

>  11 files changed, 47 insertions(+), 313 deletions(-)

> 

> --

> 2.18.0


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel